)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"f38948cc13586829e14da5829aca851342055b50","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add key repository uniqueness check to doctor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Just like underwear, key repositories shouldn\u0027t be shared. This commit adds a"},{"line_number":10,"context_line":"check to `keystone-manage doctor` to make sure `[credential] key_repository`"},{"line_number":11,"context_line":"and `[fernet_tokens] key_repository` are not pointing to the same location."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_09c17f54","line":9,"updated":"2016-08-23 12:02:00.000000000","message":"lol","commit_id":"25d359186f29b9a808b437a4c354693fb2f83587"}],"keystone/cmd/doctor/credential.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"667ef8ad7bb57bfc1bd19d37576be3f68f539cb3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \"\"\"Key repositories for encryption should be unique."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Even though credentials are encrypted using the same mechanism as Fernet"},{"line_number":23,"context_line":"    tokens, they shoud have key repository locations that are independent of"},{"line_number":24,"context_line":"    one another. Using the same repository to encrypt credentials and tokens"},{"line_number":25,"context_line":"    can be considered a security vulnerability because ciphertext from the keys"},{"line_number":26,"context_line":"    used to encrypt credentials is exposed as the token ID. Sharing a key"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_f7854359","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":22},"updated":"2016-08-21 14:53:56.000000000","message":"should","commit_id":"736917d30cdba63e45f3d824f0eadac0c63e0f8d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d1ae0c39c806b527457cdc79d12976ed87f3998b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \"\"\"Key repositories for encryption should be unique."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    Even though credentials are encrypted using the same mechanism as Fernet"},{"line_number":23,"context_line":"    tokens, they shoud have key repository locations that are independent of"},{"line_number":24,"context_line":"    one another. Using the same repository to encrypt credentials and tokens"},{"line_number":25,"context_line":"    can be considered a security vulnerability because ciphertext from the keys"},{"line_number":26,"context_line":"    used to encrypt credentials is exposed as the token ID. Sharing a key"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_cc0dfa91","line":23,"in_reply_to":"1ac06dbe_f7854359","updated":"2016-08-22 13:22:22.000000000","message":"Done","commit_id":"736917d30cdba63e45f3d824f0eadac0c63e0f8d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"667ef8ad7bb57bfc1bd19d37576be3f68f539cb3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    can be considered a security vulnerability because ciphertext from the keys"},{"line_number":26,"context_line":"    used to encrypt credentials is exposed as the token ID. Sharing a key"},{"line_number":27,"context_line":"    repository can also lead to premature key removal during key rotation. This"},{"line_number":28,"context_line":"    could result in un-decipherable credentials, rendering them completely"},{"line_number":29,"context_line":"    useless, or early token invalidation because the key that was used to"},{"line_number":30,"context_line":"    encrypt the entity has been deleted."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_37f7dbf6","line":28,"range":{"start_line":28,"start_character":20,"end_line":28,"end_character":35},"updated":"2016-08-21 14:53:56.000000000","message":"indecipherable?","commit_id":"736917d30cdba63e45f3d824f0eadac0c63e0f8d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d1ae0c39c806b527457cdc79d12976ed87f3998b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    can be considered a security vulnerability because ciphertext from the keys"},{"line_number":26,"context_line":"    used to encrypt credentials is exposed as the token ID. Sharing a key"},{"line_number":27,"context_line":"    repository can also lead to premature key removal during key rotation. This"},{"line_number":28,"context_line":"    could result in un-decipherable credentials, rendering them completely"},{"line_number":29,"context_line":"    useless, or early token invalidation because the key that was used to"},{"line_number":30,"context_line":"    encrypt the entity has been deleted."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_ac107ea9","line":28,"in_reply_to":"1ac06dbe_37f7dbf6","updated":"2016-08-22 13:22:22.000000000","message":"Done","commit_id":"736917d30cdba63e45f3d824f0eadac0c63e0f8d"}]}
