)]}'
{"keystone/oauth1/controllers.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"3ba58937b7500318377a3ff22df250877bce1cb6","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                        \u0027error\u0027: params[\u0027error\u0027],"},{"line_number":256,"context_line":"                        \u0027desc\u0027: params[\u0027error_description\u0027]}"},{"line_number":257,"context_line":"            else:"},{"line_number":258,"context_line":"                msg \u003d _(\u0027There should not be any non-oauth parameters.\u0027)"},{"line_number":259,"context_line":"            LOG.warning(msg)"},{"line_number":260,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":261,"context_line":"        request_token_duration \u003d CONF.oauth1.request_token_duration"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_c1d3645e","line":258,"range":{"start_line":258,"start_character":25,"end_line":258,"end_character":70},"updated":"2016-09-19 12:49:50.000000000","message":"maybe \"Unknown parameters found. Please provide only oauth parameters.\" is clearer. Maybe also return the correct/expected params.","commit_id":"464f50cfa4dd655e44a37ea8ef150cc2a1cb0390"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"b64d7c0d95cce58d51a60fc210fa9dea4ffeb131","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                        \u0027error\u0027: params[\u0027error\u0027],"},{"line_number":256,"context_line":"                        \u0027desc\u0027: params[\u0027error_description\u0027]}"},{"line_number":257,"context_line":"            else:"},{"line_number":258,"context_line":"                msg \u003d _(\u0027There should not be any non-oauth parameters.\u0027)"},{"line_number":259,"context_line":"            LOG.warning(msg)"},{"line_number":260,"context_line":"            raise exception.ValidationError(message\u003dmsg)"},{"line_number":261,"context_line":"        request_token_duration \u003d CONF.oauth1.request_token_duration"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_3c740dfc","line":258,"range":{"start_line":258,"start_character":25,"end_line":258,"end_character":70},"in_reply_to":"7a8ec9b2_c1d3645e","updated":"2016-09-20 02:18:50.000000000","message":"This is the original words, will be update.","commit_id":"464f50cfa4dd655e44a37ea8ef150cc2a1cb0390"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"898fd388cbb05a1896b96c3c0476bfd896030c9f","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                msg \u003d _(\u0027Invalid signature.\u0027)"},{"line_number":351,"context_line":"            LOG.warning(msg)"},{"line_number":352,"context_line":"            raise exception.Unauthorized(message\u003dmsg)"},{"line_number":353,"context_line":"        params \u003d oauth1.extract_non_oauth_params(b)"},{"line_number":354,"context_line":"        # Invalid request would end up with the body like below:"},{"line_number":355,"context_line":"        # \u0027error\u003dinvalid_request\u0026description\u003dmissing+resource+owner+key\u0027"},{"line_number":356,"context_line":"        # Log this detail message so that we will know where is the"},{"line_number":357,"context_line":"        # validation failed."},{"line_number":358,"context_line":"        if params:"},{"line_number":359,"context_line":"            if \u0027error\u0027 in params:"},{"line_number":360,"context_line":"                msg \u003d _("},{"line_number":361,"context_line":"                    \u0027Validation failed with errors: %(error)s, detail \u0027"},{"line_number":362,"context_line":"                    \u0027message is: %(desc)s.\u0027) % {"},{"line_number":363,"context_line":"                        \u0027error\u0027: params[\u0027error\u0027],"},{"line_number":364,"context_line":"                        \u0027desc\u0027: params[\u0027error_description\u0027]}"},{"line_number":365,"context_line":"            else:"},{"line_number":366,"context_line":"                msg \u003d _(\u0027There should not be any non-oauth parameters.\u0027)"},{"line_number":367,"context_line":"            LOG.warning(msg)"},{"line_number":368,"context_line":"            raise exception.Unauthorized(message\u003dmsg)"},{"line_number":369,"context_line":"        if not req_token.get(\u0027authorizing_user_id\u0027):"},{"line_number":370,"context_line":"            msg \u003d _(\u0027Request Token does not have an authorizing user id.\u0027)"},{"line_number":371,"context_line":"            LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_6bd04254","line":368,"range":{"start_line":353,"start_character":8,"end_line":368,"end_character":53},"updated":"2016-09-21 05:00:51.000000000","message":"this is now the same code as above","commit_id":"750bd67d958a46de932729a877c1a3e384ae0cc3"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"2253c37bf4f4bb8dced0aebcef2e61adb138967e","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                msg \u003d _(\u0027Invalid signature.\u0027)"},{"line_number":351,"context_line":"            LOG.warning(msg)"},{"line_number":352,"context_line":"            raise exception.Unauthorized(message\u003dmsg)"},{"line_number":353,"context_line":"        params \u003d oauth1.extract_non_oauth_params(b)"},{"line_number":354,"context_line":"        # Invalid request would end up with the body like below:"},{"line_number":355,"context_line":"        # \u0027error\u003dinvalid_request\u0026description\u003dmissing+resource+owner+key\u0027"},{"line_number":356,"context_line":"        # Log this detail message so that we will know where is the"},{"line_number":357,"context_line":"        # validation failed."},{"line_number":358,"context_line":"        if params:"},{"line_number":359,"context_line":"            if \u0027error\u0027 in params:"},{"line_number":360,"context_line":"                msg \u003d _("},{"line_number":361,"context_line":"                    \u0027Validation failed with errors: %(error)s, detail \u0027"},{"line_number":362,"context_line":"                    \u0027message is: %(desc)s.\u0027) % {"},{"line_number":363,"context_line":"                        \u0027error\u0027: params[\u0027error\u0027],"},{"line_number":364,"context_line":"                        \u0027desc\u0027: params[\u0027error_description\u0027]}"},{"line_number":365,"context_line":"            else:"},{"line_number":366,"context_line":"                msg \u003d _(\u0027There should not be any non-oauth parameters.\u0027)"},{"line_number":367,"context_line":"            LOG.warning(msg)"},{"line_number":368,"context_line":"            raise exception.Unauthorized(message\u003dmsg)"},{"line_number":369,"context_line":"        if not req_token.get(\u0027authorizing_user_id\u0027):"},{"line_number":370,"context_line":"            msg \u003d _(\u0027Request Token does not have an authorizing user id.\u0027)"},{"line_number":371,"context_line":"            LOG.warning(msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_5d7fb716","line":368,"range":{"start_line":353,"start_character":8,"end_line":368,"end_character":53},"in_reply_to":"7a8ec9b2_6bd04254","updated":"2016-09-21 11:21:59.000000000","message":"addressed here: https://review.openstack.org/#/c/374043 ;)","commit_id":"750bd67d958a46de932729a877c1a3e384ae0cc3"}],"keystone/tests/unit/test_v3_oauth1.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"3ba58937b7500318377a3ff22df250877bce1cb6","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        consumer \u003d {\u0027key\u0027: consumer_id, \u0027secret\u0027: consumer_secret}"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        url \u003d \u0027/OS-OAUTH1/request_token\u0027"},{"line_number":841,"context_line":"        auth_header \u003d \u0027OAuth oauth_version\u003d\"1.0\", oauth_consumer_key\u003d\u0027 + \\"},{"line_number":842,"context_line":"            consumer_id"},{"line_number":843,"context_line":"        faked_header \u003d {\u0027Authorization\u0027: auth_header,"},{"line_number":844,"context_line":"                        \u0027requested_project_id\u0027: self.project_id}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_a12ad82d","line":841,"range":{"start_line":841,"start_character":73,"end_line":841,"end_character":74},"updated":"2016-09-19 12:49:50.000000000","message":"wrap inside () instead of using \\","commit_id":"464f50cfa4dd655e44a37ea8ef150cc2a1cb0390"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"b64d7c0d95cce58d51a60fc210fa9dea4ffeb131","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        consumer \u003d {\u0027key\u0027: consumer_id, \u0027secret\u0027: consumer_secret}"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        url \u003d \u0027/OS-OAUTH1/request_token\u0027"},{"line_number":841,"context_line":"        auth_header \u003d \u0027OAuth oauth_version\u003d\"1.0\", oauth_consumer_key\u003d\u0027 + \\"},{"line_number":842,"context_line":"            consumer_id"},{"line_number":843,"context_line":"        faked_header \u003d {\u0027Authorization\u0027: auth_header,"},{"line_number":844,"context_line":"                        \u0027requested_project_id\u0027: self.project_id}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_5c9ab9c6","line":841,"range":{"start_line":841,"start_character":73,"end_line":841,"end_character":74},"in_reply_to":"7a8ec9b2_a12ad82d","updated":"2016-09-20 02:18:50.000000000","message":"Done","commit_id":"464f50cfa4dd655e44a37ea8ef150cc2a1cb0390"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"3ba58937b7500318377a3ff22df250877bce1cb6","unresolved":false,"context_lines":[{"line_number":848,"context_line":"            expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":849,"context_line":"        resp_data \u003d jsonutils.loads(resp.body)"},{"line_number":850,"context_line":"        self.assertIn(\u0027Validation failed with errors\u0027,"},{"line_number":851,"context_line":"                      resp_data.get(\u0027error\u0027, {}).get(\u0027message\u0027))"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    def test_expired_authorizing_request_token(self):"},{"line_number":854,"context_line":"        self.config_fixture.config(group\u003d\u0027oauth1\u0027, request_token_duration\u003d-1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_61c7f064","line":851,"range":{"start_line":851,"start_character":32,"end_line":851,"end_character":63},"updated":"2016-09-19 12:49:50.000000000","message":"you should be able to access them directly, right (resp_data[\u0027error\u0027][\u0027message\u0027])? Otherwise it means something is wrong","commit_id":"464f50cfa4dd655e44a37ea8ef150cc2a1cb0390"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"b64d7c0d95cce58d51a60fc210fa9dea4ffeb131","unresolved":false,"context_lines":[{"line_number":848,"context_line":"            expected_status\u003dhttp_client.BAD_REQUEST)"},{"line_number":849,"context_line":"        resp_data \u003d jsonutils.loads(resp.body)"},{"line_number":850,"context_line":"        self.assertIn(\u0027Validation failed with errors\u0027,"},{"line_number":851,"context_line":"                      resp_data.get(\u0027error\u0027, {}).get(\u0027message\u0027))"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    def test_expired_authorizing_request_token(self):"},{"line_number":854,"context_line":"        self.config_fixture.config(group\u003d\u0027oauth1\u0027, request_token_duration\u003d-1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_bc801d48","line":851,"range":{"start_line":851,"start_character":32,"end_line":851,"end_character":63},"in_reply_to":"7a8ec9b2_61c7f064","updated":"2016-09-20 02:18:50.000000000","message":"Done","commit_id":"464f50cfa4dd655e44a37ea8ef150cc2a1cb0390"}]}