)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"eac9b50c9ceefdac4e4f34ea139d06cc3e8fe43e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nam Nguyen Hoai \u003cnamnh@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-30 11:42:29 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix formatting strings when using nultiple variables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Following OpenStack Style Guidelines:[H703]"},{"line_number":10,"context_line":"http://docs.openstack.org/developer/hacking/#internationalization-i18n-strings"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_0ae97114","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":42},"updated":"2016-08-29 04:43:45.000000000","message":"multiple*","commit_id":"7bc76959a1f11e0782ff6b092506584344825f19"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"12edb499934a5043cfdbda0fe169314b42e5c1f5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nam Nguyen Hoai \u003cnamnh@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-30 11:42:29 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix formatting strings when using nultiple variables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Following OpenStack Style Guidelines:[H703]"},{"line_number":10,"context_line":"http://docs.openstack.org/developer/hacking/#internationalization-i18n-strings"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_cafa29bd","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":42},"in_reply_to":"fa7ab95a_0ae97114","updated":"2016-08-29 04:48:32.000000000","message":"Thanks Mr.Martinelli\n\nI will update this point right now. By the way, could I ask you a question: With LOG-waring/error without variable like this link [1]. Should we change to:\n\u0027\u0027\u0027\u0027\nmsg \u003d _LW(....)\nLOG.error \u003d (msg)\n\u0027\u0027\u0027\n\n[1] https://github.com/openstack/keystone/blob/master/keystone/exception.py#L66","commit_id":"7bc76959a1f11e0782ff6b092506584344825f19"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7a18ddeee6e2ea53a1be821d3d8d99f45c5a429c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nam Nguyen Hoai \u003cnamnh@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-30 11:42:29 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix formatting strings when using nultiple variables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Following OpenStack Style Guidelines:[H703]"},{"line_number":10,"context_line":"http://docs.openstack.org/developer/hacking/#internationalization-i18n-strings"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_2ac1d52e","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":42},"in_reply_to":"fa7ab95a_aab885e6","updated":"2016-08-29 04:58:44.000000000","message":"probably doesn\u0027t need to be changed :)","commit_id":"7bc76959a1f11e0782ff6b092506584344825f19"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"32e1730e20fce04de8456e4436d258eaab9d1986","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nam Nguyen Hoai \u003cnamnh@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-30 11:42:29 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix formatting strings when using nultiple variables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Following OpenStack Style Guidelines:[H703]"},{"line_number":10,"context_line":"http://docs.openstack.org/developer/hacking/#internationalization-i18n-strings"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_ea1c4d15","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":42},"in_reply_to":"fa7ab95a_cafa29bd","updated":"2016-08-29 04:49:38.000000000","message":"s/LOG.error/LOG.warring/","commit_id":"7bc76959a1f11e0782ff6b092506584344825f19"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"acb831a40939b51c0d0d043ac7347cf787431ab8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nam Nguyen Hoai \u003cnamnh@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-30 11:42:29 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix formatting strings when using nultiple variables"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Following OpenStack Style Guidelines:[H703]"},{"line_number":10,"context_line":"http://docs.openstack.org/developer/hacking/#internationalization-i18n-strings"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_aab885e6","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":42},"in_reply_to":"fa7ab95a_ea1c4d15","updated":"2016-08-29 04:51:39.000000000","message":"Oh.. I understood. We don\u0027t need change. :-). Right?","commit_id":"7bc76959a1f11e0782ff6b092506584344825f19"}],"keystone/common/utils.py":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"46d1a0ea6e1cd24c2c8a811484195f0dd5a8e332","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                raise exception.PasswordVerificationError(size\u003dmax_length)"},{"line_number":132,"context_line":"            else:"},{"line_number":133,"context_line":"                LOG.warning("},{"line_number":134,"context_line":"                    _LW(\u0027Truncating user password to \u0027"},{"line_number":135,"context_line":"                        \u0027%d characters.\u0027), max_length)"},{"line_number":136,"context_line":"                return password[:max_length]"},{"line_number":137,"context_line":"        else:"},{"line_number":138,"context_line":"            return password"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_47bb72e5","line":135,"range":{"start_line":134,"start_character":20,"end_line":135,"end_character":53},"updated":"2016-08-29 04:16:08.000000000","message":"We should change these _LW\u0027s as well to be inline with the change of the _LE per rule from [H702].","commit_id":"a06931bafe647da504aa11df6cfc0d21745fb214"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"29064c032cea0b87ec579018299f07d077f581ac","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                raise exception.PasswordVerificationError(size\u003dmax_length)"},{"line_number":132,"context_line":"            else:"},{"line_number":133,"context_line":"                LOG.warning("},{"line_number":134,"context_line":"                    _LW(\u0027Truncating user password to \u0027"},{"line_number":135,"context_line":"                        \u0027%d characters.\u0027), max_length)"},{"line_number":136,"context_line":"                return password[:max_length]"},{"line_number":137,"context_line":"        else:"},{"line_number":138,"context_line":"            return password"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_07ddea0d","line":135,"range":{"start_line":134,"start_character":20,"end_line":135,"end_character":53},"in_reply_to":"fa7ab95a_47bb72e5","updated":"2016-08-29 04:23:11.000000000","message":"Thanks for your comment. Currently, I am searching an \"LE\" keyword. I will continue with \"LW\" keywork in next patch set. But I will update this point as yours. :) Is it ok?","commit_id":"a06931bafe647da504aa11df6cfc0d21745fb214"},{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"1f3c38de0e44c12fa0229e738c8e7933223fcb89","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            if CONF.strict_password_check:"},{"line_number":131,"context_line":"                raise exception.PasswordVerificationError(size\u003dmax_length)"},{"line_number":132,"context_line":"            else:"},{"line_number":133,"context_line":"                msg \u003d _LW(\"Truncating user password to \u0027%d characters.\")"},{"line_number":134,"context_line":"                LOG.warning(msg, max_length)"},{"line_number":135,"context_line":"                return password[:max_length]"},{"line_number":136,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_ca278910","line":133,"updated":"2016-08-29 05:02:47.000000000","message":"nit: there is a missing \u0027.","commit_id":"9c705f8bced2285762260971e028071909de9f51"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"1862f3c77cabcc11d6497ebc21a458294e1e930b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            if CONF.strict_password_check:"},{"line_number":131,"context_line":"                raise exception.PasswordVerificationError(size\u003dmax_length)"},{"line_number":132,"context_line":"            else:"},{"line_number":133,"context_line":"                msg \u003d _LW(\"Truncating user password to \u0027%d characters.\")"},{"line_number":134,"context_line":"                LOG.warning(msg, max_length)"},{"line_number":135,"context_line":"                return password[:max_length]"},{"line_number":136,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_0a317105","line":133,"in_reply_to":"fa7ab95a_ca278910","updated":"2016-08-29 05:17:37.000000000","message":"Oh-no :(","commit_id":"9c705f8bced2285762260971e028071909de9f51"}]}
