)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"938297c4669e13e37d2ec007873653772399070e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-08-29 16:43:48 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix wrong response codes in \u0027groups\u0027 APIs."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I2cd3970d9eac00d9d832f97d44f0750671ecb131"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_a1a5f8a2","line":8,"updated":"2016-08-29 11:36:50.000000000","message":"please add details about what is wrong in the response codes","commit_id":"d2df3035eab8f4f6d98c64e53dec8d3768ef3bad"}],"api-ref/source/v3/groups.inc":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"12883e62ef8e9439665cd39fde5bb4647c2b1866","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Deletes a group."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Normal response codes: 204"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Error response codes: 413, 415, 405, 404, 403, 401, 400, 503, 409"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"fa7ab95a_83c38eec","line":121,"updated":"2016-08-29 14:26:40.000000000","message":"Is this correct? I would guess we actually return a 200.","commit_id":"d2df3035eab8f4f6d98c64e53dec8d3768ef3bad"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"9f60071c8efbea869822d1382c90781d45769835","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Deletes a group."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Normal response codes: 204"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Error response codes: 413, 415, 405, 404, 403, 401, 400, 503, 409"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"fa7ab95a_96e4a3e1","line":121,"in_reply_to":"fa7ab95a_83c38eec","updated":"2016-08-29 16:53:20.000000000","message":"++","commit_id":"d2df3035eab8f4f6d98c64e53dec8d3768ef3bad"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"71a6a6c52aad9d416d157a1764d16fc0cfeb0138","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Deletes a group."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Normal response codes: 204"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Error response codes: 413, 415, 405, 404, 403, 401, 400, 503, 409"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"fa7ab95a_577bf227","line":121,"in_reply_to":"fa7ab95a_96e4a3e1","updated":"2016-08-29 18:18:54.000000000","message":"204 is fine, there\u0027s no return https://github.com/openstack/keystone/blob/e755970bfefc3ff6e0fc37cf70b2205d0eff97b5/keystone/identity/controllers.py#L342-L344\n\nso it\u0027s No Content, all deletes in keystone are 204","commit_id":"d2df3035eab8f4f6d98c64e53dec8d3768ef3bad"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"938297c4669e13e37d2ec007873653772399070e","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Adds a user to a group."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Normal response codes: 200, 201"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Error response codes: 413,415,405,404,403,401,400,503,409"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"fa7ab95a_418fcc29","line":142,"range":{"start_line":142,"start_character":23,"end_line":142,"end_character":31},"updated":"2016-08-29 11:36:50.000000000","message":"how can the same endpoint return two different status for success?\n\nsince it is a PUT, think the correct response code is 201.","commit_id":"d2df3035eab8f4f6d98c64e53dec8d3768ef3bad"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"12883e62ef8e9439665cd39fde5bb4647c2b1866","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"Adds a user to a group."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Normal response codes: 200, 201"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Error response codes: 413,415,405,404,403,401,400,503,409"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"fa7ab95a_63620a40","line":142,"range":{"start_line":142,"start_character":23,"end_line":142,"end_character":31},"in_reply_to":"fa7ab95a_418fcc29","updated":"2016-08-29 14:26:40.000000000","message":"It\u0027s actually a 200 as I don\u0027t think we ever give back a 201. We could actually return different codes it we wanted to so that we could indicated if a record was created or just updated. Right now though we only 200.","commit_id":"d2df3035eab8f4f6d98c64e53dec8d3768ef3bad"}]}