)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7f73b64ef78ea2c68303f7599e935d81e890ffb1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The v3_to_v2_token() method in keystone.token.providers.common"},{"line_number":10,"context_line":"accepted token_id as an option parameter. This is because it was"},{"line_number":11,"context_line":"never always passed in on validation. This commit makes token_id"},{"line_number":12,"context_line":"a required parameter of the method and fixes its useage to always"},{"line_number":13,"context_line":"supply it."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_5194e241","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":12},"updated":"2016-08-29 17:42:44.000000000","message":"not always?","commit_id":"c7ad5edfd02ac6a4f18408656b54f348d28ae5a1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1569ca176e64dcca8379fc2df5b388d5a82bff7d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The v3_to_v2_token() method in keystone.token.providers.common"},{"line_number":10,"context_line":"accepted token_id as an option parameter. This is because it was"},{"line_number":11,"context_line":"never always passed in on validation. This commit makes token_id"},{"line_number":12,"context_line":"a required parameter of the method and fixes its useage to always"},{"line_number":13,"context_line":"supply it."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_71d9e621","line":11,"in_reply_to":"fa7ab95a_5194e241","updated":"2016-08-29 17:44:23.000000000","message":"Done","commit_id":"c7ad5edfd02ac6a4f18408656b54f348d28ae5a1"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"7f73b64ef78ea2c68303f7599e935d81e890ffb1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The v3_to_v2_token() method in keystone.token.providers.common"},{"line_number":10,"context_line":"accepted token_id as an option parameter. This is because it was"},{"line_number":11,"context_line":"never always passed in on validation. This commit makes token_id"},{"line_number":12,"context_line":"a required parameter of the method and fixes its useage to always"},{"line_number":13,"context_line":"supply it."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6cc9c7a0e306dbbad61c77caa07df00fb3fa7a97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_71ef26e9","line":12,"range":{"start_line":12,"start_character":49,"end_line":12,"end_character":55},"updated":"2016-08-29 17:42:44.000000000","message":"usage","commit_id":"c7ad5edfd02ac6a4f18408656b54f348d28ae5a1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1569ca176e64dcca8379fc2df5b388d5a82bff7d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The v3_to_v2_token() method in keystone.token.providers.common"},{"line_number":10,"context_line":"accepted token_id as an option parameter. This is because it was"},{"line_number":11,"context_line":"never always passed in on validation. This commit makes token_id"},{"line_number":12,"context_line":"a required parameter of the method and fixes its useage to always"},{"line_number":13,"context_line":"supply it."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6cc9c7a0e306dbbad61c77caa07df00fb3fa7a97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_91d66aef","line":12,"in_reply_to":"fa7ab95a_71ef26e9","updated":"2016-08-29 17:44:23.000000000","message":"Done","commit_id":"c7ad5edfd02ac6a4f18408656b54f348d28ae5a1"}],"keystone/token/providers/common.py":[{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"0fe89975d6b63b63349c6d0c046310635c5282b0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        V3TokenDataHelper.get_token_data() and converts it to look like a v2.0"},{"line_number":45,"context_line":"        token dictionary."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        :param v3_token_data: dictionary formatted for v3 tokens"},{"line_number":48,"context_line":"        :returns: dictionary formatted for v2 tokens"},{"line_number":49,"context_line":"        :raises keystone.exception.Unauthorized: If a specific token type is"},{"line_number":50,"context_line":"            not supported in v2."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_60e1159a","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":64},"updated":"2016-08-29 16:35:05.000000000","message":"suggest adding the token_id to the docstring as well:\n:param token_id...","commit_id":"9a10dd310b230af1f5c28b7ee331fc85064747c1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ca0d185be4b68d9de6641618c52383f876e6ccc0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        V3TokenDataHelper.get_token_data() and converts it to look like a v2.0"},{"line_number":45,"context_line":"        token dictionary."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        :param v3_token_data: dictionary formatted for v3 tokens"},{"line_number":48,"context_line":"        :returns: dictionary formatted for v2 tokens"},{"line_number":49,"context_line":"        :raises keystone.exception.Unauthorized: If a specific token type is"},{"line_number":50,"context_line":"            not supported in v2."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_ccb93a7b","line":47,"in_reply_to":"fa7ab95a_60e1159a","updated":"2016-08-29 17:18:52.000000000","message":"Oh - good call! Done.","commit_id":"9a10dd310b230af1f5c28b7ee331fc85064747c1"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"9471055771cb9d08b924449b63a801e5fad923a0","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        token dictionary."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        :param v3_token_data: dictionary formatted for v3 tokens"},{"line_number":48,"context_line":"        :param token_id: ID of the token being converted"},{"line_number":49,"context_line":"        :returns: dictionary formatted for v2 tokens"},{"line_number":50,"context_line":"        :raises keystone.exception.Unauthorized: If a specific token type is"},{"line_number":51,"context_line":"            not supported in v2."}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_cec20fe9","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":56},"updated":"2016-08-29 17:33:13.000000000","message":"++","commit_id":"c7ad5edfd02ac6a4f18408656b54f348d28ae5a1"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c15d6a7abb829f6803da6fff6a8edde8c23ada5f","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        except exception.ValidationError:"},{"line_number":787,"context_line":"            LOG.exception(_LE(\u0027Failed to validate token\u0027))"},{"line_number":788,"context_line":"            token_id \u003d token_ref[\u0027token_data\u0027][\u0027access\u0027][\u0027token\u0027][\u0027id\u0027]"},{"line_number":789,"context_line":"            raise exception.TokenNotFound(token_id\u003dtoken_id)"},{"line_number":790,"context_line":""},{"line_number":791,"context_line":"    def validate_non_persistent_token(self, token_id):"},{"line_number":792,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_e89b4316","side":"PARENT","line":789,"updated":"2016-08-29 19:16:57.000000000","message":"Actually - no separate patch is required!","commit_id":"ed5df6f26fa41a9500e68177f3e7306d64da8651"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"d0526481de1b01b2d620cf0048fee0c6c37487f2","unresolved":false,"context_lines":[{"line_number":778,"context_line":"            # management layer is now pluggable, one can always provide"},{"line_number":779,"context_line":"            # their own implementation to suit their needs."},{"line_number":780,"context_line":"            token_data \u003d token_ref.get(\u0027token_data\u0027)"},{"line_number":781,"context_line":"            token_id \u003d token_ref[\u0027id\u0027]"},{"line_number":782,"context_line":"            if (self.get_token_version(token_data) !\u003d token.provider.V2):"},{"line_number":783,"context_line":"                # Validate the V3 token as V2"},{"line_number":784,"context_line":"                token_data \u003d self.v2_token_data_helper.v3_to_v2_token("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_025686cd","line":781,"range":{"start_line":781,"start_character":23,"end_line":781,"end_character":38},"updated":"2016-08-29 18:29:23.000000000","message":"shouldn\u0027t this be  token_ref[\u0027token_data\u0027][\u0027access\u0027][\u0027token\u0027][\u0027id\u0027]?\n\nAs it was before @ L788 ?","commit_id":"94b08af4314bf6552183573fb2f92ceca15dd50a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3f122ab616c69c7de77a21fc8abff140d285ebe0","unresolved":false,"context_lines":[{"line_number":778,"context_line":"            # management layer is now pluggable, one can always provide"},{"line_number":779,"context_line":"            # their own implementation to suit their needs."},{"line_number":780,"context_line":"            token_data \u003d token_ref.get(\u0027token_data\u0027)"},{"line_number":781,"context_line":"            token_id \u003d token_ref[\u0027id\u0027]"},{"line_number":782,"context_line":"            if (self.get_token_version(token_data) !\u003d token.provider.V2):"},{"line_number":783,"context_line":"                # Validate the V3 token as V2"},{"line_number":784,"context_line":"                token_data \u003d self.v2_token_data_helper.v3_to_v2_token("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_e866e34f","line":781,"in_reply_to":"fa7ab95a_025686cd","updated":"2016-08-29 19:15:30.000000000","message":"That\u0027s what I thought, too :) \n\ntoken_ref isn\u0027t actually a v2 token reference... it a token reference from the token model. Fixing line 785 can probably be done in a separate patch (which I can post).","commit_id":"94b08af4314bf6552183573fb2f92ceca15dd50a"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"62021163fcca3249b545ed88e5b47905fe140e63","unresolved":false,"context_lines":[{"line_number":778,"context_line":"            # management layer is now pluggable, one can always provide"},{"line_number":779,"context_line":"            # their own implementation to suit their needs."},{"line_number":780,"context_line":"            token_data \u003d token_ref.get(\u0027token_data\u0027)"},{"line_number":781,"context_line":"            token_id \u003d token_ref[\u0027id\u0027]"},{"line_number":782,"context_line":"            if (self.get_token_version(token_data) !\u003d token.provider.V2):"},{"line_number":783,"context_line":"                # Validate the V3 token as V2"},{"line_number":784,"context_line":"                token_data \u003d self.v2_token_data_helper.v3_to_v2_token("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_63daf4e9","line":781,"in_reply_to":"fa7ab95a_6312f458","updated":"2016-08-29 19:31:39.000000000","message":"Actually - it looks like none of the code in this method is actually able to raise a ValidationError. It looks like it no longer applies. I can propose a patch to remove the try/except since it doesn\u0027t appear to be needed.","commit_id":"94b08af4314bf6552183573fb2f92ceca15dd50a"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"5c892a2c13ccac4d0b47bffc9d45c8b4efd48339","unresolved":false,"context_lines":[{"line_number":778,"context_line":"            # management layer is now pluggable, one can always provide"},{"line_number":779,"context_line":"            # their own implementation to suit their needs."},{"line_number":780,"context_line":"            token_data \u003d token_ref.get(\u0027token_data\u0027)"},{"line_number":781,"context_line":"            token_id \u003d token_ref[\u0027id\u0027]"},{"line_number":782,"context_line":"            if (self.get_token_version(token_data) !\u003d token.provider.V2):"},{"line_number":783,"context_line":"                # Validate the V3 token as V2"},{"line_number":784,"context_line":"                token_data \u003d self.v2_token_data_helper.v3_to_v2_token("}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_6312f458","line":781,"in_reply_to":"fa7ab95a_e866e34f","updated":"2016-08-29 19:20:55.000000000","message":"So, as discussed in IRC, the other way to access it was wrong (cc lbragstad). We need to add a test for the case where ValidationError happens (there is no test for that otherwise it\u0027d have failed!)\n\ncan be done as a follow up","commit_id":"94b08af4314bf6552183573fb2f92ceca15dd50a"}]}