)]}'
{"keystone/federation/core.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"61e2d8fd4924112a2ae7bbc1af68488a776a92ea","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def create_protocol(self, idp_id, protocol_id, protocol):"},{"line_number":118,"context_line":"        # validate mapping exists"},{"line_number":119,"context_line":"        self.driver.get_mapping(protocol[\u0027mapping_id\u0027])"},{"line_number":120,"context_line":"        return self.driver.create_protocol(idp_id, protocol_id, protocol)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def update_protocol(self, idp_id, protocol_id, protocol):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_460a567a","line":119,"updated":"2016-09-07 15:58:35.000000000","message":"I think this will return a 404 to the user if the mapping doesn\u0027t exist. I don\u0027t think that is what we want here as it\u0027s really a validation error.","commit_id":"890d7f62c01379ba5b8d6fde46da27b1fe6a4a88"},{"author":{"_account_id":18338,"name":"Ron De Rose","email":"ronald.de.rose@intel.com","username":"derosenet"},"change_message_id":"832b67ad0a411ef047a8622b7e85b507f1e7736d","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def create_protocol(self, idp_id, protocol_id, protocol):"},{"line_number":118,"context_line":"        # validate mapping exists"},{"line_number":119,"context_line":"        self.driver.get_mapping(protocol[\u0027mapping_id\u0027])"},{"line_number":120,"context_line":"        return self.driver.create_protocol(idp_id, protocol_id, protocol)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def update_protocol(self, idp_id, protocol_id, protocol):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_ad0bf122","line":119,"in_reply_to":"9a89bdaa_460a567a","updated":"2016-09-07 21:10:01.000000000","message":"Thanks Stanek, however I haven\u0027t handled the validation yet, still WIP.","commit_id":"890d7f62c01379ba5b8d6fde46da27b1fe6a4a88"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e630c61d4b99b5aba9ab11518000f886c41b56cb","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def create_protocol(self, idp_id, protocol_id, protocol):"},{"line_number":118,"context_line":"        # validate mapping exists"},{"line_number":119,"context_line":"        self.driver.get_mapping(protocol[\u0027mapping_id\u0027])"},{"line_number":120,"context_line":"        return self.driver.create_protocol(idp_id, protocol_id, protocol)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def update_protocol(self, idp_id, protocol_id, protocol):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_ad79f694","line":119,"in_reply_to":"9a89bdaa_ad0bf122","updated":"2016-09-08 18:59:24.000000000","message":"Just getting a jump on things.","commit_id":"890d7f62c01379ba5b8d6fde46da27b1fe6a4a88"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"61e2d8fd4924112a2ae7bbc1af68488a776a92ea","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def update_protocol(self, idp_id, protocol_id, protocol):"},{"line_number":123,"context_line":"        # validate mapping exists"},{"line_number":124,"context_line":"        self.driver.get_mapping(protocol[\u0027mapping_id\u0027])"},{"line_number":125,"context_line":"        return self.driver.update_protocol(idp_id, protocol_id, protocol)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_660f5a88","line":124,"updated":"2016-09-07 15:58:35.000000000","message":"Same here.","commit_id":"890d7f62c01379ba5b8d6fde46da27b1fe6a4a88"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"fe5b57cfc148a1e034563239d8a32cbdd86bff93","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        try:"},{"line_number":117,"context_line":"            self.driver.get_mapping(mapping_id)"},{"line_number":118,"context_line":"        except exception.MappingNotFound:"},{"line_number":119,"context_line":"            msg \u003d _(\u0027Invalid mapping id: %s\u0027)"},{"line_number":120,"context_line":"            raise exception.ValidationError(message\u003d(msg % mapping_id))"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa6399be_b8f45ccf","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":45},"updated":"2016-10-20 04:31:18.000000000","message":"why not do the substituion here?","commit_id":"3fb5a69703772c2dd2df7e3fc06083439f9a6cc9"}]}