)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"a71773dadcaa49f47278dd13cd4dd7c592952a7b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The main reason is that there is no way to check existence of"},{"line_number":10,"context_line":"keys if they are in the backend. The check already happens in"},{"line_number":11,"context_line":"keystone-manage doctor, symptom_keys_in_Fernet_key_repository."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5d01a823cde29db439161b6fc3f1adb8e5a6e334"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a3c09a3_1d0fd888","line":11,"updated":"2017-01-17 14:59:10.000000000","message":"Does this cause issues of some sort? I actually like the idea of the application failing to start if the required things are not available. I suggested there a while ago, but I still think it would be cool to add a backend \"verify_dependencies()\" method that a backend could override to verify its dependencies. Then at startup we could call that method when initializing the backends.","commit_id":"b95591013c9f0ece984863096730aa5e6833bbf3"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"06a4066c662ea41087725754d9f33a215027dff4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The main reason is that there is no way to check existence of"},{"line_number":10,"context_line":"keys if they are in the backend. The check already happens in"},{"line_number":11,"context_line":"keystone-manage doctor, symptom_keys_in_Fernet_key_repository."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5d01a823cde29db439161b6fc3f1adb8e5a6e334"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a629dbe_6aa551a0","line":12,"updated":"2016-11-10 15:19:17.000000000","message":"There should be a bug or blueprint for this since it\u0027s changing user-visible behavior.","commit_id":"b95591013c9f0ece984863096730aa5e6833bbf3"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"a71773dadcaa49f47278dd13cd4dd7c592952a7b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The main reason is that there is no way to check existence of"},{"line_number":10,"context_line":"keys if they are in the backend. The check already happens in"},{"line_number":11,"context_line":"keystone-manage doctor, symptom_keys_in_Fernet_key_repository."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5d01a823cde29db439161b6fc3f1adb8e5a6e334"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a3c09a3_3dd0141f","line":12,"in_reply_to":"9a629dbe_6aa551a0","updated":"2017-01-17 14:59:10.000000000","message":"++","commit_id":"b95591013c9f0ece984863096730aa5e6833bbf3"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"5ee9510900a85931cb7c0c18fd5906a6ece4ad2e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The main reason is that there is no way to check existence of"},{"line_number":10,"context_line":"keys if they are in the backend. The check already happens in"},{"line_number":11,"context_line":"keystone-manage doctor, symptom_keys_in_Fernet_key_repository."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5d01a823cde29db439161b6fc3f1adb8e5a6e334"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a629dbe_4ab96d78","line":12,"in_reply_to":"9a629dbe_6aa551a0","updated":"2016-11-10 15:25:36.000000000","message":"yes, i will attach it to fernet keys backends very soon.","commit_id":"b95591013c9f0ece984863096730aa5e6833bbf3"}],"keystone/token/providers/fernet/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fe9e32cd8a7d6a930a17b809062ee21f9f80bf6b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # or doesn\u0027t exist we should fail, hard. It doesn\u0027t make sense to start"},{"line_number":36,"context_line":"        # keystone and just 500 because we can\u0027t do anything with an empty or"},{"line_number":37,"context_line":"        # non-existant key repository."},{"line_number":38,"context_line":"        if not os.path.exists(CONF.fernet_tokens.key_repository):"},{"line_number":39,"context_line":"            subs \u003d {\u0027key_repo\u0027: CONF.fernet_tokens.key_repository}"},{"line_number":40,"context_line":"            raise SystemExit(_(\u0027%(key_repo)s does not exist\u0027) % subs)"},{"line_number":41,"context_line":"        if not os.listdir(CONF.fernet_tokens.key_repository):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_93463579","side":"PARENT","line":38,"updated":"2016-08-30 13:49:49.000000000","message":"What if we move this to keystone-manage doctor?","commit_id":"eaea57e63665b6185771f2daafe17b9cfe26d7f7"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"7d0e86507f2b5f72a078e2a91ee9a853e3619fb7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # or doesn\u0027t exist we should fail, hard. It doesn\u0027t make sense to start"},{"line_number":36,"context_line":"        # keystone and just 500 because we can\u0027t do anything with an empty or"},{"line_number":37,"context_line":"        # non-existant key repository."},{"line_number":38,"context_line":"        if not os.path.exists(CONF.fernet_tokens.key_repository):"},{"line_number":39,"context_line":"            subs \u003d {\u0027key_repo\u0027: CONF.fernet_tokens.key_repository}"},{"line_number":40,"context_line":"            raise SystemExit(_(\u0027%(key_repo)s does not exist\u0027) % subs)"},{"line_number":41,"context_line":"        if not os.listdir(CONF.fernet_tokens.key_repository):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_ac1cb36a","side":"PARENT","line":38,"in_reply_to":"fa7ab95a_0e2f5a88","updated":"2016-08-30 14:47:53.000000000","message":"Actually, symptom_keys_in_Fernet_key_repository already does that!","commit_id":"eaea57e63665b6185771f2daafe17b9cfe26d7f7"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"eae18608d6b8255a82ccc1666bcc1c3b2f8d3184","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # or doesn\u0027t exist we should fail, hard. It doesn\u0027t make sense to start"},{"line_number":36,"context_line":"        # keystone and just 500 because we can\u0027t do anything with an empty or"},{"line_number":37,"context_line":"        # non-existant key repository."},{"line_number":38,"context_line":"        if not os.path.exists(CONF.fernet_tokens.key_repository):"},{"line_number":39,"context_line":"            subs \u003d {\u0027key_repo\u0027: CONF.fernet_tokens.key_repository}"},{"line_number":40,"context_line":"            raise SystemExit(_(\u0027%(key_repo)s does not exist\u0027) % subs)"},{"line_number":41,"context_line":"        if not os.listdir(CONF.fernet_tokens.key_repository):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_0e2f5a88","side":"PARENT","line":38,"in_reply_to":"fa7ab95a_93463579","updated":"2016-08-30 13:52:00.000000000","message":"++","commit_id":"eaea57e63665b6185771f2daafe17b9cfe26d7f7"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"c74e06e8bcd609b29f54a4aa604dc72bd3d049f3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # or doesn\u0027t exist we should fail, hard. It doesn\u0027t make sense to start"},{"line_number":36,"context_line":"        # keystone and just 500 because we can\u0027t do anything with an empty or"},{"line_number":37,"context_line":"        # non-existant key repository."},{"line_number":38,"context_line":"        if not os.path.exists(CONF.fernet_tokens.key_repository):"},{"line_number":39,"context_line":"            subs \u003d {\u0027key_repo\u0027: CONF.fernet_tokens.key_repository}"},{"line_number":40,"context_line":"            raise SystemExit(_(\u0027%(key_repo)s does not exist\u0027) % subs)"},{"line_number":41,"context_line":"        if not os.listdir(CONF.fernet_tokens.key_repository):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_13014506","side":"PARENT","line":38,"in_reply_to":"fa7ab95a_93463579","updated":"2016-08-30 13:50:53.000000000","message":"nice, didn\u0027t think of that","commit_id":"eaea57e63665b6185771f2daafe17b9cfe26d7f7"}]}