)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"6a788ddf90e2c384574213e2ca950afafb09f991","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Tweak api-ref for v3 groups"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch reorders the APIs in the api-ref doc for groups. It also"},{"line_number":10,"context_line":"changes the representation of response codes. One thing not so sure is"},{"line_number":11,"context_line":"about checking group membership which says returning 204 as normal code."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I5e1e0ea1dab7dcb229bce44199f57a9a3bd45ae8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_70787a90","line":11,"range":{"start_line":10,"start_character":46,"end_line":11,"end_character":72},"updated":"2016-09-09 12:19:32.000000000","message":"this is correct, see our tests:\n\nhttps://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_v3_identity.py#L396-L401\n\nhttps://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_v3.py#L513-L517\n\nplease remove this from the commit message as it needs to be assertive on what it is doing","commit_id":"d1f9762c4aca37243924ce5222855acebe8cdebb"}],"api-ref/source/v3/groups.inc":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"6a788ddf90e2c384574213e2ca950afafb09f991","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":".. rest_method::  GET /v3/groups"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Relationship: ``http://docs.openstack.org/api/openstack-identity/3/rel/groups``"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Lists groups."},{"line_number":32,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"9a89bdaa_6f033d0e","line":29,"range":{"start_line":29,"start_character":16,"end_line":29,"end_character":77},"updated":"2016-09-09 12:19:32.000000000","message":"this gives a 404","commit_id":"d1f9762c4aca37243924ce5222855acebe8cdebb"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"6a788ddf90e2c384574213e2ca950afafb09f991","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Relationship: ``http://docs.openstack.org/api/openstack-identity/3/rel/groups``"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Lists groups."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Response Codes"},{"line_number":34,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"9a89bdaa_0f3471dc","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":13},"updated":"2016-09-09 12:19:32.000000000","message":"not sure this buys anything, the section title (List groups) alreaady appears in the rendered docs. samne for others below where the title is clear\n\nhowever as this is just following the pattern here, I am okay with this as it is","commit_id":"d1f9762c4aca37243924ce5222855acebe8cdebb"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"6a788ddf90e2c384574213e2ca950afafb09f991","unresolved":false,"context_lines":[{"line_number":299,"context_line":""},{"line_number":300,"context_line":".. rest_method::  GET /v3/groups/{group_id}/users"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"Relationship: ``http://docs.openstack.org/api/openstack-identity/3/rel/group_users``"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"Lists the users that belong to a group."},{"line_number":305,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"9a89bdaa_6f789d90","line":302,"range":{"start_line":302,"start_character":16,"end_line":302,"end_character":82},"updated":"2016-09-09 12:19:32.000000000","message":"this also gives 404","commit_id":"d1f9762c4aca37243924ce5222855acebe8cdebb"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"3a9e84c071d7d9e51f1bd9e1c3decfff45d0244d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"acquiring or loading users and groups from external sources before"},{"line_number":21,"context_line":"mapping them to projects and domains."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Show group details"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5a8bc5a2_bd14cd9f","line":23,"updated":"2016-09-27 14:13:53.000000000","message":"the change seems unrelated. Is it really needed?","commit_id":"eaa475662f75fd431cd87e02e2e809b645b10b51"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"eccef037eac71eda0d4cf74f4b75c8a9fafb749b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"acquiring or loading users and groups from external sources before"},{"line_number":21,"context_line":"mapping them to projects and domains."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Show group details"},{"line_number":25,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"3a98d1f4_8e92279e","line":23,"in_reply_to":"5a8bc5a2_bd14cd9f","updated":"2016-09-29 13:16:07.000000000","message":"not really needed, but I noticed that most of the time we leave two empty lines between the docs about two APIs, so I think maybe adding an extra empty line here is appropriate.","commit_id":"eaa475662f75fd431cd87e02e2e809b645b10b51"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"3a9e84c071d7d9e51f1bd9e1c3decfff45d0244d","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":".. literalinclude:: ./samples/admin/groups-list-response.json"},{"line_number":408,"context_line":"   :language: javascript"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5a8bc5a2_dd099996","line":411,"range":{"start_line":409,"start_character":0,"end_line":411,"end_character":0},"updated":"2016-09-27 14:13:53.000000000","message":"why was it added?","commit_id":"eaa475662f75fd431cd87e02e2e809b645b10b51"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"eccef037eac71eda0d4cf74f4b75c8a9fafb749b","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":".. literalinclude:: ./samples/admin/groups-list-response.json"},{"line_number":408,"context_line":"   :language: javascript"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":3,"id":"3a98d1f4_0ed45745","line":411,"range":{"start_line":409,"start_character":0,"end_line":411,"end_character":0},"in_reply_to":"5a8bc5a2_dd099996","updated":"2016-09-29 13:16:07.000000000","message":"will kill these.","commit_id":"eaa475662f75fd431cd87e02e2e809b645b10b51"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0e78ef319c36c19d2f3358436b6d945a9aee493b","unresolved":false,"context_lines":[{"line_number":187,"context_line":"   - 401"},{"line_number":188,"context_line":"   - 403"},{"line_number":189,"context_line":"   - 404"},{"line_number":190,"context_line":"   - 409"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Request Parameters"},{"line_number":193,"context_line":"------------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5a8bc5a2_5bcf1fb3","line":190,"range":{"start_line":190,"start_character":5,"end_line":190,"end_character":8},"updated":"2016-09-28 10:15:54.000000000","message":"pls remove this status code, it will do nothing if the entry already exist. I cannot see anywhere 409 is returned.\nhttps://github.com/openstack/keystone/blob/master/keystone/identity/backends/sql.py#L213-L215","commit_id":"bdbb4db1472745f958ea4d9ac7beaa3e0b2a6c6e"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"ef5450fe5cc760bed210ecb1930fe2027922fd3c","unresolved":false,"context_lines":[{"line_number":187,"context_line":"   - 401"},{"line_number":188,"context_line":"   - 403"},{"line_number":189,"context_line":"   - 404"},{"line_number":190,"context_line":"   - 409"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Request Parameters"},{"line_number":193,"context_line":"------------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3a98d1f4_c209a6df","line":190,"range":{"start_line":190,"start_character":5,"end_line":190,"end_character":8},"in_reply_to":"5a8bc5a2_5bcf1fb3","updated":"2016-09-28 13:03:42.000000000","message":"Done","commit_id":"bdbb4db1472745f958ea4d9ac7beaa3e0b2a6c6e"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0e78ef319c36c19d2f3358436b6d945a9aee493b","unresolved":false,"context_lines":[{"line_number":220,"context_line":"   - 401"},{"line_number":221,"context_line":"   - 403"},{"line_number":222,"context_line":"   - 404"},{"line_number":223,"context_line":"   - 409"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Request Parameters"},{"line_number":226,"context_line":"------------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5a8bc5a2_9025065e","line":223,"range":{"start_line":223,"start_character":3,"end_line":223,"end_character":8},"updated":"2016-09-28 10:15:54.000000000","message":"pls remove this, conflicts decorator is not added there.\n\nhttps://github.com/openstack/keystone/blob/master/keystone/identity/backends/sql.py#L233","commit_id":"bdbb4db1472745f958ea4d9ac7beaa3e0b2a6c6e"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"ef5450fe5cc760bed210ecb1930fe2027922fd3c","unresolved":false,"context_lines":[{"line_number":220,"context_line":"   - 401"},{"line_number":221,"context_line":"   - 403"},{"line_number":222,"context_line":"   - 404"},{"line_number":223,"context_line":"   - 409"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"Request Parameters"},{"line_number":226,"context_line":"------------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"3a98d1f4_e20ea2e4","line":223,"range":{"start_line":223,"start_character":3,"end_line":223,"end_character":8},"in_reply_to":"5a8bc5a2_9025065e","updated":"2016-09-28 13:03:42.000000000","message":"Done","commit_id":"bdbb4db1472745f958ea4d9ac7beaa3e0b2a6c6e"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"2289dec92d8571e48ad75d508ceba83be0f9cafb","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   - 400"},{"line_number":42,"context_line":"   - 401"},{"line_number":43,"context_line":"   - 403"},{"line_number":44,"context_line":"   - 404"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Request Parameters"},{"line_number":47,"context_line":"------------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3a98d1f4_50cb9c72","line":44,"updated":"2016-09-28 13:35:37.000000000","message":"Several error response codes were removed -- 405, 503, etc.\n\nThe commit message didn\u0027t say anything about the intent of this change being to change the documented response codes.","commit_id":"4bc039e463cfea6a59ad3a8c648dbf1cb7a7b124"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"6019e5ddd112a39278a7f7286e444e6d0b4d149e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   - 400"},{"line_number":42,"context_line":"   - 401"},{"line_number":43,"context_line":"   - 403"},{"line_number":44,"context_line":"   - 404"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Request Parameters"},{"line_number":47,"context_line":"------------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3a98d1f4_1e7d62e7","line":44,"in_reply_to":"3a98d1f4_4eebbfb0","updated":"2016-09-29 14:02:45.000000000","message":"Update the commit message so that reviewers know that the change was intentional.\n\nMy preference is that the error response code cleanup should be in a different commit so that it\u0027s easier to review.","commit_id":"4bc039e463cfea6a59ad3a8c648dbf1cb7a7b124"},{"author":{"_account_id":8246,"name":"Qiming Teng","email":"tengqm@outlook.com","username":"tengqm"},"change_message_id":"118f2b89d91fcc5f1a7ac510f6844921ba9bdaa0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   - 400"},{"line_number":42,"context_line":"   - 401"},{"line_number":43,"context_line":"   - 403"},{"line_number":44,"context_line":"   - 404"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"Request Parameters"},{"line_number":47,"context_line":"------------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"3a98d1f4_4eebbfb0","line":44,"in_reply_to":"3a98d1f4_50cb9c72","updated":"2016-09-29 13:20:13.000000000","message":"in previous reviews (about projects?), I had left all the status codes untouched so that this series of changes will only about status code formatting and API reordering. There had been some comments that the 405, 503 etc status code were never returned from keystone, so we\u0027d better remove them. No one knows where those error codes come from. Maybe from the initial rst file converted from WADL.","commit_id":"4bc039e463cfea6a59ad3a8c648dbf1cb7a7b124"}]}