)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"258801634967cd77b95c423d19992cfa572e9d29","unresolved":false,"context_lines":[{"line_number":14,"context_line":"is useless and will no longer be active since the id of user"},{"line_number":15,"context_line":"is a random number and only assigned when it created."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"It\u0027s also expose a potential security risk if the id of user or"},{"line_number":18,"context_line":"project that is created happens to match with the trust\u0027s."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This patch add the Fks to trust table so that it\u0027s got cleaned"},{"line_number":21,"context_line":"when user or project is deleted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a89bdaa_6835c0d9","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":58},"updated":"2016-09-11 17:16:52.000000000","message":"not really. uuid4 is very unique and we always assume that they are unique enough to not care about such things.","commit_id":"9f2b6ad841ed5cce2912d77c5507610654c244dd"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"48a53046bbfb0de4fd77dcd08008084a5d8b56cf","unresolved":false,"context_lines":[{"line_number":10,"context_line":"trust could be deleted when the project is deleted."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icd8793c886dcc20b6f61b83e957d4a9711a4d46f"},{"line_number":13,"context_line":"Closes-Bug: #1622310"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a98d1f4_67348749","line":13,"updated":"2016-10-03 16:53:04.000000000","message":"I would consider changing this to a partial bug, only because this patch is addressing project/trust foreign keys. The bug reports the same behavior when a user (trustee or trustor) is deleted.","commit_id":"16b4ba592afcafa0a9fd3c2290f2a19c515939dd"}],"keystone/tests/unit/test_sql_banned_operations.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"ecc285d62f6c7b5c2b7760333f6f1e43889b4579","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        # reference with a project that has been removed, where the constraint"},{"line_number":248,"context_line":"        # cannot be enforced with."},{"line_number":249,"context_line":"        # Those removed entry will never be valid any longer, there should no"},{"line_number":250,"context_line":"        # access to those data, and likely won\u0027t break rolling upgrade process."},{"line_number":251,"context_line":"        10"},{"line_number":252,"context_line":"    ]"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_299566dd","line":250,"range":{"start_line":250,"start_character":10,"end_line":250,"end_character":30},"updated":"2016-10-10 11:48:01.000000000","message":"maybe read them, but not really consume the trust IMO.","commit_id":"16b4ba592afcafa0a9fd3c2290f2a19c515939dd"}],"keystone/trust/backends/sql.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"311b12072fc22f2d679bcf660e20e9bd1daf5a4f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    trustee_user_id \u003d sql.Column(sql.String(64), nullable\u003dFalse)"},{"line_number":41,"context_line":"    project_id \u003d sql.Column("},{"line_number":42,"context_line":"        sql.String(64),"},{"line_number":43,"context_line":"        sql.ForeignKey(\u0027project.id\u0027, ondelete\u003d\"CASCADE\"))"},{"line_number":44,"context_line":"    impersonation \u003d sql.Column(sql.Boolean, nullable\u003dFalse)"},{"line_number":45,"context_line":"    deleted_at \u003d sql.Column(sql.DateTime)"},{"line_number":46,"context_line":"    expires_at \u003d sql.Column(sql.DateTime)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a98d1f4_87b273e3","line":43,"updated":"2016-10-03 16:51:44.000000000","message":"nit: use single quotes only to keep consistency with other keyword arguments in this module.","commit_id":"16b4ba592afcafa0a9fd3c2290f2a19c515939dd"}]}