)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"26e6e2469526df55b3f2d960849d6dc1e00f7f5d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                removed configuration of regions which were added"},{"line_number":34,"context_line":"                only in Newton"},{"line_number":35,"context_line":"\tkeystone/tests/unit/test_v3_assignment.py:"},{"line_number":36,"context_line":"                conflict due to freezer being used in Newton and"},{"line_number":37,"context_line":"                not used in Mitaka"},{"line_number":38,"context_line":"\tkeystone/token/provider.py:"},{"line_number":39,"context_line":"                there is no per-region cache in token providers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a8ec9b2_107d6a1c","line":36,"range":{"start_line":36,"start_character":32,"end_line":36,"end_character":39},"updated":"2016-09-14 12:41:43.000000000","message":"freezegun*","commit_id":"296f3a9cebd83a4b71ddb88de648b4b35b1c0965"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"e778a99f8b825552ceb73d66b71b915f82f154f3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                removed configuration of regions which were added"},{"line_number":34,"context_line":"                only in Newton"},{"line_number":35,"context_line":"\tkeystone/tests/unit/test_v3_assignment.py:"},{"line_number":36,"context_line":"                conflict due to freezer being used in Newton and"},{"line_number":37,"context_line":"                not used in Mitaka"},{"line_number":38,"context_line":"\tkeystone/token/provider.py:"},{"line_number":39,"context_line":"                there is no per-region cache in token providers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a8ec9b2_d1304b04","line":36,"in_reply_to":"7a8ec9b2_107d6a1c","updated":"2016-09-14 19:04:48.000000000","message":"++","commit_id":"296f3a9cebd83a4b71ddb88de648b4b35b1c0965"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"93073841960d968f50e024bd15b820ae8fbb95e0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"the region key changes the cache keys in that region are"},{"line_number":17,"context_line":"effectively invalidated."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Conflicts:"},{"line_number":20,"context_line":"\tkeystone/assignment/core.py: imports were fixed"},{"line_number":21,"context_line":"\tkeystone/catalog/core.py: imports were fixed"},{"line_number":22,"context_line":"\tkeystone/common/cache/core.py:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a8ec9b2_2d14ab42","line":19,"updated":"2016-09-14 21:18:24.000000000","message":"Do we actually need this in here?","commit_id":"f1d9c54ef07c61cb80def5779802cc4daf45f4cb"}],"keystone/common/cache/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2a0a20cf2d728d734c34e4144dc6f184dca3b589","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        return key \u003d\u003d self._region_key"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class DistributedInvalidationStrategy(object):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def __init__(self, region_manager):"},{"line_number":59,"context_line":"        self._region_manager \u003d region_manager"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_31c08fe0","line":56,"updated":"2016-09-14 19:04:33.000000000","message":"How come this doesn\u0027t inherit from dogpile.cache.region.RegionInvalidationStrategy like it does in the original patch?","commit_id":"296f3a9cebd83a4b71ddb88de648b4b35b1c0965"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"a013473fa3961cdf79a31e22992409fe8c02282d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        return key \u003d\u003d self._region_key"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class DistributedInvalidationStrategy(object):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def __init__(self, region_manager):"},{"line_number":59,"context_line":"        self._region_manager \u003d region_manager"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a8ec9b2_6286c314","line":56,"in_reply_to":"7a8ec9b2_31c08fe0","updated":"2016-09-14 19:53:25.000000000","message":"dogpile.cache.region.RegionInvalidationStrategy appeared only in 0.6.2. We have a cap on 0.5.7.\n\nA call to region.invalidate in 0.6.2 is just a wrapper to  RegionInvalidationStrategy.invalidate. In 0.5.7 region.invalidate does other thing, that\u0027s why i replace it on line 157.\n\nBut even in the original patch we don\u0027t use RegionInvalidationStrategy\u0027s features at all, as you can see by methods other than invalidate. Theoretically dogpile.cache checks if the region was invalidated by calling is_invalidated. But our invalidation manager doesn\u0027t mark the region as invalidated, we kinda re-make the region from scratch on invalidation.","commit_id":"296f3a9cebd83a4b71ddb88de648b4b35b1c0965"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"93073841960d968f50e024bd15b820ae8fbb95e0","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            region_manager, region.key_mangler)"},{"line_number":132,"context_line":"        strategy \u003d DistributedInvalidationStrategy(region_manager)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        def invalidate_by_strategy(*args, **kwargs):"},{"line_number":135,"context_line":"            return strategy.invalidate()"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        region.invalidate \u003d invalidate_by_strategy"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_ad743b9c","line":134,"updated":"2016-09-14 21:18:24.000000000","message":"Very nice.","commit_id":"f1d9c54ef07c61cb80def5779802cc4daf45f4cb"}]}