)]}'
{"keystone/middleware/auth.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"67763a8b1b97acb52056a6cc2cb7f630b13091a1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"try:"},{"line_number":14,"context_line":"    from keystonemiddleware.auth_token import BaseAuthProtocol"},{"line_number":15,"context_line":"except ImportError:"},{"line_number":16,"context_line":"    from keystonemiddleware.auth_token import _BaseAuthProtocol \\"},{"line_number":17,"context_line":"        as BaseAuthProtocol"},{"line_number":18,"context_line":"from keystonemiddleware.auth_token import InvalidToken"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log"},{"line_number":21,"context_line":"from oslo_log import versionutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_e91d8267","line":18,"range":{"start_line":14,"start_character":0,"end_line":18,"end_character":54},"updated":"2016-09-14 10:38:30.000000000","message":"we don\u0027t import individual names from modules. I suggest to do something like this:\n\n from keystonemiddleware import auth_token\n try:\n     BaseAuthProtocol \u003d auth_token.BaseAuthProtocol\n except AttributeError:\n     BaseAuthProtocol \u003d auth_token._BaseAuthProtocol","commit_id":"cbf65025f8dea221472d71a094aa4bec9c89907d"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"67ce88fea34b2a9ed3f43fda87bdb1f6be50e74e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"try:"},{"line_number":14,"context_line":"    from keystonemiddleware.auth_token import BaseAuthProtocol"},{"line_number":15,"context_line":"except ImportError:"},{"line_number":16,"context_line":"    from keystonemiddleware.auth_token import _BaseAuthProtocol \\"},{"line_number":17,"context_line":"        as BaseAuthProtocol"},{"line_number":18,"context_line":"from keystonemiddleware.auth_token import InvalidToken"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log"},{"line_number":21,"context_line":"from oslo_log import versionutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_e96ca29e","line":18,"range":{"start_line":14,"start_character":0,"end_line":18,"end_character":54},"in_reply_to":"7a8ec9b2_e91d8267","updated":"2016-09-14 10:42:30.000000000","message":"Done","commit_id":"cbf65025f8dea221472d71a094aa4bec9c89907d"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c78387e1e8bc44c92fb8fce559ec8c84509ff683","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from keystonemiddleware import auth_token"},{"line_number":14,"context_line":"try:"},{"line_number":15,"context_line":"    BaseAuthProtocol \u003d auth_token.BaseAuthProtocol"},{"line_number":16,"context_line":"except AttributeError:"},{"line_number":17,"context_line":"    BaseAuthProtocol \u003d auth_token._BaseAuthProtocol"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log"},{"line_number":20,"context_line":"from oslo_log import versionutils"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_f8c8ea76","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":51},"updated":"2016-09-14 12:05:36.000000000","message":"add a note here that indicates we can remove this once global requirements opens up in Ocata, and keystonemiddleware is at a minimum of 4.2.0","commit_id":"00d7d18743b59f35c2ca763843ae5e660d5170df"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"2b2f20ad679a2583b14b40d5e6dd7baf17a638b9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from keystonemiddleware import auth_token"},{"line_number":14,"context_line":"try:"},{"line_number":15,"context_line":"    BaseAuthProtocol \u003d auth_token.BaseAuthProtocol"},{"line_number":16,"context_line":"except AttributeError:"},{"line_number":17,"context_line":"    BaseAuthProtocol \u003d auth_token._BaseAuthProtocol"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log"},{"line_number":20,"context_line":"from oslo_log import versionutils"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_785a1a85","line":17,"range":{"start_line":14,"start_character":0,"end_line":17,"end_character":51},"updated":"2016-09-14 12:09:39.000000000","message":"sorry for not saying it in the previous comment, but i think there should be a comment describing why we do this and that should be removed in Ocata when newer keystonemiddleware becomes available","commit_id":"00d7d18743b59f35c2ca763843ae5e660d5170df"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"8f64ad8f9a609e8894c5ef750c8d1ed789ff4d9a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from keystonemiddleware import auth_token"},{"line_number":14,"context_line":"try:"},{"line_number":15,"context_line":"    BaseAuthProtocol \u003d auth_token.BaseAuthProtocol"},{"line_number":16,"context_line":"except AttributeError:"},{"line_number":17,"context_line":"    BaseAuthProtocol \u003d auth_token._BaseAuthProtocol"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_log import log"},{"line_number":20,"context_line":"from oslo_log import versionutils"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a8ec9b2_58363e04","line":17,"range":{"start_line":14,"start_character":0,"end_line":17,"end_character":51},"in_reply_to":"7a8ec9b2_785a1a85","updated":"2016-09-14 12:11:37.000000000","message":"Oh, right, Steve says about 4.2.0 above.","commit_id":"00d7d18743b59f35c2ca763843ae5e660d5170df"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"6472da2d9d1d8f53df05cc7e24160de9a86c4e4d","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# TODO: Remove this check once global-requirements depends on a version of"},{"line_number":16,"context_line":"# keystonemiddleware greater than 4.2.0. We caught this issue too late in the"},{"line_number":17,"context_line":"# Newton development cycle to unfreeze gloabl requirements."},{"line_number":18,"context_line":"try:"},{"line_number":19,"context_line":"    BaseAuthProtocol \u003d auth_token.BaseAuthProtocol"},{"line_number":20,"context_line":"except AttributeError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_8eeddc8d","line":17,"range":{"start_line":17,"start_character":39,"end_line":17,"end_character":45},"updated":"2016-09-14 12:31:19.000000000","message":"global","commit_id":"fd78de549e37e53ff399ba9a3d1f811a2254f345"}]}