)]}'
{"keystone/revoke/core.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7132663e94357edf4ee41760889deae78228efe6","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _project_callback(self, service, resource_type, operation,"},{"line_number":95,"context_line":"                          payload):"},{"line_number":96,"context_line":"        if operation !\u003d \"disabled\":"},{"line_number":97,"context_line":"            self.revoke("},{"line_number":98,"context_line":"                revoke_model.RevokeEvent(project_id\u003dpayload[\u0027resource_info\u0027]))"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_6b730981","line":96,"range":{"start_line":96,"start_character":24,"end_line":96,"end_character":25},"updated":"2016-09-14 17:51:56.000000000","message":"nit: single quotes seem to be the default in this file","commit_id":"f9cbfa74f030ca006bcfd9a1e8e6ec1a86e6cd14"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"c864082206ffc10f4fd1fddd3ec1b34764471e82","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _project_callback(self, service, resource_type, operation,"},{"line_number":95,"context_line":"                          payload):"},{"line_number":96,"context_line":"        if operation !\u003d \"disabled\":"},{"line_number":97,"context_line":"            self.revoke("},{"line_number":98,"context_line":"                revoke_model.RevokeEvent(project_id\u003dpayload[\u0027resource_info\u0027]))"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_38ab0bd8","line":96,"range":{"start_line":96,"start_character":24,"end_line":96,"end_character":25},"in_reply_to":"7a8ec9b2_6b730981","updated":"2016-09-14 21:53:50.000000000","message":"Done","commit_id":"f9cbfa74f030ca006bcfd9a1e8e6ec1a86e6cd14"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7132663e94357edf4ee41760889deae78228efe6","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _domain_callback(self, service, resource_type, operation,"},{"line_number":101,"context_line":"                         payload):"},{"line_number":102,"context_line":"        if operation !\u003d \"disabled\":"},{"line_number":103,"context_line":"            self.revoke("},{"line_number":104,"context_line":"                revoke_model.RevokeEvent(domain_id\u003dpayload[\u0027resource_info\u0027]))"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_8b6e9594","line":102,"range":{"start_line":102,"start_character":24,"end_line":102,"end_character":25},"updated":"2016-09-14 17:51:56.000000000","message":"same as above","commit_id":"f9cbfa74f030ca006bcfd9a1e8e6ec1a86e6cd14"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"c864082206ffc10f4fd1fddd3ec1b34764471e82","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _domain_callback(self, service, resource_type, operation,"},{"line_number":101,"context_line":"                         payload):"},{"line_number":102,"context_line":"        if operation !\u003d \"disabled\":"},{"line_number":103,"context_line":"            self.revoke("},{"line_number":104,"context_line":"                revoke_model.RevokeEvent(domain_id\u003dpayload[\u0027resource_info\u0027]))"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_78b5932f","line":102,"range":{"start_line":102,"start_character":24,"end_line":102,"end_character":25},"in_reply_to":"7a8ec9b2_8b6e9594","updated":"2016-09-14 21:53:50.000000000","message":"Done","commit_id":"f9cbfa74f030ca006bcfd9a1e8e6ec1a86e6cd14"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"075709cce2a12fa18266a994a3f55a8a1afa139f","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _project_callback(self, service, resource_type, operation,"},{"line_number":95,"context_line":"                          payload):"},{"line_number":96,"context_line":"        if operation !\u003d \u0027disabled\u0027:"},{"line_number":97,"context_line":"            self.revoke("},{"line_number":98,"context_line":"                revoke_model.RevokeEvent(project_id\u003dpayload[\u0027resource_info\u0027]))"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_8603c30c","line":96,"updated":"2016-09-15 11:56:07.000000000","message":"I\u0027d suggest to add a comment explaining why you do not create revoke events for the \"disabled\" operation","commit_id":"fe96a10ff675f896cd735510e4edec31e350b2f0"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"075709cce2a12fa18266a994a3f55a8a1afa139f","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def _domain_callback(self, service, resource_type, operation,"},{"line_number":101,"context_line":"                         payload):"},{"line_number":102,"context_line":"        if operation !\u003d \u0027disabled\u0027:"},{"line_number":103,"context_line":"            self.revoke("},{"line_number":104,"context_line":"                revoke_model.RevokeEvent(domain_id\u003dpayload[\u0027resource_info\u0027]))"},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_0610934d","line":102,"updated":"2016-09-15 11:56:07.000000000","message":"same as above","commit_id":"fe96a10ff675f896cd735510e4edec31e350b2f0"}],"keystone/tests/unit/test_token_provider.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7132663e94357edf4ee41760889deae78228efe6","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        self.load_backends()"},{"line_number":760,"context_line":"        self._load_test_data()"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    # FIX_ME(jorge_munoz) Retrieve data from SAMPLE tokens"},{"line_number":763,"context_line":"    def _load_test_data(self):"},{"line_number":764,"context_line":"        # Create domains of SAMPLE tokens"},{"line_number":765,"context_line":"        domain \u003d unit.new_domain_ref(id\u003d\u0027default\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_1de1ecd0","line":762,"range":{"start_line":762,"start_character":4,"end_line":762,"end_character":58},"updated":"2016-09-14 17:51:56.000000000","message":"why not doing that already? Is this still a WIP?","commit_id":"f9cbfa74f030ca006bcfd9a1e8e6ec1a86e6cd14"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"c864082206ffc10f4fd1fddd3ec1b34764471e82","unresolved":false,"context_lines":[{"line_number":759,"context_line":"        self.load_backends()"},{"line_number":760,"context_line":"        self._load_test_data()"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"    # FIX_ME(jorge_munoz) Retrieve data from SAMPLE tokens"},{"line_number":763,"context_line":"    def _load_test_data(self):"},{"line_number":764,"context_line":"        # Create domains of SAMPLE tokens"},{"line_number":765,"context_line":"        domain \u003d unit.new_domain_ref(id\u003d\u0027default\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_b8855b5a","line":762,"range":{"start_line":762,"start_character":4,"end_line":762,"end_character":58},"in_reply_to":"7a8ec9b2_1de1ecd0","updated":"2016-09-14 21:53:50.000000000","message":"Done","commit_id":"f9cbfa74f030ca006bcfd9a1e8e6ec1a86e6cd14"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"075709cce2a12fa18266a994a3f55a8a1afa139f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7a8ec9b2_c645cb17","updated":"2016-09-15 11:56:07.000000000","message":"where are the tests that you have added on patchset 1?","commit_id":"fe96a10ff675f896cd735510e4edec31e350b2f0"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"2c2441c1a13f46df6d1a10a17773ff70ae61d848","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7a8ec9b2_e54c7372","in_reply_to":"7a8ec9b2_c645cb17","updated":"2016-09-15 14:37:48.000000000","message":"Hmm, that\u0027s weird. The previous changes aren\u0027t showing up anymore as changes, although they are still there. _load_test_data and SAMPLE_TOKEN were the things added/changes. They are still there from patchset 1","commit_id":"fe96a10ff675f896cd735510e4edec31e350b2f0"}],"keystone/tests/unit/test_v3_auth.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7132663e94357edf4ee41760889deae78228efe6","unresolved":false,"context_lines":[{"line_number":3475,"context_line":"        self.assertValidDeletedProjectResponse(events_response,"},{"line_number":3476,"context_line":"                                               self.projectA[\u0027id\u0027])"},{"line_number":3477,"context_line":""},{"line_number":3478,"context_line":"    def test_disable_domain_shows_in_event_list(self):"},{"line_number":3479,"context_line":"        events \u003d self.get(\u0027/OS-REVOKE/events\u0027).json_body[\u0027events\u0027]"},{"line_number":3480,"context_line":"        self.assertEqual([], events)"},{"line_number":3481,"context_line":"        disable_body \u003d {\u0027domain\u0027: {\u0027enabled\u0027: False}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_ddd784eb","side":"PARENT","line":3478,"range":{"start_line":3478,"start_character":8,"end_line":3478,"end_character":47},"updated":"2016-09-14 17:51:56.000000000","message":"think you could keep the test but in the other way around: test_disable_domain_does_not_show_in_event_list (and a similar one for projects)","commit_id":"8a8f070bc0714d5bd2c3594dcd8b458ac688be61"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"c864082206ffc10f4fd1fddd3ec1b34764471e82","unresolved":false,"context_lines":[{"line_number":3475,"context_line":"        self.assertValidDeletedProjectResponse(events_response,"},{"line_number":3476,"context_line":"                                               self.projectA[\u0027id\u0027])"},{"line_number":3477,"context_line":""},{"line_number":3478,"context_line":"    def test_disable_domain_shows_in_event_list(self):"},{"line_number":3479,"context_line":"        events \u003d self.get(\u0027/OS-REVOKE/events\u0027).json_body[\u0027events\u0027]"},{"line_number":3480,"context_line":"        self.assertEqual([], events)"},{"line_number":3481,"context_line":"        disable_body \u003d {\u0027domain\u0027: {\u0027enabled\u0027: False}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_38d94b84","side":"PARENT","line":3478,"range":{"start_line":3478,"start_character":8,"end_line":3478,"end_character":47},"in_reply_to":"7a8ec9b2_ddd784eb","updated":"2016-09-14 21:53:50.000000000","message":"Done","commit_id":"8a8f070bc0714d5bd2c3594dcd8b458ac688be61"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"075709cce2a12fa18266a994a3f55a8a1afa139f","unresolved":false,"context_lines":[{"line_number":3458,"context_line":"        self.assertValidDeletedProjectResponse(events_response,"},{"line_number":3459,"context_line":"                                               self.projectA[\u0027id\u0027])"},{"line_number":3460,"context_line":""},{"line_number":3461,"context_line":"    def test_disable_domain_does_not_shows_in_event_list(self):"},{"line_number":3462,"context_line":"        events \u003d self.get(\u0027/OS-REVOKE/events\u0027).json_body[\u0027events\u0027]"},{"line_number":3463,"context_line":"        self.assertEqual([], events)"},{"line_number":3464,"context_line":"        disable_body \u003d {\u0027domain\u0027: {\u0027enabled\u0027: False}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_e6c5678e","line":3461,"range":{"start_line":3461,"start_character":8,"end_line":3461,"end_character":56},"updated":"2016-09-15 11:56:07.000000000","message":"add a similar test for project","commit_id":"fe96a10ff675f896cd735510e4edec31e350b2f0"}]}