)]}'
{"keystone/identity/controllers.py":[{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"68fc4c88a3949e6fdfc446f7424dfc8d75d55e24","unresolved":false,"context_lines":[{"line_number":881,"context_line":"                          \u0027role\u0027: ref.get(\u0027role_id\u0027)})"},{"line_number":882,"context_line":"            return members"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"        def _build_equivalent_user_assignment(user, group_id, template):"},{"line_number":885,"context_line":"            \"\"\"Create a user assignment equivalent to the group one."},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"            The template has had the \u0027group\u0027 entity removed, so"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FnKM%3D","line":884,"updated":"2013-07-15 20:54:48.000000000","message":"Given how you changed the code below is this comment still valid?   Shouldn\u0027t it say something like:  \nThe assignment link returned for roles that are included by virtue of group membership should refer to the group assignment that led to this role","commit_id":"099f9dc0a5ac884b462a1292896e4b39ce740841"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"71737f37b71bd69a0fc833e2b99423c5c0749a17","unresolved":false,"context_lines":[{"line_number":881,"context_line":"                          \u0027role\u0027: ref.get(\u0027role_id\u0027)})"},{"line_number":882,"context_line":"            return members"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"        def _build_equivalent_user_assignment(user, group_id, template):"},{"line_number":885,"context_line":"            \"\"\"Create a user assignment equivalent to the group one."},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"            The template has had the \u0027group\u0027 entity removed, so"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FlI0%3D","line":884,"in_reply_to":"AAAAP3%2F%2FnIE%3D","updated":"2013-07-16 10:08:14.000000000","message":"Actually, that was a great comment to make.  As I went back to change the comment, I realised that the implication was that I could simplify the code further.  Thanks.","commit_id":"099f9dc0a5ac884b462a1292896e4b39ce740841"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"2930b475facc88006b8f1c2e6435537acef18593","unresolved":false,"context_lines":[{"line_number":881,"context_line":"                          \u0027role\u0027: ref.get(\u0027role_id\u0027)})"},{"line_number":882,"context_line":"            return members"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"        def _build_equivalent_user_assignment(user, group_id, template):"},{"line_number":885,"context_line":"            \"\"\"Create a user assignment equivalent to the group one."},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"            The template has had the \u0027group\u0027 entity removed, so"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FnIE%3D","line":884,"in_reply_to":"AAAAP3%2F%2FnKM%3D","updated":"2013-07-15 21:02:21.000000000","message":"Well maybe its 75% right :-)  We are still creating a user entry....it\u0027s just that the assignment link points back to the group grant....I\u0027ll amend as you suggest.  Good catch.","commit_id":"099f9dc0a5ac884b462a1292896e4b39ce740841"}],"tests/test_v3_identity.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"8625c01ffa093ae63a4c905ec86cc7cf0ada9ca3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import test_v3"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def _build_role_assignment_url_and_entity("},{"line_number":26,"context_line":"        role_id, user_id\u003dNone, group_id\u003dNone, domain_id\u003dNone,"},{"line_number":27,"context_line":"        project_id\u003dNone, inherited_to_projects\u003dFalse,"},{"line_number":28,"context_line":"        effective\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F%2Fwg%3D","line":25,"updated":"2013-07-17 19:53:29.000000000","message":"this looks like it should be refactored into two functions... one that produces the entity, and one that uses the entity to produce an url","commit_id":"2af9ce342788fdd3e407141a233c5393b061ffb0"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"8625c01ffa093ae63a4c905ec86cc7cf0ada9ca3","unresolved":false,"context_lines":[{"line_number":827,"context_line":"        self.assertValidRoleAssignmentListResponse(r)"},{"line_number":828,"context_line":"        self.assertEqual(len(r.result.get(\u0027role_assignments\u0027)),"},{"line_number":829,"context_line":"                         existing_assignments + 2)"},{"line_number":830,"context_line":"        unused, ud_entity \u003d _build_role_assignment_url_and_entity("},{"line_number":831,"context_line":"            domain_id\u003dself.domain_id, user_id\u003dself.user1[\u0027id\u0027],"},{"line_number":832,"context_line":"            role_id\u003dself.role_id)"},{"line_number":833,"context_line":"        gd_url, unused \u003d _build_role_assignment_url_and_entity("}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2F%2Fww%3D","line":830,"updated":"2013-07-17 19:53:29.000000000","message":"i guess flake8 doesn\u0027t run against tests/ ?","commit_id":"2af9ce342788fdd3e407141a233c5393b061ffb0"}]}