)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"48b095b8ad3540cecb1a20d3339bdfc3cde0c903","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dolph Mathews \u003cdolph.mathews@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-15 20:06:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Let the upgrades.Repository manage its own DB engine"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib61de96e1124a45b6a91d98397a291fc79bdaaf2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a8ec9b2_6f53b239","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"updated":"2016-09-16 11:03:35.000000000","message":"Could you please describe why it\u0027s needed?","commit_id":"b616f9008218444ae6f44b80861c2120b2349d22"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8c82b0348fa78459e39fde80cc48756e966789d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dolph Mathews \u003cdolph.mathews@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-15 20:06:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Let the upgrades.Repository manage its own DB engine"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib61de96e1124a45b6a91d98397a291fc79bdaaf2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a8ec9b2_8d3d4a91","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"in_reply_to":"7a8ec9b2_6f53b239","updated":"2016-09-16 20:11:18.000000000","message":"I agree. Why are does each repository need a separate instance of an engine?","commit_id":"b616f9008218444ae6f44b80861c2120b2349d22"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a6ed9fa11d36146a7ffd56eebc6f0e16d0ec3b02","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dolph Mathews \u003cdolph.mathews@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-15 20:06:52 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Let the upgrades.Repository manage its own DB engine"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib61de96e1124a45b6a91d98397a291fc79bdaaf2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a98d1f4_2cf1866b","line":7,"in_reply_to":"7a8ec9b2_8d3d4a91","updated":"2016-10-03 16:41:42.000000000","message":"++ I feel like this is related to the bug we were seeing with migrations being run out of order in the tests?","commit_id":"b616f9008218444ae6f44b80861c2120b2349d22"}],"keystone/common/sql/upgrades.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"8c82b0348fa78459e39fde80cc48756e966789d6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self.min_version \u003d ("},{"line_number":48,"context_line":"            get_init_version(abs_path\u003dself.repo_path))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        with sql.session_for_read() as session:"},{"line_number":51,"context_line":"            self.schema_ \u003d versioning_api.ControlledSchema.create("},{"line_number":52,"context_line":"                session.get_bind(), self.repo_path, self.min_version)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_ede08e2b","line":50,"updated":"2016-09-16 20:11:18.000000000","message":"Might want to explain in the commit message why this is now a read-only engine.","commit_id":"b616f9008218444ae6f44b80861c2120b2349d22"}]}
