)]}'
{"keystone/notifications.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"56bf318f0a5e147554f686394ae5e6361301b930","unresolved":false,"context_lines":[{"line_number":481,"context_line":"    def __call__(self, f):"},{"line_number":482,"context_line":"        @functools.wraps(f)"},{"line_number":483,"context_line":"        def wrapper(wrapped_self, request, user_id, *args, **kwargs):"},{"line_number":484,"context_line":"            \"\"\"Always send a notification.\"\"\""},{"line_number":485,"context_line":"            initiator \u003d _get_request_audit_info(request.context_dict, user_id)"},{"line_number":486,"context_line":"            target \u003d resource.Resource(typeURI\u003dtaxonomy.ACCOUNT_USER)"},{"line_number":487,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_a55d84ee","line":484,"range":{"start_line":484,"start_character":12,"end_line":484,"end_character":45},"updated":"2016-09-28 13:18:05.000000000","message":"You can turn this into a comment, it doesn\u0027t need to be a docstringa","commit_id":"b115d676dcf31d0bde85628cc07c9bd9cfbd5742"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"deabcbc3ce24aaa9a51a6fdd96ea3b42159d7824","unresolved":false,"context_lines":[{"line_number":481,"context_line":"    def __call__(self, f):"},{"line_number":482,"context_line":"        @functools.wraps(f)"},{"line_number":483,"context_line":"        def wrapper(wrapped_self, request, user_id, *args, **kwargs):"},{"line_number":484,"context_line":"            \"\"\"Always send a notification.\"\"\""},{"line_number":485,"context_line":"            initiator \u003d _get_request_audit_info(request.context_dict, user_id)"},{"line_number":486,"context_line":"            target \u003d resource.Resource(typeURI\u003dtaxonomy.ACCOUNT_USER)"},{"line_number":487,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_3188ab22","line":484,"range":{"start_line":484,"start_character":12,"end_line":484,"end_character":45},"in_reply_to":"3a98d1f4_a55d84ee","updated":"2016-09-29 05:39:31.000000000","message":"re-write this line to:\n\n  # Always send a notification","commit_id":"b115d676dcf31d0bde85628cc07c9bd9cfbd5742"}],"tox.ini":[{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"a444e32a0548e2f6db7694739bb19a781e2d1992","unresolved":false,"context_lines":[{"line_number":122,"context_line":"# D103: Missing docstring in public function"},{"line_number":123,"context_line":"# D104: Missing docstring in public package"},{"line_number":124,"context_line":"# D203: 1 blank line required before class docstring (deprecated in pep257)"},{"line_number":125,"context_line":"ignore \u003d D100,D101,D102,D103,D104,D203,D401"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"exclude\u003d.venv,.git,.tox,build,dist,*lib/python*,*egg,tools,vendor,.update-venv,*.ini,*.po,*.pot"},{"line_number":128,"context_line":"max-complexity\u003d24"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5a8bc5a2_2a6208ae","line":125,"range":{"start_line":125,"start_character":39,"end_line":125,"end_character":43},"updated":"2016-09-28 06:30:30.000000000","message":"@Steve Martinelli\n\nIt\u0027s really interesting, I need to update this word (D401) as link [1] How do you think about this, is it ok?\n\n[1] https://bugs.launchpad.net/keystone/+bug/1570049/+activity","commit_id":"b115d676dcf31d0bde85628cc07c9bd9cfbd5742"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"08c70bb16666451802bbe4159636ae941693f0df","unresolved":false,"context_lines":[{"line_number":122,"context_line":"# D103: Missing docstring in public function"},{"line_number":123,"context_line":"# D104: Missing docstring in public package"},{"line_number":124,"context_line":"# D203: 1 blank line required before class docstring (deprecated in pep257)"},{"line_number":125,"context_line":"ignore \u003d D100,D101,D102,D103,D104,D203,D401"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"exclude\u003d.venv,.git,.tox,build,dist,*lib/python*,*egg,tools,vendor,.update-venv,*.ini,*.po,*.pot"},{"line_number":128,"context_line":"max-complexity\u003d24"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a98d1f4_b8e2dbd3","line":125,"range":{"start_line":125,"start_character":39,"end_line":125,"end_character":43},"in_reply_to":"3a98d1f4_11abaf75","updated":"2016-09-29 07:41:44.000000000","message":"Thanks for your time. I understood what you mean now, I already updated a new patch as your comment. :)","commit_id":"b115d676dcf31d0bde85628cc07c9bd9cfbd5742"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"deabcbc3ce24aaa9a51a6fdd96ea3b42159d7824","unresolved":false,"context_lines":[{"line_number":122,"context_line":"# D103: Missing docstring in public function"},{"line_number":123,"context_line":"# D104: Missing docstring in public package"},{"line_number":124,"context_line":"# D203: 1 blank line required before class docstring (deprecated in pep257)"},{"line_number":125,"context_line":"ignore \u003d D100,D101,D102,D103,D104,D203,D401"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"exclude\u003d.venv,.git,.tox,build,dist,*lib/python*,*egg,tools,vendor,.update-venv,*.ini,*.po,*.pot"},{"line_number":128,"context_line":"max-complexity\u003d24"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a98d1f4_11abaf75","line":125,"range":{"start_line":125,"start_character":39,"end_line":125,"end_character":43},"in_reply_to":"3a98d1f4_562b6d82","updated":"2016-09-29 05:39:31.000000000","message":"Sure, the reason this fails earlier is because D401 enforces certain words in a docstring (Alway vs Always).\n\nAnyway, we don\u0027t need a docstring for line 484 of notifications.py, it\u0027s a decorator. I recommend using a comment instead, and undo\u0027ing this change to tox.ini.","commit_id":"b115d676dcf31d0bde85628cc07c9bd9cfbd5742"},{"author":{"_account_id":19554,"name":"Nam","email":"namnh68@fsoft.com.vn","username":"namnh"},"change_message_id":"626cdc53bd1ffec2a0c2f2779e6edb9ec59bc649","unresolved":false,"context_lines":[{"line_number":122,"context_line":"# D103: Missing docstring in public function"},{"line_number":123,"context_line":"# D104: Missing docstring in public package"},{"line_number":124,"context_line":"# D203: 1 blank line required before class docstring (deprecated in pep257)"},{"line_number":125,"context_line":"ignore \u003d D100,D101,D102,D103,D104,D203,D401"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"exclude\u003d.venv,.git,.tox,build,dist,*lib/python*,*egg,tools,vendor,.update-venv,*.ini,*.po,*.pot"},{"line_number":128,"context_line":"max-complexity\u003d24"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a98d1f4_562b6d82","line":125,"range":{"start_line":125,"start_character":39,"end_line":125,"end_character":43},"in_reply_to":"3a98d1f4_c530d0a1","updated":"2016-09-29 04:43:46.000000000","message":"I don\u0027t really understand what you mean. Would you mind telling me for more detail.","commit_id":"b115d676dcf31d0bde85628cc07c9bd9cfbd5742"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"fbf5b67ee6936f03d478a90d6796a55b66583875","unresolved":false,"context_lines":[{"line_number":122,"context_line":"# D103: Missing docstring in public function"},{"line_number":123,"context_line":"# D104: Missing docstring in public package"},{"line_number":124,"context_line":"# D203: 1 blank line required before class docstring (deprecated in pep257)"},{"line_number":125,"context_line":"ignore \u003d D100,D101,D102,D103,D104,D203,D401"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"exclude\u003d.venv,.git,.tox,build,dist,*lib/python*,*egg,tools,vendor,.update-venv,*.ini,*.po,*.pot"},{"line_number":128,"context_line":"max-complexity\u003d24"}],"source_content_type":"text/x-properties","patch_set":2,"id":"5a8bc5a2_be057a15","line":125,"range":{"start_line":125,"start_character":39,"end_line":125,"end_character":43},"in_reply_to":"5a8bc5a2_2a6208ae","updated":"2016-09-28 08:19:18.000000000","message":"since we not ignore by intention, let\u0027s not bring regressions.","commit_id":"b115d676dcf31d0bde85628cc07c9bd9cfbd5742"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"56bf318f0a5e147554f686394ae5e6361301b930","unresolved":false,"context_lines":[{"line_number":122,"context_line":"# D103: Missing docstring in public function"},{"line_number":123,"context_line":"# D104: Missing docstring in public package"},{"line_number":124,"context_line":"# D203: 1 blank line required before class docstring (deprecated in pep257)"},{"line_number":125,"context_line":"ignore \u003d D100,D101,D102,D103,D104,D203,D401"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"exclude\u003d.venv,.git,.tox,build,dist,*lib/python*,*egg,tools,vendor,.update-venv,*.ini,*.po,*.pot"},{"line_number":128,"context_line":"max-complexity\u003d24"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a98d1f4_c530d0a1","line":125,"range":{"start_line":125,"start_character":39,"end_line":125,"end_character":43},"in_reply_to":"5a8bc5a2_be057a15","updated":"2016-09-28 13:18:05.000000000","message":"i agree with davechen, these are docstring checks, let\u0027s just change the bad line to a comment, there\u0027s no reason for it to be a docstring","commit_id":"b115d676dcf31d0bde85628cc07c9bd9cfbd5742"}]}