)]}'
{"etc/keystone.conf.sample":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4967d95aa8914d7a7c0c0a2e08dbb605d1474c43","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Controls the token construction, validation, and revocation operations."},{"line_number":131,"context_line":"# Core providers are keystone.token.providers.[pki|uuid].Provider"},{"line_number":132,"context_line":"# provider \u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Amount of time a token should remain valid (in seconds)"},{"line_number":135,"context_line":"# expiration \u003d 86400"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAQn%2F%2Fvek%3D","line":132,"updated":"2013-07-24 04:08:49.000000000","message":"In config.py there isn\u0027t a default for this, should there be a documented default?","commit_id":"d9ad2b1f1ce05d3786e64e03eb895337a3807181"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"56e425ef6626f31e0aa55ab7c532fd09f4c6934e","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"# Controls the token construction, validation, and revocation operations."},{"line_number":131,"context_line":"# Core providers are keystone.token.providers.[pki|uuid].Provider"},{"line_number":132,"context_line":"# provider \u003d"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Amount of time a token should remain valid (in seconds)"},{"line_number":135,"context_line":"# expiration \u003d 86400"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAQn%2F%2FtSI%3D","line":132,"in_reply_to":"AAAAQn%2F%2Fvek%3D","updated":"2013-07-24 17:40:12.000000000","message":"I don\u0027t know what a documented default is, so I don\u0027t have an answer.","commit_id":"d9ad2b1f1ce05d3786e64e03eb895337a3807181"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4967d95aa8914d7a7c0c0a2e08dbb605d1474c43","unresolved":false,"context_lines":[{"line_number":167,"context_line":"[signing]"},{"line_number":168,"context_line":"# Deprecated in favor of provider in the [token] section"},{"line_number":169,"context_line":"# Allowed values are PKI or UUID"},{"line_number":170,"context_line":"#token_format \u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"#certfile \u003d /etc/keystone/pki/certs/signing_cert.pem"},{"line_number":173,"context_line":"#keyfile \u003d /etc/keystone/pki/private/signing_key.pem"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAQn%2F%2Fve8%3D","line":170,"updated":"2013-07-24 04:08:49.000000000","message":"I take it we don\u0027t provide defaults for deprecated config opts?","commit_id":"d9ad2b1f1ce05d3786e64e03eb895337a3807181"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"56e425ef6626f31e0aa55ab7c532fd09f4c6934e","unresolved":false,"context_lines":[{"line_number":167,"context_line":"[signing]"},{"line_number":168,"context_line":"# Deprecated in favor of provider in the [token] section"},{"line_number":169,"context_line":"# Allowed values are PKI or UUID"},{"line_number":170,"context_line":"#token_format \u003d"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"#certfile \u003d /etc/keystone/pki/certs/signing_cert.pem"},{"line_number":173,"context_line":"#keyfile \u003d /etc/keystone/pki/private/signing_key.pem"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAQn%2F%2FtSQ%3D","line":170,"in_reply_to":"AAAAQn%2F%2Fve8%3D","updated":"2013-07-24 17:40:12.000000000","message":"The default in the sample config file should match the default in config.py. Deprecated config options can have defaults, I guess, but it makes it impossible for the code to know if it wasn\u0027t set explicitly by the user.","commit_id":"d9ad2b1f1ce05d3786e64e03eb895337a3807181"}],"keystone/token/provider.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4967d95aa8914d7a7c0c0a2e08dbb605d1474c43","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        ``provider`` instead."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if not CONF.signing.token_format:"},{"line_number":69,"context_line":"            if not CONF.token.provider:"},{"line_number":70,"context_line":"                return PKI_PROVIDER"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FvfM%3D","line":67,"updated":"2013-07-24 04:08:49.000000000","message":"This is just a suggestion, but I think with this check here and the once below (which went in recently I believe), we should document this check with a little explanation as to why we returning PKI_PROVIDER when CONF.token.provider isn\u0027t set. \n\nAnother thing we might be able to do is to incorporate the new check (68 - 72) in the else statement below, as it fills the same condition. This would require the _msg to be changed as noted in the bug report.","commit_id":"d9ad2b1f1ce05d3786e64e03eb895337a3807181"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"56e425ef6626f31e0aa55ab7c532fd09f4c6934e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        ``provider`` instead."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if not CONF.signing.token_format:"},{"line_number":69,"context_line":"            if not CONF.token.provider:"},{"line_number":70,"context_line":"                return PKI_PROVIDER"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FtRo%3D","line":67,"in_reply_to":"AAAAQn%2F%2FvfM%3D","updated":"2013-07-24 17:40:12.000000000","message":"I think this is taken care of in the latest patch set. I didn\u0027t change _msg because I think it\u0027s accurate as is.","commit_id":"d9ad2b1f1ce05d3786e64e03eb895337a3807181"}]}