)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"8759402a063445b9a79836ab9612b9ca00752ece","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean up the code for credential deletion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone credential only has one backend, the logic of credentials"},{"line_number":10,"context_line":"deletion for project or user in SQL backend has been implemented"},{"line_number":11,"context_line":"and overridden the code in base, which means the default implementation"},{"line_number":12,"context_line":"in base will never been called."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_fc3901a5","line":9,"updated":"2016-10-10 13:05:32.000000000","message":"How do we know that there\u0027s only 1 backend? Somebody might have implemented their own vendor-specific backend.","commit_id":"15b5db643296ec92114f261b51ac31abb3f200f7"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"3fcd21d7f0e555d2058f27589b5181aec4f05833","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean up the code for credential deletion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone credential only has one backend, the logic of credentials"},{"line_number":10,"context_line":"deletion for project or user in SQL backend has been implemented"},{"line_number":11,"context_line":"and overridden the code in base, which means the default implementation"},{"line_number":12,"context_line":"in base will never been called."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_f3d84f55","line":9,"in_reply_to":"1a95cdbc_90e461ac","updated":"2016-10-10 13:41:02.000000000","message":"okay, as long as we agree these functions are special ones, and we need the default implementation for them while all others needn\u0027t.","commit_id":"15b5db643296ec92114f261b51ac31abb3f200f7"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"0dbc447975f9b9bcc144ff861861ca065edb5b92","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean up the code for credential deletion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone credential only has one backend, the logic of credentials"},{"line_number":10,"context_line":"deletion for project or user in SQL backend has been implemented"},{"line_number":11,"context_line":"and overridden the code in base, which means the default implementation"},{"line_number":12,"context_line":"in base will never been called."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_a6ecc7bb","line":9,"in_reply_to":"1a95cdbc_f3d84f55","updated":"2016-10-10 14:01:55.000000000","message":"then the reason for the change is different than what\u0027s in the commit message and the commit message should be fixed.","commit_id":"15b5db643296ec92114f261b51ac31abb3f200f7"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"003d7f4724bacd5712bafdd4600db0da472ef4b5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Clean up the code for credential deletion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Keystone credential only has one backend, the logic of credentials"},{"line_number":10,"context_line":"deletion for project or user in SQL backend has been implemented"},{"line_number":11,"context_line":"and overridden the code in base, which means the default implementation"},{"line_number":12,"context_line":"in base will never been called."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a95cdbc_90e461ac","line":9,"in_reply_to":"1a95cdbc_fc3901a5","updated":"2016-10-10 13:28:56.000000000","message":"then the custom backend should implement \"delete_credentials_for_project\" and \"delete_credentials_for_user\".\n\ndeleting these functions would mean fewer functions to implement","commit_id":"15b5db643296ec92114f261b51ac31abb3f200f7"}]}