)]}'
{"keystone/trust/backends/base.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"160d9db72b398cfe5a6dc2e716fc04e4ee002b12","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @abc.abstractmethod"},{"line_number":75,"context_line":"    def delete_trust_for_project(self, project_id):"},{"line_number":76,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_fff1e901","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":32},"updated":"2016-10-10 16:22:06.000000000","message":"add a docstring, or perhaps add one for all the functions in a separate patch :)","commit_id":"3f3f9f277d427321a1f36c80cd37fb43a11d6424"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"18c6c3c2c1ac0b1c997e90021482ad4fc3655eea","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @abc.abstractmethod"},{"line_number":75,"context_line":"    def delete_trust_for_project(self, project_id):"},{"line_number":76,"context_line":"        raise exception.NotImplemented()  # pragma: no cover"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_d5814b4f","line":75,"range":{"start_line":75,"start_character":8,"end_line":75,"end_character":32},"in_reply_to":"1a95cdbc_fff1e901","updated":"2016-10-11 02:13:32.000000000","message":"let\u0027s fix this first.","commit_id":"3f3f9f277d427321a1f36c80cd37fb43a11d6424"}],"releasenotes/notes/bug-1622310-c501cf77437fdfa6.yaml":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e13c08383dc2d898148a210d81e1ebde588163d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fa6399be_28a67710","updated":"2016-10-12 04:29:28.000000000","message":"include an \"other\" section that indicates a custom implementation will now have to create the \"delete_trusts_for_project\" method","commit_id":"f07f852222cdf4bce200985939f609eeeedfa65b"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"f08692d52879b8e49cc2350e608fcfd004428c25","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1622310 \u003chttps://bugs.launchpad.net/keystone/+bug/1622310\u003e`_]"},{"line_number":5,"context_line":"    Keystone trust will be invalidated if the project that trust scoped to"},{"line_number":6,"context_line":"    or the user (trustor or trustee) the delegation is assigned for as long"},{"line_number":7,"context_line":"    as the user is maintained by keystone server have been deleted."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - Abstract method ``delete_trusts_for_project`` should be implemented by"},{"line_number":10,"context_line":"    custom driver."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_1b3fca87","line":7,"range":{"start_line":6,"start_character":5,"end_line":7,"end_character":48},"updated":"2016-10-14 09:22:33.000000000","message":"this sounds confusing to me....sounds like you are say this change deletes a trust when a user is deleted? (which I am sure is true, but I don\u0027t that\u0027s this fix).","commit_id":"6501da336e0fbdf32e234921f5fe1dcf24e445e6"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8eb6659234c4445fee92b75437748b79e11c7bca","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1622310 \u003chttps://bugs.launchpad.net/keystone/+bug/1622310\u003e`_]"},{"line_number":5,"context_line":"    Keystone trust will be invalidated if the project that trust scoped to"},{"line_number":6,"context_line":"    or the user (trustor or trustee) the delegation is assigned for as long"},{"line_number":7,"context_line":"    as the user is maintained by keystone server have been deleted."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - Abstract method ``delete_trusts_for_project`` should be implemented by"},{"line_number":10,"context_line":"    custom driver."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_47a87477","line":7,"range":{"start_line":6,"start_character":5,"end_line":7,"end_character":48},"in_reply_to":"fa6399be_1b3fca87","updated":"2016-10-14 15:24:53.000000000","message":"i asked Dave to make a single release note for 2 changes. This one (handle project deletes) and the one it depends on (handle user deletes) -- https://review.openstack.org/#/c/369354/6","commit_id":"6501da336e0fbdf32e234921f5fe1dcf24e445e6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"4b3e014470672e845f512678c28864176bfd9753","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1622310 \u003chttps://bugs.launchpad.net/keystone/+bug/1622310\u003e`_]"},{"line_number":5,"context_line":"    Keystone trust will be invalidated if the project that trust scoped to"},{"line_number":6,"context_line":"    or the user (trustor or trustee) the delegation is assigned for as long"},{"line_number":7,"context_line":"    as the user is maintained by keystone server have been deleted."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - Abstract method ``delete_trusts_for_project`` should be implemented by"},{"line_number":10,"context_line":"    custom driver."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_d95c6c7f","line":7,"range":{"start_line":6,"start_character":5,"end_line":7,"end_character":48},"in_reply_to":"fa6399be_47a87477","updated":"2016-10-14 15:51:13.000000000","message":"Ah, ok, got it. Perhaps in that case, just a change of wording would make this clearer, e.g.:\n\nKeystone trust will be invalidated if the project to which the  trust is scoped, or the user (trustor or trustee) for which the delegation is assigned, have been deleted.","commit_id":"6501da336e0fbdf32e234921f5fe1dcf24e445e6"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"f08692d52879b8e49cc2350e608fcfd004428c25","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    as the user is maintained by keystone server have been deleted."},{"line_number":8,"context_line":"other:"},{"line_number":9,"context_line":"  - Abstract method ``delete_trusts_for_project`` should be implemented by"},{"line_number":10,"context_line":"    custom driver."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa6399be_9b53dae1","line":10,"range":{"start_line":10,"start_character":11,"end_line":10,"end_character":17},"updated":"2016-10-14 09:22:33.000000000","message":"nit: drivers ?","commit_id":"6501da336e0fbdf32e234921f5fe1dcf24e445e6"}]}