)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"2d22baf4ee987f86de2d7971893dc8b3005fc3a1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     George Tian \u003ctian694293774@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-11 13:53:59 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove redundant code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic376806a7714262a2d471d8314de82fee49f0848"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_6b17a5a3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":21},"updated":"2016-10-11 14:27:56.000000000","message":"why is the code redundant? add more details in the commit message to help out the reviewers :)","commit_id":"dae3fa22d80f331d52c599c439c24bd8f39dd210"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"a88f4d68605c69331bc4ccaa25ac60571b41d5d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     George Tian \u003ctian694293774@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-11 13:53:59 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove redundant code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic376806a7714262a2d471d8314de82fee49f0848"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa6399be_6bd31439","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":21},"in_reply_to":"fa6399be_6b17a5a3","updated":"2016-10-11 21:04:26.000000000","message":"++","commit_id":"dae3fa22d80f331d52c599c439c24bd8f39dd210"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"9cc9db7f166c276b40128501b28083399ab8745a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove redundant code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. This function is similar to the above function .but this function no use ref,   maybe the author is missing"},{"line_number":10,"context_line":"2. Don\u0027t need to declare a variable outside a block in python"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic376806a7714262a2d471d8314de82fee49f0848"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa6399be_509517e2","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":110},"updated":"2016-10-12 02:22:08.000000000","message":"wrap this line under 78 chars.","commit_id":"cbd5a8bbeab67b2b78a6441c908d238580b82fb7"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0e7fb9bbda501ad362c8335443db57fda5e55742","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     George Tian \u003ctian694293774@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-12 10:54:07 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove redundant code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. This function is similar to the above function ."},{"line_number":10,"context_line":"   but this function no use ref,   maybe the author is missing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_e52ca84c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":21},"updated":"2016-10-12 03:50:01.000000000","message":"commit message should cover all your change if possible, you are not just remove redundant code here.","commit_id":"3dcf57476f6c8e9f75c7ffb014dabbe602992b21"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0e7fb9bbda501ad362c8335443db57fda5e55742","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove redundant code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. This function is similar to the above function ."},{"line_number":10,"context_line":"   but this function no use ref,   maybe the author is missing"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"2. Don\u0027t need to declare a variable outside a block in python"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_a51b901a","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":16},"updated":"2016-10-12 03:50:01.000000000","message":"I don\u0027t think anyone know which function from this claim.","commit_id":"3dcf57476f6c8e9f75c7ffb014dabbe602992b21"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"0e7fb9bbda501ad362c8335443db57fda5e55742","unresolved":false,"context_lines":[{"line_number":10,"context_line":"   but this function no use ref,   maybe the author is missing"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"2. Don\u0027t need to declare a variable outside a block in python"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic376806a7714262a2d471d8314de82fee49f0848"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_c5ede4f0","line":13,"updated":"2016-10-12 03:50:01.000000000","message":"Just a brief here to say what\u0027s your change is about is enough, nothing I can get from your commit message.","commit_id":"3dcf57476f6c8e9f75c7ffb014dabbe602992b21"}],"keystone/federation/controllers.py":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"70e446ae9fae9889361c99bbbafbafeb7f484b20","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    @controller.protected()"},{"line_number":196,"context_line":"    def update_protocol(self, request, idp_id, protocol_id, protocol):"},{"line_number":197,"context_line":"        validation.lazy_validate(schema.protocol_update, protocol)"},{"line_number":198,"context_line":"        ref \u003d self._normalize_dict(protocol)"},{"line_number":199,"context_line":"        ref \u003d self.federation_api.update_protocol(idp_id, protocol_id,"},{"line_number":200,"context_line":"                                                  protocol)"},{"line_number":201,"context_line":"        return FederationProtocol.wrap_member(request.context_dict, ref)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_10e63fb4","side":"PARENT","line":198,"range":{"start_line":198,"start_character":8,"end_line":198,"end_character":44},"updated":"2016-10-12 02:21:19.000000000","message":"If you looking into the method of `_normalize_dict` and how table `federation_protocol` defined you will find this method is actually needed.\n\nIf you pass the protocol contains the keys like `mapping-id`, it\u0027s should be normalized to `mapping_id` to match with DB schema.\n\nSo, pls do it like this:\n\n    normalized_protocol \u003d self._normalize_dict(protocol)\n    ref \u003d self.federation_api.update_protocol(idp_id, protocol_id, normalized_protocol)\n\nYou can fix all other occurances if you have an interest :)","commit_id":"3079ce0b189a9426a4d81ae8ea361fc925de62ca"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"b9d1e5daa22562dd837b79b38f3daad91c9e9669","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    @controller.protected()"},{"line_number":196,"context_line":"    def update_protocol(self, request, idp_id, protocol_id, protocol):"},{"line_number":197,"context_line":"        validation.lazy_validate(schema.protocol_update, protocol)"},{"line_number":198,"context_line":"        normalized_protocol \u003d self._normalize_dict(protocol)"},{"line_number":199,"context_line":"        ref \u003d self.federation_api.update_protocol(idp_id, protocol_id,"},{"line_number":200,"context_line":"                                                  normalized_protocol)"},{"line_number":201,"context_line":"        return FederationProtocol.wrap_member(request.context_dict, ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_8a9be571","line":198,"updated":"2016-10-12 13:24:26.000000000","message":"It looks to me like this may be fixing a bug. If that\u0027s the case we should at least have a test or two showing the problem and likely a launchpad bug as well. (The bug is that protocol was not normalized before.)","commit_id":"35da01366bc9dbe8521fd02a0c26727e8a7b080c"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"a758c9345bb89ff9aa63ecdfcd4f24cbcb4fb6ff","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    @controller.protected()"},{"line_number":196,"context_line":"    def update_protocol(self, request, idp_id, protocol_id, protocol):"},{"line_number":197,"context_line":"        validation.lazy_validate(schema.protocol_update, protocol)"},{"line_number":198,"context_line":"        normalized_protocol \u003d self._normalize_dict(protocol)"},{"line_number":199,"context_line":"        ref \u003d self.federation_api.update_protocol(idp_id, protocol_id,"},{"line_number":200,"context_line":"                                                  normalized_protocol)"},{"line_number":201,"context_line":"        return FederationProtocol.wrap_member(request.context_dict, ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_50789bc4","line":198,"in_reply_to":"fa6399be_8a9be571","updated":"2016-10-12 14:49:44.000000000","message":"+1. This is not only a cosmetic fix.","commit_id":"35da01366bc9dbe8521fd02a0c26727e8a7b080c"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"205495cebaa893355b96e3d58d27e417997bb41a","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    @controller.protected()"},{"line_number":196,"context_line":"    def update_protocol(self, request, idp_id, protocol_id, protocol):"},{"line_number":197,"context_line":"        validation.lazy_validate(schema.protocol_update, protocol)"},{"line_number":198,"context_line":"        normalized_protocol \u003d self._normalize_dict(protocol)"},{"line_number":199,"context_line":"        ref \u003d self.federation_api.update_protocol(idp_id, protocol_id,"},{"line_number":200,"context_line":"                                                  normalized_protocol)"},{"line_number":201,"context_line":"        return FederationProtocol.wrap_member(request.context_dict, ref)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @controller.protected()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a6eadb0_8fe22d00","line":200,"range":{"start_line":198,"start_character":8,"end_line":200,"end_character":70},"updated":"2016-12-20 02:25:56.000000000","message":"if this is causing a unexpected behavior (since the normalized protocol was not used), a bug should be reported.\n\nyou could just have left the var name as it was (ref) and passed too (to be in consistency with create_protocol)","commit_id":"fd1139b4a40fa660b0f0cbac3134156ac90d9a64"}],"keystone/tests/unit/test_v3_federation.py":[{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"de28f880ac8db32627b93bddad4cdb7c6ce085d8","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        self.federation_api.create_protocol(self.idp[\u0027id\u0027],"},{"line_number":728,"context_line":"                                            self.proto_saml[\u0027id\u0027],"},{"line_number":729,"context_line":"                                            self.proto_saml)"},{"line_number":730,"context_line":"        # Update protocols"},{"line_number":731,"context_line":"        self.proto_saml \u003d self.proto_ref(mapping_id\u003dself.mapping[\u0027id\u0027])"},{"line_number":732,"context_line":"        self.proto_saml[\u0027id\u0027] \u003d self.PROTOCOL"},{"line_number":733,"context_line":"        self.federation_api.update_protocol(self.idp[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_75f44a5a","line":730,"updated":"2016-10-14 13:17:59.000000000","message":"This change doesn\u0027t test your change at all. It passes without it applied. You should create a new test that fails without your change and passes with it to show what the change is actually doing.","commit_id":"fd1139b4a40fa660b0f0cbac3134156ac90d9a64"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"d9fab2b1763f8225d747b3e2b4f762a24d6b598e","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        self.federation_api.create_protocol(self.idp[\u0027id\u0027],"},{"line_number":728,"context_line":"                                            self.proto_saml[\u0027id\u0027],"},{"line_number":729,"context_line":"                                            self.proto_saml)"},{"line_number":730,"context_line":"        # Update protocols"},{"line_number":731,"context_line":"        self.proto_saml \u003d self.proto_ref(mapping_id\u003dself.mapping[\u0027id\u0027])"},{"line_number":732,"context_line":"        self.proto_saml[\u0027id\u0027] \u003d self.PROTOCOL"},{"line_number":733,"context_line":"        self.federation_api.update_protocol(self.idp[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_e0231dbb","line":730,"in_reply_to":"fa6399be_75f44a5a","updated":"2016-10-15 08:03:28.000000000","message":"++","commit_id":"fd1139b4a40fa660b0f0cbac3134156ac90d9a64"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"99e1df8519f012b73ca2a0c73164a95ca3bf14c7","unresolved":false,"context_lines":[{"line_number":727,"context_line":"        self.federation_api.create_protocol(self.idp[\u0027id\u0027],"},{"line_number":728,"context_line":"                                            self.proto_saml[\u0027id\u0027],"},{"line_number":729,"context_line":"                                            self.proto_saml)"},{"line_number":730,"context_line":"        # Update protocols"},{"line_number":731,"context_line":"        self.proto_saml \u003d self.proto_ref(mapping_id\u003dself.mapping[\u0027id\u0027])"},{"line_number":732,"context_line":"        self.proto_saml[\u0027id\u0027] \u003d self.PROTOCOL"},{"line_number":733,"context_line":"        self.federation_api.update_protocol(self.idp[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5201f7_3db838c8","line":730,"in_reply_to":"fa6399be_e0231dbb","updated":"2017-01-04 22:56:03.000000000","message":"++","commit_id":"fd1139b4a40fa660b0f0cbac3134156ac90d9a64"}]}