)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"fec8d4e8009c3ab726e79d61fcc31d4eabc46b09","unresolved":false,"context_lines":[{"line_number":11,"context_line":"in the token reference we didn\u0027t bother rebuilding it. This logic has"},{"line_number":12,"context_line":"since been removed in favor of always reconstructing the token, which"},{"line_number":13,"context_line":"means we no longer need these checks."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1f2d1c68a61360fc091d8484a39da20da123599e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a629dbe_35068386","line":14,"updated":"2016-11-09 21:23:46.000000000","message":"why were these short-circuits added ? It\u0027d be nice to do some profiling to make sure we aren\u0027t rebuilding the info a lot of times","commit_id":"184a3df46a17bbf720bc2f0277d110a16ecbe495"}],"keystone/token/providers/common.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"7fba7bffb3602da532c8cf2b4b7b51422a3e9280","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        super(V3TokenDataHelper, self).__init__()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _get_filtered_domain(self, domain_id):"},{"line_number":96,"context_line":"        domain \u003d {}"},{"line_number":97,"context_line":"        if domain_id:"},{"line_number":98,"context_line":"            domain_ref \u003d self.resource_api.get_domain(domain_id)"},{"line_number":99,"context_line":"            domain \u003d {\u0027id\u0027: domain_ref[\u0027id\u0027], \u0027name\u0027: domain_ref[\u0027name\u0027]}"},{"line_number":100,"context_line":"        return domain"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _get_filtered_project(self, project_id):"},{"line_number":103,"context_line":"        project_ref \u003d self.resource_api.get_project(project_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_78268bbb","line":100,"range":{"start_line":96,"start_character":0,"end_line":100,"end_character":21},"updated":"2016-10-22 09:12:49.000000000","message":"is this part of this change?","commit_id":"184a3df46a17bbf720bc2f0277d110a16ecbe495"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"fec8d4e8009c3ab726e79d61fcc31d4eabc46b09","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        super(V3TokenDataHelper, self).__init__()"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _get_filtered_domain(self, domain_id):"},{"line_number":96,"context_line":"        domain \u003d {}"},{"line_number":97,"context_line":"        if domain_id:"},{"line_number":98,"context_line":"            domain_ref \u003d self.resource_api.get_domain(domain_id)"},{"line_number":99,"context_line":"            domain \u003d {\u0027id\u0027: domain_ref[\u0027id\u0027], \u0027name\u0027: domain_ref[\u0027name\u0027]}"},{"line_number":100,"context_line":"        return domain"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def _get_filtered_project(self, project_id):"},{"line_number":103,"context_line":"        project_ref \u003d self.resource_api.get_project(project_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_75ae3b82","line":100,"range":{"start_line":96,"start_character":0,"end_line":100,"end_character":21},"in_reply_to":"da6895a0_78268bbb","updated":"2016-11-09 21:23:46.000000000","message":"not needed, see Steve\u0027s comment below","commit_id":"184a3df46a17bbf720bc2f0277d110a16ecbe495"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"d573c1ec915d0310da68a5d8e5db4f75ce8e30f1","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        return filtered_project"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def _populate_scope(self, token_data, domain_id, project_id):"},{"line_number":116,"context_line":"        if domain_id:"},{"line_number":117,"context_line":"            token_data[\u0027domain\u0027] \u003d self._get_filtered_domain(domain_id)"},{"line_number":118,"context_line":"        if project_id:"},{"line_number":119,"context_line":"            token_data[\u0027project\u0027] \u003d self._get_filtered_project(project_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da6895a0_1e056479","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":21},"updated":"2016-10-24 11:02:50.000000000","message":"the check for if domain_id is already done here, no need to repeat it on line 97, you get there via line 117","commit_id":"184a3df46a17bbf720bc2f0277d110a16ecbe495"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"fec8d4e8009c3ab726e79d61fcc31d4eabc46b09","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        return filtered_project"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def _populate_scope(self, token_data, domain_id, project_id):"},{"line_number":116,"context_line":"        if domain_id:"},{"line_number":117,"context_line":"            token_data[\u0027domain\u0027] \u003d self._get_filtered_domain(domain_id)"},{"line_number":118,"context_line":"        if project_id:"},{"line_number":119,"context_line":"            token_data[\u0027project\u0027] \u003d self._get_filtered_project(project_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_b57e1317","line":116,"range":{"start_line":116,"start_character":8,"end_line":116,"end_character":21},"in_reply_to":"da6895a0_1e056479","updated":"2016-11-09 21:23:46.000000000","message":"++","commit_id":"184a3df46a17bbf720bc2f0277d110a16ecbe495"}]}
