)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"d81abf6f23484d7ffb6d029a0181ac6068e92106","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As outlined in the discussion WIP patchset by dolphm for caching,"},{"line_number":10,"context_line":"the kwargs should be removed from the manager calls.  This is in"},{"line_number":11,"context_line":"preperation of the upcoming caching system."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I035c976314fb48f657661f681f7c1760d3c547a6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAQn%2F%2Fhq4%3D","line":11,"updated":"2013-07-29 19:51:41.000000000","message":"does the upcoming caching system have a blueprint?","commit_id":"709da973903e0439dc8515a130b5635725a1f52c"}],"keystone/token/controllers.py":[{"author":{"_account_id":220,"name":"Haneef Ali","email":"haneef.ali@hp.com","username":"haneef"},"change_message_id":"bcde66dfd8ffa500efb2a0c4c31d864e6c73d2d7","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                                    expiry)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        if tenant_ref:"},{"line_number":93,"context_line":"            catalog_ref \u003d self.catalog_api.get_catalog("},{"line_number":94,"context_line":"                user_ref[\u0027id\u0027], tenant_ref[\u0027id\u0027], metadata_ref)"},{"line_number":95,"context_line":"        else:"},{"line_number":96,"context_line":"            catalog_ref \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2FSU4%3D","line":93,"updated":"2013-08-02 15:07:28.000000000","message":"I believe this is going to introduce more defects. Many calls use default parameter and there are few cases where the order of parameter is not correct in keystone.  Python convention is to rely on name\u003dvalue  rather than order of the parameters. By removing name\u003d value paradigm in the calling code, you are relying on caller passing the params in correct order which is true in compiled languages such as java but not in python","commit_id":"5519e1ba16f59f302cda6e8db8f5423eed376ddf"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"2af414cd1fe0bdf382a7c265371b16989aa2b6f4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                                                    expiry)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        if tenant_ref:"},{"line_number":93,"context_line":"            catalog_ref \u003d self.catalog_api.get_catalog("},{"line_number":94,"context_line":"                user_ref[\u0027id\u0027], tenant_ref[\u0027id\u0027], metadata_ref)"},{"line_number":95,"context_line":"        else:"},{"line_number":96,"context_line":"            catalog_ref \u003d {}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAQn%2F%2FRe4%3D","line":93,"in_reply_to":"AAAAQn%2F%2FSU4%3D","updated":"2013-08-02 19:09:39.000000000","message":"valid concern but i\u0027d rather counter it by having more explicitly readable method calls into managers, and never using overloading manager methods with multiple purposes","commit_id":"5519e1ba16f59f302cda6e8db8f5423eed376ddf"}],"keystone/token/providers/test.py":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"90cb2a45fc1c850235f509fd9a357bb8bcaab56c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import dogpile.cache"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"R \u003d dogpile.cache.make_region()"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FVGM%3D","line":1,"updated":"2013-08-01 21:21:38.000000000","message":"What is this doing?  If this code is going to stay around, it needs a  copyright header.","commit_id":"836f64b7fda8394e9193619ce96eed38d2b7db38"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"e24949191e6c0c03ea5f8e6154dac8aab444d82c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import dogpile.cache"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"R \u003d dogpile.cache.make_region()"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FVAE%3D","line":1,"in_reply_to":"AAAAQn%2F%2FVGM%3D","updated":"2013-08-01 21:35:23.000000000","message":"Whoa.  That isn\u0027t supposed to be there, didn\u0027t even realize it was added to the git repo.","commit_id":"836f64b7fda8394e9193619ce96eed38d2b7db38"}]}