)]}'
{"keystone/common/config.py":[{"author":{"_account_id":7191,"name":"Jamie Lennox","email":"jamielennox@gmail.com","username":"jamielennox"},"change_message_id":"127950b5ea677519cf418fa5d18d2dcee61473bd","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def setup_logging(conf, product_name\u003d\u0027keystone\u0027):"},{"line_number":31,"context_line":"    \"\"\"Sets up the logging options for a log with supplied name"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    :param conf: a cfg.ConfOpts object"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2B%2BXE%3D","line":30,"updated":"2013-08-09 02:26:55.000000000","message":"just ditch this function, you\u0027re not using conf anyway.\n\nChange keystone-all and httpd to call logging from openstack.common","commit_id":"9f0d666f5d5bed31ef1ff50ce2e7a1155149e493"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ddf062cb0446c62162a40f12dcbd96cc3bb82e8c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def setup_logging(conf, product_name\u003d\u0027keystone\u0027):"},{"line_number":31,"context_line":"    \"\"\"Sets up the logging options for a log with supplied name"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    :param conf: a cfg.ConfOpts object"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2B8wc%3D","line":30,"in_reply_to":"AAAAQn%2F%2B%2BXE%3D","updated":"2013-08-09 14:04:54.000000000","message":"Done","commit_id":"9f0d666f5d5bed31ef1ff50ce2e7a1155149e493"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0e8e90b60886c71ddc5ce0214e5fe7fd24ebde5c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d cfg.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def setup_logging(conf, product_name\u003d\u0027keystone\u0027):"},{"line_number":31,"context_line":"    \"\"\"Sets up the logging options for a log with supplied name"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    :param conf: a cfg.ConfOpts object"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2B8pY%3D","line":30,"in_reply_to":"AAAAQn%2F%2B8wc%3D","updated":"2013-08-09 14:39:28.000000000","message":"That is a good idea and I refactored so that keystone/bin/keystone-all, keystone/cli.py, and keystone/httpd/keystone.py all use /keystone/openstack/common/log as logging. The problem is that there are some things in /keystone/common/logging.py that might not be in keystone/openstack/common/log.py, see trace pertaining to global log level: \n\nhttp://paste.openstack.org/show/43707/\n\nSo if we just switch out the setup_logging function with setup from keystone/openstack/common/log.py then we would be fine. If we implement keystone/openstack/common/log as logging in keystone/cli.py, keystone/httpd/keystone.py and keystone/bin/keystone-all then there are some assumed operations of the old implementation (keystone/common/logging.py). \n\nWondering how we should proceed with this. This might require us to make some changes to Oslo\u0027s logging module given the current implementation of logging in Keystone.","commit_id":"9f0d666f5d5bed31ef1ff50ce2e7a1155149e493"}]}