)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"22374fa89b344d6ce1411848aed9f9a578218628","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t invalidate all user tokens of roleless group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As discussed in [1], deleting a group invalidates all user tokens"},{"line_number":10,"context_line":"which can flood the revocaiton event table if the deleted group"},{"line_number":11,"context_line":"contained thousands of users in the group. This happens regardless"},{"line_number":12,"context_line":"of whether the group had any role assignment or not. This patch makes"},{"line_number":13,"context_line":"it so that only groups that had role assignments to a project or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_06dc9844","line":10,"range":{"start_line":10,"start_character":20,"end_line":10,"end_character":30},"updated":"2016-11-20 03:55:49.000000000","message":"revocation*","commit_id":"47bf143ac8d154d46826918a878eab5bf28c0f83"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"b35fb08bbe9ec493ccd1e41823c351cfaa1f4e12","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t invalidate all user tokens of roleless group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As discussed in [1], deleting a group invalidates all user tokens"},{"line_number":10,"context_line":"which can flood the revocaiton event table if the deleted group"},{"line_number":11,"context_line":"contained thousands of users in the group. This happens regardless"},{"line_number":12,"context_line":"of whether the group had any role assignment or not. This patch makes"},{"line_number":13,"context_line":"it so that only groups that had role assignments to a project or"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_c508fd2a","line":10,"range":{"start_line":10,"start_character":20,"end_line":10,"end_character":30},"in_reply_to":"7a77a97e_06dc9844","updated":"2016-11-28 18:00:32.000000000","message":"Done","commit_id":"47bf143ac8d154d46826918a878eab5bf28c0f83"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"22374fa89b344d6ce1411848aed9f9a578218628","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1]: https://bugs.launchpad.net/keystone/+bug/1268751"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Related Bug: #1268751"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I22ad364cb4737df3ed086f78310f75f3099ab4c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_a614c4e8","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":11},"updated":"2016-11-20 03:55:49.000000000","message":"Related-Bug*","commit_id":"47bf143ac8d154d46826918a878eab5bf28c0f83"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"b35fb08bbe9ec493ccd1e41823c351cfaa1f4e12","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[1]: https://bugs.launchpad.net/keystone/+bug/1268751"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Related Bug: #1268751"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I22ad364cb4737df3ed086f78310f75f3099ab4c1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a74a57a_e50b3922","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":11},"in_reply_to":"7a77a97e_a614c4e8","updated":"2016-11-28 18:00:32.000000000","message":"Done","commit_id":"47bf143ac8d154d46826918a878eab5bf28c0f83"}],"keystone/identity/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"31f3fe39b7de06e1104f61b3a4f4c5fe54952e9b","unresolved":false,"context_lines":[{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":"        # If the group has been created and has users but has no role"},{"line_number":1127,"context_line":"        # assignment for the group then we do not need to revoke all the users"},{"line_number":1128,"context_line":"        # tokens and can just delete the group."},{"line_number":1129,"context_line":"        if roles:"},{"line_number":1130,"context_line":"            for uid in user_ids:"},{"line_number":1131,"context_line":"                self.emit_invalidate_user_token_persistence(uid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_a123dcbb","line":1128,"updated":"2016-11-18 23:15:18.000000000","message":"Is this only true for uuid tokens?","commit_id":"47bf143ac8d154d46826918a878eab5bf28c0f83"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"f72628e7af753dc87ef7a94c8da5b85dcf57ef6e","unresolved":false,"context_lines":[{"line_number":1125,"context_line":""},{"line_number":1126,"context_line":"        # If the group has been created and has users but has no role"},{"line_number":1127,"context_line":"        # assignment for the group then we do not need to revoke all the users"},{"line_number":1128,"context_line":"        # tokens and can just delete the group."},{"line_number":1129,"context_line":"        if roles:"},{"line_number":1130,"context_line":"            for uid in user_ids:"},{"line_number":1131,"context_line":"                self.emit_invalidate_user_token_persistence(uid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_0a8da2d5","line":1128,"in_reply_to":"7a77a97e_a123dcbb","updated":"2016-11-28 18:00:09.000000000","message":"For both uuid and fernet tokens, deleting a group, with no role assignment and users in the group, will result in a revocation entry of each user\u0027s user_id. This fix changes that for both token providers so that revocation entries aren\u0027t filled from deleting a group if the group was never given a role for anything.","commit_id":"47bf143ac8d154d46826918a878eab5bf28c0f83"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"367b1bf99c294525e2f5d24c8831e4bed22d1dd9","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"    def delete_group(self, group_id, initiator\u003dNone):"},{"line_number":1115,"context_line":"        domain_id, driver, entity_id \u003d ("},{"line_number":1116,"context_line":"            self._get_domain_driver_and_entity_id(group_id))"},{"line_number":1117,"context_line":"        roles \u003d self.assignment_api.list_role_assignments(group_id\u003dgroup_id)"},{"line_number":1118,"context_line":"        user_ids \u003d (u[\u0027id\u0027] for u in self.list_users_in_group(group_id))"},{"line_number":1119,"context_line":"        driver.delete_group(entity_id)"},{"line_number":1120,"context_line":"        self.get_group.invalidate(self, group_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_e1fcdf73","line":1117,"range":{"start_line":1117,"start_character":8,"end_line":1117,"end_character":13},"updated":"2016-11-29 14:45:32.000000000","message":"nit: role_assignments","commit_id":"df721d05bfa4c69f8540d6051912d2430ed06213"}]}