)]}'
{"keystone/cmd/cli.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"0ff8cbe0016db483f98af0c0a6cdbe65263fe949","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"        try:"},{"line_number":1212,"context_line":"            domain_id \u003d cls.resource_api.get_domain_by_name(domain_name)[\u0027id\u0027]"},{"line_number":1213,"context_line":"        except exception.DomainNotFound:"},{"line_number":1214,"context_line":"            print(_(\u0027Invalid domain name: %(domain)s\u0027) % {"},{"line_number":1215,"context_line":"                \u0027domain\u0027: domain_name})"},{"line_number":1216,"context_line":"            return False"},{"line_number":1217,"context_line":"        # We don\u0027t actually need to tackle id_mapping_api in order to get"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_c179a394","line":1214,"range":{"start_line":1214,"start_character":21,"end_line":1214,"end_character":40},"updated":"2016-11-29 14:32:25.000000000","message":"unrelated: this message is not very helpful, maybe: \"Can not find a domain with name: %(domain)s\"","commit_id":"eed0db659cb3f446e018080b71b508a9f929747d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6bb9ef472aab589381a61d68abe520dcf81ef653","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"        try:"},{"line_number":1212,"context_line":"            domain_id \u003d cls.resource_api.get_domain_by_name(domain_name)[\u0027id\u0027]"},{"line_number":1213,"context_line":"        except exception.DomainNotFound:"},{"line_number":1214,"context_line":"            print(_(\u0027Invalid domain name: %(domain)s\u0027) % {"},{"line_number":1215,"context_line":"                \u0027domain\u0027: domain_name})"},{"line_number":1216,"context_line":"            return False"},{"line_number":1217,"context_line":"        # We don\u0027t actually need to tackle id_mapping_api in order to get"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_b704e914","line":1214,"in_reply_to":"5a74a57a_c179a394","updated":"2016-11-29 15:05:15.000000000","message":"++","commit_id":"eed0db659cb3f446e018080b71b508a9f929747d"}],"keystone/tests/unit/test_cli.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"0ff8cbe0016db483f98af0c0a6cdbe65263fe949","unresolved":false,"context_lines":[{"line_number":682,"context_line":"        CONF(args\u003d[\u0027mapping_populate\u0027, \u0027--domain-name\u0027, uuid.uuid4().hex],"},{"line_number":683,"context_line":"             project\u003d\u0027keystone\u0027)"},{"line_number":684,"context_line":"        dependency.reset()  # backends are loaded again in the command handler"},{"line_number":685,"context_line":"        cli.MappingPopulate.main()"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"class CliDomainConfigUploadNothing(unit.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_4194b389","line":685,"range":{"start_line":685,"start_character":8,"end_line":685,"end_character":34},"updated":"2016-11-29 14:32:25.000000000","message":"what this test is doing? Don\u0027t we need a assertFalse() here?","commit_id":"eed0db659cb3f446e018080b71b508a9f929747d"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"653fc768301b4963d65341fad728da45fca153e9","unresolved":false,"context_lines":[{"line_number":682,"context_line":"        CONF(args\u003d[\u0027mapping_populate\u0027, \u0027--domain-name\u0027, uuid.uuid4().hex],"},{"line_number":683,"context_line":"             project\u003d\u0027keystone\u0027)"},{"line_number":684,"context_line":"        dependency.reset()  # backends are loaded again in the command handler"},{"line_number":685,"context_line":"        cli.MappingPopulate.main()"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"class CliDomainConfigUploadNothing(unit.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_972d2d00","line":685,"in_reply_to":"5a74a57a_1cd4e2e9","updated":"2016-11-29 15:14:01.000000000","message":"think we still need to check the method return, if it blows up, the test will fail anyway","commit_id":"eed0db659cb3f446e018080b71b508a9f929747d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6bb9ef472aab589381a61d68abe520dcf81ef653","unresolved":false,"context_lines":[{"line_number":682,"context_line":"        CONF(args\u003d[\u0027mapping_populate\u0027, \u0027--domain-name\u0027, uuid.uuid4().hex],"},{"line_number":683,"context_line":"             project\u003d\u0027keystone\u0027)"},{"line_number":684,"context_line":"        dependency.reset()  # backends are loaded again in the command handler"},{"line_number":685,"context_line":"        cli.MappingPopulate.main()"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"class CliDomainConfigUploadNothing(unit.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_1cd4e2e9","line":685,"in_reply_to":"5a74a57a_4194b389","updated":"2016-11-29 15:05:15.000000000","message":"All this is doing is making sure we don\u0027t raise an unhandled exception when  we specify a domain name that doesn\u0027t exist. Prior to this patch, I would expect the call the `cli.MappingPopulate.main()` to blow up with the unhandled exception.\n\nWe could make this test a little more robust by ensuring a useful message is logged.","commit_id":"eed0db659cb3f446e018080b71b508a9f929747d"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"cfd074f650d7da3f9a17e94a382c86044e7f1d66","unresolved":false,"context_lines":[{"line_number":682,"context_line":"        CONF(args\u003d[\u0027mapping_populate\u0027, \u0027--domain-name\u0027, uuid.uuid4().hex],"},{"line_number":683,"context_line":"             project\u003d\u0027keystone\u0027)"},{"line_number":684,"context_line":"        dependency.reset()  # backends are loaded again in the command handler"},{"line_number":685,"context_line":"        cli.MappingPopulate.main()"},{"line_number":686,"context_line":""},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"class CliDomainConfigUploadNothing(unit.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_7ba59ab3","line":685,"in_reply_to":"5a74a57a_972d2d00","updated":"2016-12-08 14:33:12.000000000","message":"We know that when the domain does not exist, the main() method returns False. We can check on that.","commit_id":"eed0db659cb3f446e018080b71b508a9f929747d"}]}