)]}'
{"keystone/cmd/doctor/database.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b25872dfe72a2155a8dfdf40348651e469cafe7a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CONF \u003d keystone.conf.CONF"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def symptom_database_connection_is_not_SQLite():"},{"line_number":20,"context_line":"    \"\"\"SQLite is not recommended for production deployments."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    SQLite does not enforce type checking and has limited support for"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_3798871b","side":"PARENT","line":19,"updated":"2016-12-08 19:09:22.000000000","message":"I don\u0027t mind the original name for this since it was saying we don\u0027t want SQLite. I was more or less making a comment about the how the test read.","commit_id":"3f850d5d00de41b3ec90772fd67bda26a3c7d951"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"320add8bc013e2e46ca89bc95e31ed4d866f8a48","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CONF \u003d keystone.conf.CONF"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def symptom_database_connection_is_not_SQLite():"},{"line_number":20,"context_line":"    \"\"\"SQLite is not recommended for production deployments."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    SQLite does not enforce type checking and has limited support for"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_b26d859b","side":"PARENT","line":19,"in_reply_to":"3a71b18c_3798871b","updated":"2016-12-08 19:23:18.000000000","message":"For most of the symptoms I read as what they are something we do not want. E.g:\n\nsymptom_debug_mode_is_enabled\nsymptom_caching_enabled_without_a_backend\nsymptom_comma_in_SAML_public_certificate_path\nsymptom_password_regular_expression_description_not_set\n\nsymptom_database_connection_is_not_SQLite is something we do want, so not in conformity with the others. This is my reasoning, maybe you see it differently.","commit_id":"3f850d5d00de41b3ec90772fd67bda26a3c7d951"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"326c096fa12bbe97b2823e4ccf666a9bde3028b3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CONF \u003d keystone.conf.CONF"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def symptom_database_connection_is_not_SQLite():"},{"line_number":20,"context_line":"    \"\"\"SQLite is not recommended for production deployments."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    SQLite does not enforce type checking and has limited support for"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_adcc4a62","side":"PARENT","line":19,"in_reply_to":"3a71b18c_b26d859b","updated":"2016-12-08 19:56:29.000000000","message":"++","commit_id":"3f850d5d00de41b3ec90772fd67bda26a3c7d951"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"749fe75a85fcce457afc96ee384b513b42686644","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CONF \u003d keystone.conf.CONF"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def symptom_database_connection_is_not_SQLite():"},{"line_number":20,"context_line":"    \"\"\"SQLite is not recommended for production deployments."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    SQLite does not enforce type checking and has limited support for"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_f2a8dd79","side":"PARENT","line":19,"in_reply_to":"3a71b18c_b26d859b","updated":"2016-12-08 19:27:22.000000000","message":"Ah - I suppose that makes sense, too. That works for me. In either case the doc string should clear up any confusion.","commit_id":"3f850d5d00de41b3ec90772fd67bda26a3c7d951"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"326c096fa12bbe97b2823e4ccf666a9bde3028b3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"CONF \u003d keystone.conf.CONF"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def symptom_database_connection_is_not_SQLite():"},{"line_number":20,"context_line":"    \"\"\"SQLite is not recommended for production deployments."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    SQLite does not enforce type checking and has limited support for"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_8dd14efe","side":"PARENT","line":19,"in_reply_to":"3a71b18c_f2a8dd79","updated":"2016-12-08 19:56:29.000000000","message":"As Samuel mentioned, the method name was changed as well to follow the convention that the rest of them do. i.e. have a descriptive method name that says what the problem is.","commit_id":"3f850d5d00de41b3ec90772fd67bda26a3c7d951"}],"keystone/tests/unit/test_cli.py":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"5fdfc87ba75344500937661b315a0cb71fac95af","unresolved":false,"context_lines":[{"line_number":768,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        # No Symptom Detected: Database connection is sqlite and debug enabled"},{"line_number":771,"context_line":"        self.config_fixture.config(group\u003d\u0027database\u0027, connection\u003d\u0027sqlite\u0027)"},{"line_number":772,"context_line":"        self.config_fixture.config(debug\u003dTrue)"},{"line_number":773,"context_line":"        self.assertFalse("},{"line_number":774,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_3a0c803a","line":771,"range":{"start_line":771,"start_character":8,"end_line":771,"end_character":73},"updated":"2016-12-06 04:56:11.000000000","message":"I\u0027m not sure if this line is needed, but it does read better for the tests.","commit_id":"3483ba7543d17acfe797217f9df6ae8a72c8265d"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"82b23fe5c6b4a86ce1c383355f8834191ab1e792","unresolved":false,"context_lines":[{"line_number":768,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        # No Symptom Detected: Database connection is sqlite and debug enabled"},{"line_number":771,"context_line":"        self.config_fixture.config(group\u003d\u0027database\u0027, connection\u003d\u0027sqlite\u0027)"},{"line_number":772,"context_line":"        self.config_fixture.config(debug\u003dTrue)"},{"line_number":773,"context_line":"        self.assertFalse("},{"line_number":774,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_9a0114b2","line":771,"range":{"start_line":771,"start_character":8,"end_line":771,"end_character":73},"in_reply_to":"3a71b18c_3a0c803a","updated":"2016-12-06 05:07:47.000000000","message":"i agree, i prefer being more verbose for these tests rather than having to re-read the previous check","commit_id":"3483ba7543d17acfe797217f9df6ae8a72c8265d"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"4c4722c1c920a32ee800996d001f54fe08d360e5","unresolved":false,"context_lines":[{"line_number":768,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        # No Symptom Detected: Database connection is sqlite and debug enabled"},{"line_number":771,"context_line":"        self.config_fixture.config(group\u003d\u0027database\u0027, connection\u003d\u0027sqlite\u0027)"},{"line_number":772,"context_line":"        self.config_fixture.config(debug\u003dTrue)"},{"line_number":773,"context_line":"        self.assertFalse("},{"line_number":774,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_07767d6f","line":771,"range":{"start_line":771,"start_character":8,"end_line":771,"end_character":73},"in_reply_to":"3a71b18c_9a0114b2","updated":"2016-12-06 12:30:49.000000000","message":"+1","commit_id":"3483ba7543d17acfe797217f9df6ae8a72c8265d"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"82b23fe5c6b4a86ce1c383355f8834191ab1e792","unresolved":false,"context_lines":[{"line_number":779,"context_line":"        self.assertFalse("},{"line_number":780,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"        # No Symptom Detected: Database connection is MySQL and debug enabled"},{"line_number":783,"context_line":"        self.config_fixture.config(group\u003d\u0027database\u0027, connection\u003d\u0027MySQL\u0027)"},{"line_number":784,"context_line":"        self.config_fixture.config(debug\u003dTrue)"},{"line_number":785,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_3a29e037","line":782,"range":{"start_line":782,"start_character":64,"end_line":782,"end_character":77},"updated":"2016-12-06 05:07:47.000000000","message":"hmm, i would have thought that having debug enabled would be a symptom.","commit_id":"3483ba7543d17acfe797217f9df6ae8a72c8265d"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"c1bf6ac42175e9b0d1040e058f496fb189538b5b","unresolved":false,"context_lines":[{"line_number":779,"context_line":"        self.assertFalse("},{"line_number":780,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"        # No Symptom Detected: Database connection is MySQL and debug enabled"},{"line_number":783,"context_line":"        self.config_fixture.config(group\u003d\u0027database\u0027, connection\u003d\u0027MySQL\u0027)"},{"line_number":784,"context_line":"        self.config_fixture.config(debug\u003dTrue)"},{"line_number":785,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_da89cc27","line":782,"range":{"start_line":782,"start_character":64,"end_line":782,"end_character":77},"in_reply_to":"3a71b18c_3a29e037","updated":"2016-12-06 05:20:48.000000000","message":"It kinda looks like it was supposed to be a symptom?\n\nhttps://github.com/openstack/keystone/blob/master/keystone/cmd/doctor/database.py\n\nIf it is supposed to be, the logic there might need to be changed.","commit_id":"3483ba7543d17acfe797217f9df6ae8a72c8265d"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"47576481c6148926dd3f69cb557f7cd62597502d","unresolved":false,"context_lines":[{"line_number":779,"context_line":"        self.assertFalse("},{"line_number":780,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"        # No Symptom Detected: Database connection is MySQL and debug enabled"},{"line_number":783,"context_line":"        self.config_fixture.config(group\u003d\u0027database\u0027, connection\u003d\u0027MySQL\u0027)"},{"line_number":784,"context_line":"        self.config_fixture.config(debug\u003dTrue)"},{"line_number":785,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_95e56539","line":782,"range":{"start_line":782,"start_character":64,"end_line":782,"end_character":77},"in_reply_to":"3a71b18c_da89cc27","updated":"2016-12-06 05:56:19.000000000","message":"The way the symptom is currently written in the link you provided only raises a symptom if the user has their database connection set to sqlite and debug is enabled. In any other case, it will not raise the symptom. Due to\n\"and not CONF.debug\"","commit_id":"3483ba7543d17acfe797217f9df6ae8a72c8265d"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"5fdfc87ba75344500937661b315a0cb71fac95af","unresolved":false,"context_lines":[{"line_number":780,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"        # No Symptom Detected: Database connection is MySQL and debug enabled"},{"line_number":783,"context_line":"        self.config_fixture.config(group\u003d\u0027database\u0027, connection\u003d\u0027MySQL\u0027)"},{"line_number":784,"context_line":"        self.config_fixture.config(debug\u003dTrue)"},{"line_number":785,"context_line":"        self.assertFalse("},{"line_number":786,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_3a5ac02a","line":783,"range":{"start_line":783,"start_character":8,"end_line":783,"end_character":72},"updated":"2016-12-06 04:56:11.000000000","message":"Same as above.","commit_id":"3483ba7543d17acfe797217f9df6ae8a72c8265d"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"e5469d6e952ecd7200684c2e52150d791ffdf2af","unresolved":false,"context_lines":[{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def test_symptom_database_connection_is_not_SQLite(self):"},{"line_number":765,"context_line":"        # Symptom Detected: Database connection is sqlite and debug is disabled"},{"line_number":766,"context_line":"        self.config_fixture.config(group\u003d\u0027database\u0027, connection\u003d\u0027sqlite\u0027)"},{"line_number":767,"context_line":"        self.config_fixture.config(debug\u003dFalse)"},{"line_number":768,"context_line":"        self.assertTrue("},{"line_number":769,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_e4dfa6d3","line":766,"updated":"2016-12-06 21:32:01.000000000","message":"The value of the [database] connection option being tested here isn\u0027t realistic at all (oslo.db would choke on these values). Instead, realistic examples of the connection variable would be like:\n\n  postgresql+psycopg2://scott:tiger@localhost/mydatabase\n  mysql+mysqlconnector://scott:tiger@localhost/foo\n  sqlite:///foo.db\n  sqlite:///:memory:\n\nSource: http://docs.sqlalchemy.org/en/latest/core/engines.html\n\nI think these tests should be written against somewhat realistic examples.","commit_id":"53c3020cbf9af5d899b209b2719c975b7f6ce419"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"05acd14f57bed2ae39765cdaeebc812372ece6b0","unresolved":false,"context_lines":[{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    def test_symptom_database_connection_is_not_SQLite(self):"},{"line_number":765,"context_line":"        # Symptom Detected: Database connection is sqlite and debug is disabled"},{"line_number":766,"context_line":"        self.config_fixture.config(group\u003d\u0027database\u0027, connection\u003d\u0027sqlite\u0027)"},{"line_number":767,"context_line":"        self.config_fixture.config(debug\u003dFalse)"},{"line_number":768,"context_line":"        self.assertTrue("},{"line_number":769,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_3f0b677e","line":766,"in_reply_to":"3a71b18c_e4dfa6d3","updated":"2016-12-06 21:52:56.000000000","message":"Done","commit_id":"53c3020cbf9af5d899b209b2719c975b7f6ce419"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"531314e3905c437df9ad2e3d52d791b17ed1046b","unresolved":false,"context_lines":[{"line_number":784,"context_line":"        self.config_fixture.config(group\u003d\u0027database\u0027, connection\u003d\u0027MySQL\u0027)"},{"line_number":785,"context_line":"        self.config_fixture.config(debug\u003dTrue)"},{"line_number":786,"context_line":"        self.assertFalse("},{"line_number":787,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"class FederationDoctorTests(unit.TestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_963f08b3","line":787,"updated":"2016-12-06 20:15:04.000000000","message":"I like it because it tests all the combinations between sqlite/non-sqlite connection strings and debug/not-debug","commit_id":"53c3020cbf9af5d899b209b2719c975b7f6ce419"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"e448254fcd6d9dadc7948ebf4c24a1aac135aad2","unresolved":false,"context_lines":[{"line_number":773,"context_line":"        # No Symptom Detected: Database connection is sqlite and debug enabled"},{"line_number":774,"context_line":"        self.config_fixture.config("},{"line_number":775,"context_line":"            group\u003d\u0027database\u0027,"},{"line_number":776,"context_line":"            connection\u003d\u0027sqlite+sqlitedr://admin:secret@localhost:1234/mydb\u0027)"},{"line_number":777,"context_line":"        self.config_fixture.config(debug\u003dTrue)"},{"line_number":778,"context_line":"        self.assertFalse("},{"line_number":779,"context_line":"            doc_database.symptom_database_connection_is_not_SQLite())"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_d7a337b0","line":776,"updated":"2016-12-06 23:13:32.000000000","message":"I\u0027m not aware that sqlite supports users, passwords, network access, or multiple databases... nor is there a Python sqlite driver called sqlitedr :)","commit_id":"f32f731e85779f4acdab8d25f74364522dd5f728"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5b4e28d71409ff6f267375321ed1cdb71c7d3717","unresolved":false,"context_lines":[{"line_number":753,"context_line":""},{"line_number":754,"context_line":"class DatabaseDoctorTests(unit.TestCase):"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    def test_symptom_database_connection_is_not_SQLite(self):"},{"line_number":757,"context_line":"        # Symptom Detected: Database connection is sqlited"},{"line_number":758,"context_line":"        self.config_fixture.config("},{"line_number":759,"context_line":"            group\u003d\u0027database\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_179b8bca","line":756,"updated":"2016-12-08 18:45:29.000000000","message":"This name is slightly misleading depending on how you read it. The way I initially read it came across to me as \"ensure that the database connection string *isn\u0027t* SQLite\", but in face we\u0027re doing both.\n\nMaybe we change the word to say that a symptom will be raised if SQLite is detected during a doctor run?\n\n  def test_symptom_is_raised_if_database_connection_is_SQLite(self):\n     ...\n\nor \n\n  def test_symptom_is_only_raised_when_database_connection_is_SQLite(self):","commit_id":"3a40e5cb78520bb46ec2beda20662c32fc88e4f9"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"921bbb5112eb280c29db4f743a354ce91c696f44","unresolved":false,"context_lines":[{"line_number":753,"context_line":""},{"line_number":754,"context_line":"class DatabaseDoctorTests(unit.TestCase):"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    def test_symptom_database_connection_is_not_SQLite(self):"},{"line_number":757,"context_line":"        # Symptom Detected: Database connection is sqlited"},{"line_number":758,"context_line":"        self.config_fixture.config("},{"line_number":759,"context_line":"            group\u003d\u0027database\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_0d129eb4","line":756,"in_reply_to":"3a71b18c_179b8bca","updated":"2016-12-08 20:00:18.000000000","message":"Done","commit_id":"3a40e5cb78520bb46ec2beda20662c32fc88e4f9"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"73c48daf02a0ad5c58a2082f2f48e31953908afc","unresolved":false,"context_lines":[{"line_number":753,"context_line":""},{"line_number":754,"context_line":"class DatabaseDoctorTests(unit.TestCase):"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    def test_symptom_database_connection_is_not_SQLite(self):"},{"line_number":757,"context_line":"        # Symptom Detected: Database connection is sqlited"},{"line_number":758,"context_line":"        self.config_fixture.config("},{"line_number":759,"context_line":"            group\u003d\u0027database\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a71b18c_37b967cc","line":756,"in_reply_to":"3a71b18c_179b8bca","updated":"2016-12-08 18:56:55.000000000","message":"Yeah, this was mentioned by Samuel in my debug patch that we should have changed the symptom name as well and I agreed with him, but the patch merged before I saw it. In addition to the unit tests, I can change the name in this patch and update the commit message as well","commit_id":"3a40e5cb78520bb46ec2beda20662c32fc88e4f9"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b25872dfe72a2155a8dfdf40348651e469cafe7a","unresolved":false,"context_lines":[{"line_number":753,"context_line":""},{"line_number":754,"context_line":"class DatabaseDoctorTests(unit.TestCase):"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    def test_symptom_database_connection_is_SQLite(self):"},{"line_number":757,"context_line":"        # Symptom Detected: Database connection is sqlited"},{"line_number":758,"context_line":"        self.config_fixture.config("},{"line_number":759,"context_line":"            group\u003d\u0027database\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_97b07b8d","line":756,"updated":"2016-12-08 19:09:22.000000000","message":"I kind of like the convention where the unit test name is as descriptive as possible. Where you include what you\u0027re testing, the circumstance, and the desired output. That way when other people read the title of a test, or see it scroll by in their test output, they get a solid idea of exactly what is being tested.\n\nThis almost reads like we *want* SQLite to be the database connection.","commit_id":"d1d413d6550b32a2b82086136f7166b4b76529bc"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"320add8bc013e2e46ca89bc95e31ed4d866f8a48","unresolved":false,"context_lines":[{"line_number":754,"context_line":"class DatabaseDoctorTests(unit.TestCase):"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    def test_symptom_database_connection_is_SQLite(self):"},{"line_number":757,"context_line":"        # Symptom Detected: Database connection is sqlited"},{"line_number":758,"context_line":"        self.config_fixture.config("},{"line_number":759,"context_line":"            group\u003d\u0027database\u0027,"},{"line_number":760,"context_line":"            connection\u003d\u0027sqlite:///mydb\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_d7fcb340","line":757,"range":{"start_line":757,"start_character":51,"end_line":757,"end_character":58},"updated":"2016-12-08 19:23:18.000000000","message":"(typo) SQLite","commit_id":"d1d413d6550b32a2b82086136f7166b4b76529bc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b25872dfe72a2155a8dfdf40348651e469cafe7a","unresolved":false,"context_lines":[{"line_number":754,"context_line":"class DatabaseDoctorTests(unit.TestCase):"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    def test_symptom_database_connection_is_SQLite(self):"},{"line_number":757,"context_line":"        # Symptom Detected: Database connection is sqlited"},{"line_number":758,"context_line":"        self.config_fixture.config("},{"line_number":759,"context_line":"            group\u003d\u0027database\u0027,"},{"line_number":760,"context_line":"            connection\u003d\u0027sqlite:///mydb\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a71b18c_17c70b13","line":757,"updated":"2016-12-08 19:09:22.000000000","message":"sqlited*?","commit_id":"d1d413d6550b32a2b82086136f7166b4b76529bc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"93fa058cc30868f268b344b37975c229001f3a90","unresolved":false,"context_lines":[{"line_number":753,"context_line":""},{"line_number":754,"context_line":"class DatabaseDoctorTests(unit.TestCase):"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    def test_symptom_is_raised_if_database_connection_is_SQLite(self):"},{"line_number":757,"context_line":"        # Symptom Detected: Database connection is sqlite"},{"line_number":758,"context_line":"        self.config_fixture.config("},{"line_number":759,"context_line":"            group\u003d\u0027database\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a71b18c_aee8c117","line":756,"updated":"2016-12-08 20:40:54.000000000","message":"Works for me - we could add a follow on patch to break these two into their own tests. The name is nice and descriptive, but more-so for the first assertion. We could apply the same naming pattern to the second assertion in it\u0027s own test.","commit_id":"aa97a9c0b1081216b649dbe741adf02c38c29bec"}]}