)]}'
{"keystone/tests/unit/test_cli.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"4b3976a44b8848b6ed777e73701b009ad16525f1","unresolved":false,"context_lines":[{"line_number":760,"context_line":"                                   backend\u003d\u0027dogpile.cache.memory\u0027)"},{"line_number":761,"context_line":"        self.assertFalse(caching.symptom_caching_enabled_without_a_backend())"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    def test_symptom_comma_in_SAML_public_certificate_path(self):"},{"line_number":764,"context_line":"        # Success Case: There is a comma in path to public certification file"},{"line_number":765,"context_line":"        self.config_fixture.config(group\u003d\u0027saml\u0027, certfile\u003d\u0027file,cert.pem\u0027)"},{"line_number":766,"context_line":"        self.assertTrue("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_236aadb3","line":763,"range":{"start_line":763,"start_character":4,"end_line":763,"end_character":65},"updated":"2016-12-05 20:30:10.000000000","message":"these can be under their own class if you want\n\n  FederationDoctorTests","commit_id":"6df21fe1b7dad92c872b1fa66ebf8faafefde71b"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"480839126d33bcc2c1fd84564c5f67a382c5c39a","unresolved":false,"context_lines":[{"line_number":760,"context_line":"                                   backend\u003d\u0027dogpile.cache.memory\u0027)"},{"line_number":761,"context_line":"        self.assertFalse(caching.symptom_caching_enabled_without_a_backend())"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    def test_symptom_comma_in_SAML_public_certificate_path(self):"},{"line_number":764,"context_line":"        # Success Case: There is a comma in path to public certification file"},{"line_number":765,"context_line":"        self.config_fixture.config(group\u003d\u0027saml\u0027, certfile\u003d\u0027file,cert.pem\u0027)"},{"line_number":766,"context_line":"        self.assertTrue("}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_99b770d7","line":763,"range":{"start_line":763,"start_character":4,"end_line":763,"end_character":65},"in_reply_to":"3a71b18c_236aadb3","updated":"2016-12-05 21:34:37.000000000","message":"Done","commit_id":"6df21fe1b7dad92c872b1fa66ebf8faafefde71b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"7461fb15e4bb4d6b9857f58dc6183b607599254c","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        self.assertFalse(caching.symptom_caching_enabled_without_a_backend())"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    def test_symptom_comma_in_SAML_public_certificate_path(self):"},{"line_number":764,"context_line":"        # Success Case: There is a comma in path to public certification file"},{"line_number":765,"context_line":"        self.config_fixture.config(group\u003d\u0027saml\u0027, certfile\u003d\u0027file,cert.pem\u0027)"},{"line_number":766,"context_line":"        self.assertTrue("},{"line_number":767,"context_line":"            federation.symptom_comma_in_SAML_public_certificate_path())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_a8377cfd","line":764,"range":{"start_line":764,"start_character":10,"end_line":764,"end_character":77},"updated":"2016-12-05 20:27:40.000000000","message":"eh? the comment in the code says:\n\nkeystone cannot include a comma in the path to the public certificate file.\n\nhttps://github.com/openstack/keystone/blob/master/keystone/cmd/doctor/federation.py#L23-L24\n\nshouldn\u0027t this fail?","commit_id":"6df21fe1b7dad92c872b1fa66ebf8faafefde71b"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b796f9cec710ea44d1259fabedc1db052168bed8","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        self.assertFalse(caching.symptom_caching_enabled_without_a_backend())"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    def test_symptom_comma_in_SAML_public_certificate_path(self):"},{"line_number":764,"context_line":"        # Success Case: There is a comma in path to public certification file"},{"line_number":765,"context_line":"        self.config_fixture.config(group\u003d\u0027saml\u0027, certfile\u003d\u0027file,cert.pem\u0027)"},{"line_number":766,"context_line":"        self.assertTrue("},{"line_number":767,"context_line":"            federation.symptom_comma_in_SAML_public_certificate_path())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_9eb756d7","line":764,"range":{"start_line":764,"start_character":10,"end_line":764,"end_character":77},"in_reply_to":"3a71b18c_035bf1f6","updated":"2016-12-05 21:06:06.000000000","message":"Let\u0027s change the wording then. instead of \"Success Case\", lets go with \"Symptom Detected\"? Failure cases can be \"No Symptom Detected\"","commit_id":"6df21fe1b7dad92c872b1fa66ebf8faafefde71b"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"21e6382d3dcf9e10dbeebf4d5f637226ffb51329","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        self.assertFalse(caching.symptom_caching_enabled_without_a_backend())"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    def test_symptom_comma_in_SAML_public_certificate_path(self):"},{"line_number":764,"context_line":"        # Success Case: There is a comma in path to public certification file"},{"line_number":765,"context_line":"        self.config_fixture.config(group\u003d\u0027saml\u0027, certfile\u003d\u0027file,cert.pem\u0027)"},{"line_number":766,"context_line":"        self.assertTrue("},{"line_number":767,"context_line":"            federation.symptom_comma_in_SAML_public_certificate_path())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_394adc26","line":764,"range":{"start_line":764,"start_character":10,"end_line":764,"end_character":77},"in_reply_to":"3a71b18c_9eb756d7","updated":"2016-12-05 21:26:30.000000000","message":"That sounds good to me, I will update the other doctor tests currently pending review as well to follow this","commit_id":"6df21fe1b7dad92c872b1fa66ebf8faafefde71b"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"3bb26ed31bf36ccc83a75f59357317d1edfea736","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        self.assertFalse(caching.symptom_caching_enabled_without_a_backend())"},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"    def test_symptom_comma_in_SAML_public_certificate_path(self):"},{"line_number":764,"context_line":"        # Success Case: There is a comma in path to public certification file"},{"line_number":765,"context_line":"        self.config_fixture.config(group\u003d\u0027saml\u0027, certfile\u003d\u0027file,cert.pem\u0027)"},{"line_number":766,"context_line":"        self.assertTrue("},{"line_number":767,"context_line":"            federation.symptom_comma_in_SAML_public_certificate_path())"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_035bf1f6","line":764,"range":{"start_line":764,"start_character":10,"end_line":764,"end_character":77},"in_reply_to":"3a71b18c_a8377cfd","updated":"2016-12-05 20:34:04.000000000","message":"The Success Cases are a little misleading for all tests it seems. Success really means that it passed true and that the symptom was raised which really means failed. I can change this, but the caching comments that get merged would need to be changed to since this also applies to them","commit_id":"6df21fe1b7dad92c872b1fa66ebf8faafefde71b"}]}