)]}'
{"keystone/cmd/doctor/security_compliance.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"be92692e8ff3a81e0b0ec473ca69dc3dca780f6a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"CONF \u003d keystone.conf.CONF"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def symptom_minimum_password_age_should_be_less_than_password_expires_days():"},{"line_number":22,"context_line":"    \"\"\"Minimum password age should be less than the password expires days."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    If the minimum password age is greater than or equal to the password"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_14e965e6","side":"PARENT","line":21,"updated":"2016-12-05 21:56:05.000000000","message":"The only thing we\u0027ll have to be careful with here is making sure the shorter name still makes sense from a user perspective. This is because we use the actual method name as output for the user [0]. So not only is it good practice to have sane method names, it\u0027s doubly true here because users depend on them in order to make sense of what ``doctor`` is doing.\n\nOmitting ``minimum`` from the method name all together wouldn\u0027t be bad since we elaborate on it in the doc string:\n\n  def symptom_password_age_should_be_less_then_password_expiration():\n\nMaybe that\u0027s a start?\n\n[0] https://github.com/openstack/keystone/blob/1c60b1539cf63bba79711e237df496dfa094b2c5/keystone/cmd/doctor/__init__.py#L52","commit_id":"1c60b1539cf63bba79711e237df496dfa094b2c5"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"8f1aa0afb3fe34da7ba46c24548e437a8d54c17c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"CONF \u003d keystone.conf.CONF"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def symptom_minimum_password_age_should_be_less_than_password_expires_days():"},{"line_number":22,"context_line":"    \"\"\"Minimum password age should be less than the password expires days."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    If the minimum password age is greater than or equal to the password"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_7a41a3a8","side":"PARENT","line":21,"in_reply_to":"3a71b18c_14e965e6","updated":"2016-12-05 22:32:49.000000000","message":"Done","commit_id":"1c60b1539cf63bba79711e237df496dfa094b2c5"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8d46f4f7d5bc071e98606b18aff4d2727dea2714","unresolved":false,"context_lines":[{"line_number":18,"context_line":"CONF \u003d keystone.conf.CONF"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def symptom_password_age_should_be_less_then_password_expiration():"},{"line_number":22,"context_line":"    \"\"\"Minimum password age should be less than the password expires days."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    If the minimum password age is greater than or equal to the password"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_b78b4967","line":21,"range":{"start_line":21,"start_character":40,"end_line":21,"end_character":44},"updated":"2016-12-06 04:18:47.000000000","message":"than is the correct choice here","commit_id":"ec6f55c134be8e5703c18a0b4fc444c09ee414bd"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"3dc19a51f440179b733cbd69ef73e4b3fe389c26","unresolved":false,"context_lines":[{"line_number":18,"context_line":"CONF \u003d keystone.conf.CONF"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def symptom_password_age_should_be_less_then_password_expiration():"},{"line_number":22,"context_line":"    \"\"\"Minimum password age should be less than the password expires days."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    If the minimum password age is greater than or equal to the password"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_d7644523","line":21,"range":{"start_line":21,"start_character":40,"end_line":21,"end_character":44},"in_reply_to":"3a71b18c_b78b4967","updated":"2016-12-06 04:50:05.000000000","message":"Ah, good point:\n\nhttp://writingexplained.org/then-vs-than-difference","commit_id":"ec6f55c134be8e5703c18a0b4fc444c09ee414bd"}]}