)]}'
{"keystone/tests/unit/test_v3_assignment.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c10ada5b211ff119f6ea927388a3945f691fc724","unresolved":false,"context_lines":[{"line_number":1727,"context_line":"                         assignment_names[\u0027links\u0027][\u0027assignment\u0027])"},{"line_number":1728,"context_line":"        self.put(assignment[\u0027links\u0027][\u0027assignment\u0027])"},{"line_number":1729,"context_line":""},{"line_number":1730,"context_line":"        collection_url \u003d \u0027/role_assignments?user.id\u003d\u0027 + user[\u0027id\u0027]"},{"line_number":1731,"context_line":"        result \u003d self.get(collection_url)"},{"line_number":1732,"context_line":"        self.assertValidRoleAssignmentListResponse("},{"line_number":1733,"context_line":"            result, expected_length\u003d1, resource_url\u003dcollection_url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_9c1f1eb6","line":1730,"range":{"start_line":1730,"start_character":52,"end_line":1730,"end_character":66},"updated":"2016-12-07 03:49:49.000000000","message":"i\u0027d prefer we use the substitution notation:\n\n  user.id\u003d%s\u0027 % (user[\u0027id\u0027])","commit_id":"d1da8cadccc395731a8628d84ca2b758f2ca90f2"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"fd64c6445fb6fb1b2066385d55c07006d45881d3","unresolved":false,"context_lines":[{"line_number":1727,"context_line":"                         assignment_names[\u0027links\u0027][\u0027assignment\u0027])"},{"line_number":1728,"context_line":"        self.put(assignment[\u0027links\u0027][\u0027assignment\u0027])"},{"line_number":1729,"context_line":""},{"line_number":1730,"context_line":"        collection_url \u003d \u0027/role_assignments?user.id\u003d\u0027 + user[\u0027id\u0027]"},{"line_number":1731,"context_line":"        result \u003d self.get(collection_url)"},{"line_number":1732,"context_line":"        self.assertValidRoleAssignmentListResponse("},{"line_number":1733,"context_line":"            result, expected_length\u003d1, resource_url\u003dcollection_url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_7745eab1","line":1730,"range":{"start_line":1730,"start_character":52,"end_line":1730,"end_character":66},"in_reply_to":"3a71b18c_9c1f1eb6","updated":"2016-12-07 12:25:39.000000000","message":"Done","commit_id":"d1da8cadccc395731a8628d84ca2b758f2ca90f2"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c10ada5b211ff119f6ea927388a3945f691fc724","unresolved":false,"context_lines":[{"line_number":1728,"context_line":"        self.put(assignment[\u0027links\u0027][\u0027assignment\u0027])"},{"line_number":1729,"context_line":""},{"line_number":1730,"context_line":"        collection_url \u003d \u0027/role_assignments?user.id\u003d\u0027 + user[\u0027id\u0027]"},{"line_number":1731,"context_line":"        result \u003d self.get(collection_url)"},{"line_number":1732,"context_line":"        self.assertValidRoleAssignmentListResponse("},{"line_number":1733,"context_line":"            result, expected_length\u003d1, resource_url\u003dcollection_url)"},{"line_number":1734,"context_line":"        self.assertRoleAssignmentInListResponse(result, assignment)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_dc62763d","line":1731,"range":{"start_line":1731,"start_character":8,"end_line":1731,"end_character":14},"updated":"2016-12-07 03:49:49.000000000","message":"we probably want to assert that the inherited value is set as expected","commit_id":"d1da8cadccc395731a8628d84ca2b758f2ca90f2"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"fd64c6445fb6fb1b2066385d55c07006d45881d3","unresolved":false,"context_lines":[{"line_number":1728,"context_line":"        self.put(assignment[\u0027links\u0027][\u0027assignment\u0027])"},{"line_number":1729,"context_line":""},{"line_number":1730,"context_line":"        collection_url \u003d \u0027/role_assignments?user.id\u003d\u0027 + user[\u0027id\u0027]"},{"line_number":1731,"context_line":"        result \u003d self.get(collection_url)"},{"line_number":1732,"context_line":"        self.assertValidRoleAssignmentListResponse("},{"line_number":1733,"context_line":"            result, expected_length\u003d1, resource_url\u003dcollection_url)"},{"line_number":1734,"context_line":"        self.assertRoleAssignmentInListResponse(result, assignment)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_37229202","line":1731,"range":{"start_line":1731,"start_character":8,"end_line":1731,"end_character":14},"in_reply_to":"3a71b18c_dc62763d","updated":"2016-12-07 12:25:39.000000000","message":"Added these checks on the expected entities (assignment and assignment_names)","commit_id":"d1da8cadccc395731a8628d84ca2b758f2ca90f2"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c10ada5b211ff119f6ea927388a3945f691fc724","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"        self.assertRoleAssignmentInListResponse(result, assignment)"},{"line_number":1735,"context_line":""},{"line_number":1736,"context_line":"        collection_url \u003d (\u0027/role_assignments?include_names\u0026\u0027"},{"line_number":1737,"context_line":"                          \u0027user.id\u003d\u0027 + user[\u0027id\u0027])"},{"line_number":1738,"context_line":"        result \u003d self.get(collection_url)"},{"line_number":1739,"context_line":"        self.assertValidRoleAssignmentListResponse("},{"line_number":1740,"context_line":"            result, expected_length\u003d1, resource_url\u003dcollection_url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_bc1a1ac4","line":1737,"range":{"start_line":1737,"start_character":35,"end_line":1737,"end_character":50},"updated":"2016-12-07 03:49:49.000000000","message":"same","commit_id":"d1da8cadccc395731a8628d84ca2b758f2ca90f2"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"fd64c6445fb6fb1b2066385d55c07006d45881d3","unresolved":false,"context_lines":[{"line_number":1734,"context_line":"        self.assertRoleAssignmentInListResponse(result, assignment)"},{"line_number":1735,"context_line":""},{"line_number":1736,"context_line":"        collection_url \u003d (\u0027/role_assignments?include_names\u0026\u0027"},{"line_number":1737,"context_line":"                          \u0027user.id\u003d\u0027 + user[\u0027id\u0027])"},{"line_number":1738,"context_line":"        result \u003d self.get(collection_url)"},{"line_number":1739,"context_line":"        self.assertValidRoleAssignmentListResponse("},{"line_number":1740,"context_line":"            result, expected_length\u003d1, resource_url\u003dcollection_url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_571f0eb7","line":1737,"range":{"start_line":1737,"start_character":35,"end_line":1737,"end_character":50},"in_reply_to":"3a71b18c_bc1a1ac4","updated":"2016-12-07 12:25:39.000000000","message":"Done","commit_id":"d1da8cadccc395731a8628d84ca2b758f2ca90f2"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"c10ada5b211ff119f6ea927388a3945f691fc724","unresolved":false,"context_lines":[{"line_number":1735,"context_line":""},{"line_number":1736,"context_line":"        collection_url \u003d (\u0027/role_assignments?include_names\u0026\u0027"},{"line_number":1737,"context_line":"                          \u0027user.id\u003d\u0027 + user[\u0027id\u0027])"},{"line_number":1738,"context_line":"        result \u003d self.get(collection_url)"},{"line_number":1739,"context_line":"        self.assertValidRoleAssignmentListResponse("},{"line_number":1740,"context_line":"            result, expected_length\u003d1, resource_url\u003dcollection_url)"},{"line_number":1741,"context_line":"        self.assertRoleAssignmentInListResponse(result, assignment_names)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_fc657244","line":1738,"range":{"start_line":1738,"start_character":8,"end_line":1738,"end_character":14},"updated":"2016-12-07 03:49:49.000000000","message":"we probably want to assert that the inherited value is set as expected","commit_id":"d1da8cadccc395731a8628d84ca2b758f2ca90f2"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"fd64c6445fb6fb1b2066385d55c07006d45881d3","unresolved":false,"context_lines":[{"line_number":1735,"context_line":""},{"line_number":1736,"context_line":"        collection_url \u003d (\u0027/role_assignments?include_names\u0026\u0027"},{"line_number":1737,"context_line":"                          \u0027user.id\u003d\u0027 + user[\u0027id\u0027])"},{"line_number":1738,"context_line":"        result \u003d self.get(collection_url)"},{"line_number":1739,"context_line":"        self.assertValidRoleAssignmentListResponse("},{"line_number":1740,"context_line":"            result, expected_length\u003d1, resource_url\u003dcollection_url)"},{"line_number":1741,"context_line":"        self.assertRoleAssignmentInListResponse(result, assignment_names)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_9777e607","line":1738,"range":{"start_line":1738,"start_character":8,"end_line":1738,"end_character":14},"in_reply_to":"3a71b18c_fc657244","updated":"2016-12-07 12:25:39.000000000","message":"Done","commit_id":"d1da8cadccc395731a8628d84ca2b758f2ca90f2"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5c968ed51c83d665975812606380d5b9f6122af6","unresolved":false,"context_lines":[{"line_number":1754,"context_line":"            result, expected_length\u003d1, resource_url\u003dcollection_url)"},{"line_number":1755,"context_line":"        self.assertRoleAssignmentInListResponse(result, assignment)"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"        collection_url \u003d (\u0027/role_assignments?include_names\u0026\u0027"},{"line_number":1758,"context_line":"                          \u0027user.id\u003d%(user_id)s\u0027 % {\u0027user_id\u0027: user[\u0027id\u0027]})"},{"line_number":1759,"context_line":"        result \u003d self.get(collection_url)"},{"line_number":1760,"context_line":"        self.assertValidRoleAssignmentListResponse("},{"line_number":1761,"context_line":"            result, expected_length\u003d1, resource_url\u003dcollection_url)"},{"line_number":1762,"context_line":"        self.assertRoleAssignmentInListResponse(result, assignment_names)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_1d24d7c4","line":1759,"range":{"start_line":1757,"start_character":8,"end_line":1759,"end_character":41},"updated":"2016-12-07 13:19:12.000000000","message":"missing extra assertion here about inherited stuff","commit_id":"8fe390632587e158773e80233481ae244a4a3b3a"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"fe8075dbf5104f0f86b7a762f7bd7c80a52f1a63","unresolved":false,"context_lines":[{"line_number":1754,"context_line":"            result, expected_length\u003d1, resource_url\u003dcollection_url)"},{"line_number":1755,"context_line":"        self.assertRoleAssignmentInListResponse(result, assignment)"},{"line_number":1756,"context_line":""},{"line_number":1757,"context_line":"        collection_url \u003d (\u0027/role_assignments?include_names\u0026\u0027"},{"line_number":1758,"context_line":"                          \u0027user.id\u003d%(user_id)s\u0027 % {\u0027user_id\u0027: user[\u0027id\u0027]})"},{"line_number":1759,"context_line":"        result \u003d self.get(collection_url)"},{"line_number":1760,"context_line":"        self.assertValidRoleAssignmentListResponse("},{"line_number":1761,"context_line":"            result, expected_length\u003d1, resource_url\u003dcollection_url)"},{"line_number":1762,"context_line":"        self.assertRoleAssignmentInListResponse(result, assignment_names)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_a803a3bd","line":1759,"range":{"start_line":1757,"start_character":8,"end_line":1759,"end_character":41},"in_reply_to":"3a71b18c_1d24d7c4","updated":"2016-12-07 13:25:18.000000000","message":"We can ensure the inherited flag is present in the result since we call assertRoleAssignmentInListResponse(result, assignment_names) just below and assignment_names contains the inheritance flag (L1743-44)","commit_id":"8fe390632587e158773e80233481ae244a4a3b3a"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"949911c8c0b1bfd2c75cefcfbd6c6fbd9377f36d","unresolved":false,"context_lines":[{"line_number":1711,"context_line":""},{"line_number":1712,"context_line":"    @test_utils.wip(\u0027Blocked by bug #1625230\u0027)"},{"line_number":1713,"context_line":"    def test_list_inherited_role_assignments_include_names(self):"},{"line_number":1714,"context_line":"        \"\"\"Call ``GET /role_assignments?include_names``."},{"line_number":1715,"context_line":""},{"line_number":1716,"context_line":"        Test goal: ensure calling list role assignments including names"},{"line_number":1717,"context_line":"        honors the inherited role assignments flag."}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_71413239","line":1714,"range":{"start_line":1714,"start_character":40,"end_line":1714,"end_character":53},"updated":"2016-12-08 17:05:08.000000000","message":"nit: add the inherited_to query param","commit_id":"aa531a001a31b757fa12412bf0eb84e4c8d67bb0"}]}