)]}'
{"keystone/tests/unit/identity/backends/test_ldap_common.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"c4bef336854155a307c22beafc723cb51eb84863","unresolved":false,"context_lines":[{"line_number":283,"context_line":"class MultiURLTests(unit.TestCase):"},{"line_number":284,"context_line":"    \"\"\"Test for setting multiple LDAP URLs.\"\"\""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @mock.patch.object(common_ldap.KeystoneLDAPHandler, \u0027simple_bind_s\u0027)"},{"line_number":287,"context_line":"    def test_multiple_urls_with_comma_no_conn_pool(self, mock_ldap_bind):"},{"line_number":288,"context_line":"        urls \u003d \u0027ldap://localhost,ldap://backup.localhost\u0027"},{"line_number":289,"context_line":"        self.config_fixture.config(group\u003d\u0027ldap\u0027, url\u003durls, use_pool\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_49fe9139","line":286,"updated":"2016-12-07 14:30:32.000000000","message":"Why are these needed now ?","commit_id":"8116e923dcb26cccd71212837989e37dc0f876fe"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c5eabfd02f4995789b5a6e08228ebd4dc0b5dc69","unresolved":false,"context_lines":[{"line_number":283,"context_line":"class MultiURLTests(unit.TestCase):"},{"line_number":284,"context_line":"    \"\"\"Test for setting multiple LDAP URLs.\"\"\""},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    @mock.patch.object(common_ldap.KeystoneLDAPHandler, \u0027simple_bind_s\u0027)"},{"line_number":287,"context_line":"    def test_multiple_urls_with_comma_no_conn_pool(self, mock_ldap_bind):"},{"line_number":288,"context_line":"        urls \u003d \u0027ldap://localhost,ldap://backup.localhost\u0027"},{"line_number":289,"context_line":"        self.config_fixture.config(group\u003d\u0027ldap\u0027, url\u003durls, use_pool\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_1188a9c4","line":286,"in_reply_to":"3a71b18c_49fe9139","updated":"2016-12-11 20:24:27.000000000","message":"These are needed because now get_connection() always attempts a simple_bind_s(), which will fail with a network timeout error. We would have needed this before if we had set up the config fixture to use a username and password in the [ldap] section. I added a note about this to the commit message.","commit_id":"8116e923dcb26cccd71212837989e37dc0f876fe"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"c4bef336854155a307c22beafc723cb51eb84863","unresolved":false,"context_lines":[{"line_number":1409,"context_line":"        user_ref \u003d user_api.get(\u0027123456789\u0027)"},{"line_number":1410,"context_line":"        self.assertIs(True, user_ref[\u0027enabled\u0027])"},{"line_number":1411,"context_line":""},{"line_number":1412,"context_line":"    @mock.patch.object(common_ldap.KeystoneLDAPHandler, \u0027simple_bind_s\u0027)"},{"line_number":1413,"context_line":"    def test_user_api_get_connection_no_user_password(self, mocked_method):"},{"line_number":1414,"context_line":"        \"\"\"Don\u0027t bind in case the user and password are blank.\"\"\""},{"line_number":1415,"context_line":"        # Ensure the username/password are in-fact blank"},{"line_number":1416,"context_line":"        self.config_fixture.config(group\u003d\u0027ldap\u0027, user\u003dNone, password\u003dNone)"},{"line_number":1417,"context_line":"        user_api \u003d identity.backends.ldap.UserApi(CONF)"},{"line_number":1418,"context_line":"        user_api.get_connection(user\u003dNone, password\u003dNone)"},{"line_number":1419,"context_line":"        self.assertFalse(mocked_method.called,"},{"line_number":1420,"context_line":"                         msg\u003d\u0027`simple_bind_s` method was unexpectedly called\u0027)"},{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"    @mock.patch.object(common_ldap.KeystoneLDAPHandler, \u0027connect\u0027)"},{"line_number":1423,"context_line":"    def test_chase_referrals_off(self, mocked_fakeldap):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_a993a5ff","side":"PARENT","line":1420,"range":{"start_line":1412,"start_character":0,"end_line":1420,"end_character":78},"updated":"2016-12-07 14:30:32.000000000","message":"This needs a bug as the current behavior was per design","commit_id":"6e55733cf14cc97ae5dcae9490a15a6b9377b6f8"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"5c95cb44f13983935eefd9347b258195e55c3408","unresolved":false,"context_lines":[{"line_number":1411,"context_line":""},{"line_number":1412,"context_line":"    @mock.patch.object(common_ldap.KeystoneLDAPHandler, \u0027simple_bind_s\u0027)"},{"line_number":1413,"context_line":"    def test_user_api_get_connection_no_user_password(self, mocked_method):"},{"line_number":1414,"context_line":"        \"\"\"Don\u0027t bind in case the user and password are blank.\"\"\""},{"line_number":1415,"context_line":"        # Ensure the username/password are in-fact blank"},{"line_number":1416,"context_line":"        self.config_fixture.config(group\u003d\u0027ldap\u0027, user\u003dNone, password\u003dNone)"},{"line_number":1417,"context_line":"        user_api \u003d identity.backends.ldap.UserApi(CONF)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_69464850","side":"PARENT","line":1414,"range":{"start_line":1414,"start_character":11,"end_line":1414,"end_character":62},"updated":"2016-12-15 13:57:13.000000000","message":"We need to report a bug as the current behavior is per-design","commit_id":"6e55733cf14cc97ae5dcae9490a15a6b9377b6f8"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"dcbccc90d8b9a9400cc96b8d44d4e6fd49a080d0","unresolved":false,"context_lines":[{"line_number":1417,"context_line":"        user_api \u003d identity.backends.ldap.UserApi(CONF)"},{"line_number":1418,"context_line":"        user_api.get_connection(user\u003dNone, password\u003dNone)"},{"line_number":1419,"context_line":"        self.assertFalse(mocked_method.called,"},{"line_number":1420,"context_line":"                         msg\u003d\u0027`simple_bind_s` method was unexpectedly called\u0027)"},{"line_number":1421,"context_line":""},{"line_number":1422,"context_line":"    @mock.patch.object(common_ldap.KeystoneLDAPHandler, \u0027connect\u0027)"},{"line_number":1423,"context_line":"    def test_chase_referrals_off(self, mocked_fakeldap):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_4495f384","side":"PARENT","line":1420,"updated":"2016-12-15 14:14:13.000000000","message":"Also, instead of deleting, make sure simple_bind_s is called even if user/passwd are not provided","commit_id":"6e55733cf14cc97ae5dcae9490a15a6b9377b6f8"}]}