)]}'
{"keystone/assignment/core.py":[{"author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"change_message_id":"be6be05bf808d90f6a783b6101c42d2fe9b75278","unresolved":false,"context_lines":[{"line_number":948,"context_line":""},{"line_number":949,"context_line":"        for role_asgmt in role_assignments:"},{"line_number":950,"context_line":"            new_assign \u003d copy.deepcopy(role_asgmt)"},{"line_number":951,"context_line":"            for key, value in role_asgmt.items():"},{"line_number":952,"context_line":"                if key \u003d\u003d \u0027domain_id\u0027:"},{"line_number":953,"context_line":"                    _domain \u003d self.resource_api.get_domain(value)"},{"line_number":954,"context_line":"                    new_assign[\u0027domain_name\u0027] \u003d _domain[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a71b18c_d369ee8d","line":951,"range":{"start_line":951,"start_character":16,"end_line":951,"end_character":26},"updated":"2016-12-09 21:36:55.000000000","message":"nit: I feel these could have more descriptive names. Thoughts?","commit_id":"308db6aa2c641ac6641a200e9016a3d1ddbcc738"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"574df439b2de56da863c021abe5e42126f44646c","unresolved":false,"context_lines":[{"line_number":948,"context_line":""},{"line_number":949,"context_line":"        for role_asgmt in role_assignments:"},{"line_number":950,"context_line":"            new_assign \u003d copy.deepcopy(role_asgmt)"},{"line_number":951,"context_line":"            for key, value in role_asgmt.items():"},{"line_number":952,"context_line":"                if key \u003d\u003d \u0027domain_id\u0027:"},{"line_number":953,"context_line":"                    _domain \u003d self.resource_api.get_domain(value)"},{"line_number":954,"context_line":"                    new_assign[\u0027domain_name\u0027] \u003d _domain[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_be6d6706","line":951,"range":{"start_line":951,"start_character":16,"end_line":951,"end_character":26},"in_reply_to":"1a6eadb0_785e87ea","updated":"2016-12-13 14:50:02.000000000","message":"think key, value is really good here - the if statements below give a great view what is supposed to be both.","commit_id":"308db6aa2c641ac6641a200e9016a3d1ddbcc738"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"749be7aea5a5217af09fbfd27d2957186b22dcc6","unresolved":false,"context_lines":[{"line_number":948,"context_line":""},{"line_number":949,"context_line":"        for role_asgmt in role_assignments:"},{"line_number":950,"context_line":"            new_assign \u003d copy.deepcopy(role_asgmt)"},{"line_number":951,"context_line":"            for key, value in role_asgmt.items():"},{"line_number":952,"context_line":"                if key \u003d\u003d \u0027domain_id\u0027:"},{"line_number":953,"context_line":"                    _domain \u003d self.resource_api.get_domain(value)"},{"line_number":954,"context_line":"                    new_assign[\u0027domain_name\u0027] \u003d _domain[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_785e87ea","line":951,"range":{"start_line":951,"start_character":16,"end_line":951,"end_character":26},"in_reply_to":"3a71b18c_d369ee8d","updated":"2016-12-13 14:07:20.000000000","message":"I can\u0027t think of any descriptive name for these.\n\nThe keys can be role assingment\u0027s 1) role, 2) target (domain or project) or 3) actor (user or group). It\u0027s hard to name it as something that can represent well all those.\n\nDo you have a suggestion?","commit_id":"308db6aa2c641ac6641a200e9016a3d1ddbcc738"}]}