)]}'
{"keystone/common/sql/core.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"713ced60478d8d2ed339995ef6e2e2bf9112033e","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                for arg in params:"},{"line_number":442,"context_line":"                    if \u0027name\u0027 in arg:"},{"line_number":443,"context_line":"                        name \u003d arg[\u0027name\u0027]"},{"line_number":444,"context_line":"                    elif \u0027id\u0027 in arg:"},{"line_number":445,"context_line":"                        name \u003d arg[\u0027id\u0027]"},{"line_number":446,"context_line":"                    if \u0027domain_id\u0027 in arg:"},{"line_number":447,"context_line":"                        domain_id \u003d arg[\u0027domain_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_1fe0c495","line":444,"range":{"start_line":444,"start_character":20,"end_line":444,"end_character":24},"updated":"2016-12-11 02:43:03.000000000","message":"++ only use this if name is not available. might be worth making a note of this behaviour in a comment (or series of comments before the for loop)","commit_id":"a87cf908ac688a1d209195945e2c4bfa08286866"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f59d9989e5f15ad874381803130400204c245c17","unresolved":false,"context_lines":[{"line_number":442,"context_line":"                    if \u0027name\u0027 in arg:"},{"line_number":443,"context_line":"                        name \u003d arg[\u0027name\u0027]"},{"line_number":444,"context_line":"                    elif \u0027id\u0027 in arg:"},{"line_number":445,"context_line":"                        name \u003d arg[\u0027id\u0027]"},{"line_number":446,"context_line":"                    if \u0027domain_id\u0027 in arg:"},{"line_number":447,"context_line":"                        domain_id \u003d arg[\u0027domain_id\u0027]"},{"line_number":448,"context_line":"                msg \u003d _(\u0027Duplicate entry\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_a5dbc01a","line":445,"range":{"start_line":445,"start_character":24,"end_line":445,"end_character":40},"updated":"2016-12-12 21:12:10.000000000","message":"i think what rodrigo is asking is that we treat this differently. create a new variable id_ \u003d None before the for loop, and set it here if we enter this branch.\n\non line 453ish, we have another check that checks `elif id_:` and have an error message:\n\n  \u0027Duplicate entry found with ID %s\u0027 % id_","commit_id":"a87cf908ac688a1d209195945e2c4bfa08286866"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"d1104d1aea84fc4ef97c7b3d6d4206761763a074","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                        field \u003d \u0027name\u0027"},{"line_number":447,"context_line":"                        name \u003d arg[\u0027name\u0027]"},{"line_number":448,"context_line":"                    elif \u0027id\u0027 in arg:"},{"line_number":449,"context_line":"                        field \u003d \u0027id\u0027"},{"line_number":450,"context_line":"                        name \u003d arg[\u0027id\u0027]"},{"line_number":451,"context_line":"                    if \u0027domain_id\u0027 in arg:"},{"line_number":452,"context_line":"                        domain_id \u003d arg[\u0027domain_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_507272ae","line":449,"range":{"start_line":449,"start_character":32,"end_line":449,"end_character":36},"updated":"2016-12-13 19:45:55.000000000","message":"nit: ID reads better","commit_id":"83a892bf0989466ace2edb65cb35e703bb3e184a"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"d1104d1aea84fc4ef97c7b3d6d4206761763a074","unresolved":false,"context_lines":[{"line_number":447,"context_line":"                        name \u003d arg[\u0027name\u0027]"},{"line_number":448,"context_line":"                    elif \u0027id\u0027 in arg:"},{"line_number":449,"context_line":"                        field \u003d \u0027id\u0027"},{"line_number":450,"context_line":"                        name \u003d arg[\u0027id\u0027]"},{"line_number":451,"context_line":"                    if \u0027domain_id\u0027 in arg:"},{"line_number":452,"context_line":"                        domain_id \u003d arg[\u0027domain_id\u0027]"},{"line_number":453,"context_line":"                msg \u003d _(\u0027Duplicate entry\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_d05e8211","line":450,"range":{"start_line":450,"start_character":24,"end_line":450,"end_character":28},"updated":"2016-12-13 19:45:55.000000000","message":"value?","commit_id":"83a892bf0989466ace2edb65cb35e703bb3e184a"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"d1104d1aea84fc4ef97c7b3d6d4206761763a074","unresolved":false,"context_lines":[{"line_number":456,"context_line":"                            \u0027at domain ID %(domain_id)s\u0027) % {"},{"line_number":457,"context_line":"                        \u0027field\u0027: field, \u0027name\u0027: name, \u0027domain_id\u0027: domain_id}"},{"line_number":458,"context_line":"                elif name:"},{"line_number":459,"context_line":"                    msg \u003d _(\u0027Duplicate entry found with %(field)s \u0027"},{"line_number":460,"context_line":"                            \u0027%(name)s\u0027) % {\u0027field\u0027: field, \u0027name\u0027: name}"},{"line_number":461,"context_line":"                elif domain_id:"},{"line_number":462,"context_line":"                    msg \u003d (_(\u0027Duplicate entry at domain ID %s\u0027) % domain_id)"},{"line_number":463,"context_line":"                raise exception.Conflict(type\u003dconflict_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_d0476249","line":460,"range":{"start_line":459,"start_character":56,"end_line":460,"end_character":37},"updated":"2016-12-13 19:45:55.000000000","message":"nice!","commit_id":"83a892bf0989466ace2edb65cb35e703bb3e184a"}]}