)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bca255b576728fcfcb4de8ae75779b5f2c18e9bd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The endpoint docs show that `region_id` is not optional, even"},{"line_number":10,"context_line":"though it is. This updates the docs to reflect optional `region_id`."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1579014"},{"line_number":13,"context_line":"Change-Id: I085b75c59767eb96b3bdfe3b887e5e2639122a34"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a3905b3_e81c4a15","line":12,"updated":"2017-01-20 16:33:47.000000000","message":"This doesn\u0027t close this bug does it? The bug report eludes to some additional validation that we could do.","commit_id":"4573df57fe085344d1fe2ee17b5c8a10459ede4d"},{"author":{"_account_id":22604,"name":"Samuel Pilla","email":"sp516w@att.com","username":"samuel.pilla"},"change_message_id":"45c150befb9529d939a2f5e492d606d330b08283","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The endpoint docs show that `region_id` is not optional, even"},{"line_number":10,"context_line":"though it is. This updates the docs to reflect optional `region_id`."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1579014"},{"line_number":13,"context_line":"Change-Id: I085b75c59767eb96b3bdfe3b887e5e2639122a34"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a3905b3_6b2f74f6","line":12,"in_reply_to":"5a3905b3_e81c4a15","updated":"2017-01-20 16:56:10.000000000","message":"The reason \u0027name\u0027 and \u0027nme\u0027 were being addressed is that it was being created as the \u0027extras\u0027 column. Endpoints do not have \u0027name\u0027 in their table. I should probably add this clarification to the commit so Closes makes sense.","commit_id":"4573df57fe085344d1fe2ee17b5c8a10459ede4d"}],"api-ref/source/v3/service-catalog.inc":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"a68f823e56e3ee09b3fbbbc7389bdafd55f9aa32","unresolved":false,"context_lines":[{"line_number":354,"context_line":"   - enabled: endpoint_enabled_notRequired"},{"line_number":355,"context_line":"   - interface: endpoint_interface"},{"line_number":356,"context_line":"   - service_id: service_id"},{"line_number":357,"context_line":"   - region_id: region_id_1"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"Request Example"},{"line_number":360,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"1a430d35_356ef9c9","line":357,"updated":"2017-02-03 15:45:22.000000000","message":"I\u0027d *love* to give these better names. Nothing about `region_id_1` tells me the only difference between it and `region_id` is the fact it\u0027s not required.\n\nhttps://github.com/openstack/keystone/blob/cf9f0357cdee0ade5f41a562da92418a4645d251/api-ref/source/v3/parameters.yaml#L1434-L1447\n\nI suppose we can do that in a separate patch though. It\u0027s not going to affect the docs and it\u0027s only for developer readability.","commit_id":"49632aee6d0eb92f3d6a2ce88646772cde14543e"}]}