)]}'
{"keystone/federation/utils.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"88fe4821c4835eb2f3f56de6a324afe13da2f90e","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                try:"},{"line_number":616,"context_line":"                    group_names_list \u003d ast.literal_eval("},{"line_number":617,"context_line":"                        identity_value[\u0027groups\u0027])"},{"line_number":618,"context_line":"                except ValueError:"},{"line_number":619,"context_line":"                    group_names_list \u003d [identity_value[\u0027groups\u0027]]"},{"line_number":620,"context_line":"                domain \u003d identity_value[\u0027domain\u0027]"},{"line_number":621,"context_line":"                group_dicts \u003d [{\u0027name\u0027: name, \u0027domain\u0027: domain} for name in"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_752f57f6","side":"PARENT","line":618,"updated":"2017-01-20 16:20:13.000000000","message":"I reverted this locally and ran the tests. Seems like this fixes the issue [0]. \n\nSo - just to clarify. This blows up because \u0027ALL USERS\u0027 has a space in it? We should add a comment that explains the reason behind both the ValueError and SyntaxError exceptions being caught from ast, so it\u0027s easier for others to understand, too.\n\n\n[0] http://cdn.pasteraw.com/1nufvkhkrehrnup552nf1ojk2mpm3s9","commit_id":"386726d7a6b37cbc3451a9217cb87339334272e7"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"dd96a1c3698d26620878cf2965b3acc5be2ab31a","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                try:"},{"line_number":616,"context_line":"                    group_names_list \u003d ast.literal_eval("},{"line_number":617,"context_line":"                        identity_value[\u0027groups\u0027])"},{"line_number":618,"context_line":"                except ValueError:"},{"line_number":619,"context_line":"                    group_names_list \u003d [identity_value[\u0027groups\u0027]]"},{"line_number":620,"context_line":"                domain \u003d identity_value[\u0027domain\u0027]"},{"line_number":621,"context_line":"                group_dicts \u003d [{\u0027name\u0027: name, \u0027domain\u0027: domain} for name in"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_1a00f7a9","side":"PARENT","line":618,"in_reply_to":"5a3905b3_752f57f6","updated":"2017-01-20 18:53:06.000000000","message":"Yes, the error is rather strange, but here\u0027s a simple example that blows up with SyntaxError:\n\nimport ast\nast.literal_eval(\u0027ALL USERS\u0027)\n\nRemoving the space results in just a ValueError.\n\nI can go ahead and add a comment.  Note, this is consistent with the except below for group_ids.","commit_id":"386726d7a6b37cbc3451a9217cb87339334272e7"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"dd96a1c3698d26620878cf2965b3acc5be2ab31a","unresolved":false,"context_lines":[{"line_number":631,"context_line":"                try:"},{"line_number":632,"context_line":"                    group_ids.update("},{"line_number":633,"context_line":"                        ast.literal_eval(identity_value[\u0027group_ids\u0027]))"},{"line_number":634,"context_line":"                except (ValueError, SyntaxError):"},{"line_number":635,"context_line":"                    group_ids.update([identity_value[\u0027group_ids\u0027]])"},{"line_number":636,"context_line":"            if \u0027projects\u0027 in identity_value:"},{"line_number":637,"context_line":"                projects \u003d identity_value[\u0027projects\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a3905b3_dacaef6d","side":"PARENT","line":634,"range":{"start_line":634,"start_character":36,"end_line":634,"end_character":47},"updated":"2017-01-20 18:53:06.000000000","message":"here","commit_id":"386726d7a6b37cbc3451a9217cb87339334272e7"}]}