)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"cf11991c128683507ffb6a9f6978bc3115ee506b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"random uuids or default_fixture ids."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Co-Authored-By: Tin Lam \u003ctinlam@gmail.com\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ic4fff30c306561b71288712480f073aba1fccbde"},{"line_number":24,"context_line":"Closes-Bug: #1659053"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1a430d35_e6363fe6","line":22,"updated":"2017-02-06 17:05:50.000000000","message":"This doesn\u0027t need a: \n\n  Depends-On: I58bba04c21c2d24fd37850c9ecc6fac99deb3fc4\n\n?","commit_id":"0df96ab296aba1233d6839fa5ad3c24365e7af8e"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"7cdc7ef828f0e8a377766eea8086adbb800e31e4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"random uuids or default_fixture ids."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Co-Authored-By: Tin Lam \u003ctinlam@gmail.com\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ic4fff30c306561b71288712480f073aba1fccbde"},{"line_number":24,"context_line":"Closes-Bug: #1659053"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1a430d35_a9396843","line":22,"in_reply_to":"1a430d35_e6363fe6","updated":"2017-02-06 17:19:37.000000000","message":"will do!","commit_id":"0df96ab296aba1233d6839fa5ad3c24365e7af8e"}],"keystone/conf/identity.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e9ee430fc17416389faee66d6fc17591224d1ea5","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"default_domain_id \u003d cfg.StrOpt("},{"line_number":20,"context_line":"    \u0027default_domain_id\u0027,"},{"line_number":21,"context_line":"    default\u003d\u002700000000000000000000000000000000\u0027,"},{"line_number":22,"context_line":"    help\u003dutils.fmt(\"\"\""},{"line_number":23,"context_line":"This references the domain to use for all Identity API v2 requests (which are"},{"line_number":24,"context_line":"not aware of domains). A domain with this ID can optionally be created for you"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_29962893","line":21,"range":{"start_line":21,"start_character":13,"end_line":21,"end_character":45},"updated":"2017-01-30 06:08:02.000000000","message":"not so sure we can change this, i haven\u0027t reviewed the patch in full, but this is a non-starter. way too many depend on the default domain id being \"default\"","commit_id":"ba116cb661039b9f126029a94628486c8959dbff"}],"keystone/identity/id_generators/sha256.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b0e8eede2152fe29bff085ec38a663a9d9b0c554","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3a461143_4a1042a9","updated":"2017-02-02 04:47:38.000000000","message":"a reason for this change was not given in the commit message.\n\ni don\u0027t think we can change this, it\u0027ll cause folks using LDAPs to re-create IDs (i think)","commit_id":"59db112060f3efce011bc962d506a78ce1364506"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"86fc24e51a83ca65fb11f149f2f80dd7ee22df86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3a461143_6987b412","in_reply_to":"3a461143_4a1042a9","updated":"2017-02-02 17:23:42.000000000","message":"This sha256 generator supplies a 64 char hex string (which pycadf promptly complains about). If we need to keep this, then I\u0027m not sure if this patchset is doable without making changes to pycadf.","commit_id":"59db112060f3efce011bc962d506a78ce1364506"}],"keystone/tests/unit/assignment/test_backends.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"cf11991c128683507ffb6a9f6978bc3115ee506b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"ADMIN_ROLE_ID \u003d default_fixtures.ADMIN_ROLE_ID"},{"line_number":28,"context_line":"MEMBER_ROLE_ID \u003d default_fixtures.MEMBER_ROLE_ID"},{"line_number":29,"context_line":"OTHER_ROLE_ID \u003d default_fixtures.OTHER_ROLE_ID"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class AssignmentTestHelperMixin(object):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a430d35_064d0b6c","line":29,"updated":"2017-02-06 17:05:50.000000000","message":"What\u0027s wrong with just using:\n\n  default_fixtures.ADMIN_ROLE_ID \n\ndirectly? They should have the same value once default_fixtures is imported, right? Or is it because default_fixtures gets imported more than once and the value changes? If that is the case, we should leave a comment so that another developer doesn\u0027t come along and remove this or spend time trying to refactor it without understand the reason.","commit_id":"0df96ab296aba1233d6839fa5ad3c24365e7af8e"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"7cdc7ef828f0e8a377766eea8086adbb800e31e4","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"ADMIN_ROLE_ID \u003d default_fixtures.ADMIN_ROLE_ID"},{"line_number":28,"context_line":"MEMBER_ROLE_ID \u003d default_fixtures.MEMBER_ROLE_ID"},{"line_number":29,"context_line":"OTHER_ROLE_ID \u003d default_fixtures.OTHER_ROLE_ID"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class AssignmentTestHelperMixin(object):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a430d35_49056478","line":29,"in_reply_to":"1a430d35_064d0b6c","updated":"2017-02-06 17:19:37.000000000","message":"That should be fine, I think it was just easier for me to put them as shorter-named constants up top, but I agree that someone down the road might be confused why they are there.","commit_id":"0df96ab296aba1233d6839fa5ad3c24365e7af8e"}],"keystone/tests/unit/catalog/test_backends.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7e73664bd41b958d30e947b53b5391c4dc5cc7af","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def test_region_crud(self):"},{"line_number":32,"context_line":"        # create"},{"line_number":33,"context_line":"        region_id \u003d uuid.uuid4().hex"},{"line_number":34,"context_line":"        new_region \u003d unit.new_region_ref(id\u003dregion_id)"},{"line_number":35,"context_line":"        res \u003d self.catalog_api.create_region(new_region)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_fd1493a0","line":33,"updated":"2017-02-08 22:57:19.000000000","message":"We shouldn\u0027t lose any test coverage for being able to specify our own \"non-uuid\" like IDs with this, do we?","commit_id":"3476c0d19c6ff12e6548024e8a3839a714f48bcc"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0afb9e10bafff12fc364aaa6753ef65c43e9cfa7","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def test_region_crud(self):"},{"line_number":32,"context_line":"        # create"},{"line_number":33,"context_line":"        region_id \u003d uuid.uuid4().hex"},{"line_number":34,"context_line":"        new_region \u003d unit.new_region_ref(id\u003dregion_id)"},{"line_number":35,"context_line":"        res \u003d self.catalog_api.create_region(new_region)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_545c997c","line":33,"in_reply_to":"1a430d35_e02dc7fe","updated":"2017-02-09 05:27:25.000000000","message":"I just want to make sure we still have a test that attempts to create regions with non-uuid like strings.","commit_id":"3476c0d19c6ff12e6548024e8a3839a714f48bcc"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"78d973931c9e073cd5b0da06567fbbe68b4e9dcf","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def test_region_crud(self):"},{"line_number":32,"context_line":"        # create"},{"line_number":33,"context_line":"        region_id \u003d uuid.uuid4().hex"},{"line_number":34,"context_line":"        new_region \u003d unit.new_region_ref(id\u003dregion_id)"},{"line_number":35,"context_line":"        res \u003d self.catalog_api.create_region(new_region)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_e02dc7fe","line":33,"in_reply_to":"1a430d35_fd1493a0","updated":"2017-02-09 02:32:15.000000000","message":"This test passed fine with a region id of 255 \u00270\u0027s which is a non-uuid (other than with pycadf complaining). We could change this to \u0027default\u0027 or one of the other exempt strings in pycadf and it should be fine.","commit_id":"3476c0d19c6ff12e6548024e8a3839a714f48bcc"}],"keystone/tests/unit/core.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"709068fad9026517d50949e29f0d570f2fd5eb46","unresolved":false,"context_lines":[{"line_number":713,"context_line":"                    rv \u003d self.resource_api.get_domain(domain[\u0027id\u0027])"},{"line_number":714,"context_line":"                except exception.NotImplemented:"},{"line_number":715,"context_line":"                    rv \u003d domain"},{"line_number":716,"context_line":"                attrname \u003d \u0027domain_%s\u0027 % domain[\u0027name\u0027]"},{"line_number":717,"context_line":"                setattr(self, attrname, rv)"},{"line_number":718,"context_line":"                fixtures_to_cleanup.append(attrname)"},{"line_number":719,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a430d35_0b9cf45b","line":716,"range":{"start_line":716,"start_character":16,"end_line":716,"end_character":55},"updated":"2017-02-07 22:04:11.000000000","message":"i thought we were backing out the domain changes? undo this?","commit_id":"d1ab8d0456dbc82cc51b15734fa2929f8c9fbe0c"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"7100f77a06e8210d1d2b4b91f24f16df36e7042d","unresolved":false,"context_lines":[{"line_number":713,"context_line":"                    rv \u003d self.resource_api.get_domain(domain[\u0027id\u0027])"},{"line_number":714,"context_line":"                except exception.NotImplemented:"},{"line_number":715,"context_line":"                    rv \u003d domain"},{"line_number":716,"context_line":"                attrname \u003d \u0027domain_%s\u0027 % domain[\u0027name\u0027]"},{"line_number":717,"context_line":"                setattr(self, attrname, rv)"},{"line_number":718,"context_line":"                fixtures_to_cleanup.append(attrname)"},{"line_number":719,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a430d35_1c01986a","line":716,"range":{"start_line":716,"start_character":16,"end_line":716,"end_character":55},"in_reply_to":"1a430d35_0b9cf45b","updated":"2017-02-08 00:13:44.000000000","message":"ah, sure will do!","commit_id":"d1ab8d0456dbc82cc51b15734fa2929f8c9fbe0c"}],"keystone/tests/unit/default_fixtures.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b0e8eede2152fe29bff085ec38a663a9d9b0c554","unresolved":false,"context_lines":[{"line_number":20,"context_line":"BAZ_TENANT_ID \u003d uuid.uuid4().hex"},{"line_number":21,"context_line":"MTU_TENANT_ID \u003d uuid.uuid4().hex"},{"line_number":22,"context_line":"SERVICE_TENANT_ID \u003d uuid.uuid4().hex"},{"line_number":23,"context_line":"DEFAULT_DOMAIN_ID \u003d \u002700000000000000000000000000000001\u0027"},{"line_number":24,"context_line":"ADMIN_ROLE_ID \u003d uuid.uuid4().hex"},{"line_number":25,"context_line":"MEMBER_ROLE_ID \u003d uuid.uuid4().hex"},{"line_number":26,"context_line":"OTHER_ROLE_ID \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_8a694a28","line":23,"range":{"start_line":23,"start_character":21,"end_line":23,"end_character":53},"updated":"2017-02-02 04:47:38.000000000","message":"why not just use uuid.uuid4().hex here?","commit_id":"59db112060f3efce011bc962d506a78ce1364506"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"86fc24e51a83ca65fb11f149f2f80dd7ee22df86","unresolved":false,"context_lines":[{"line_number":20,"context_line":"BAZ_TENANT_ID \u003d uuid.uuid4().hex"},{"line_number":21,"context_line":"MTU_TENANT_ID \u003d uuid.uuid4().hex"},{"line_number":22,"context_line":"SERVICE_TENANT_ID \u003d uuid.uuid4().hex"},{"line_number":23,"context_line":"DEFAULT_DOMAIN_ID \u003d \u002700000000000000000000000000000001\u0027"},{"line_number":24,"context_line":"ADMIN_ROLE_ID \u003d uuid.uuid4().hex"},{"line_number":25,"context_line":"MEMBER_ROLE_ID \u003d uuid.uuid4().hex"},{"line_number":26,"context_line":"OTHER_ROLE_ID \u003d uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_3f315aed","line":23,"range":{"start_line":23,"start_character":21,"end_line":23,"end_character":53},"in_reply_to":"3a461143_8a694a28","updated":"2017-02-02 17:23:42.000000000","message":"will do","commit_id":"59db112060f3efce011bc962d506a78ce1364506"}],"keystone/tests/unit/identity/test_backend_sql.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"709068fad9026517d50949e29f0d570f2fd5eb46","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                                   unique_last_password_count\u003dself.max_cnt)"},{"line_number":459,"context_line":"        user \u003d {"},{"line_number":460,"context_line":"            \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":461,"context_line":"            \u0027domain_id\u0027: CONF.identity.default_domain_id,"},{"line_number":462,"context_line":"            \u0027enabled\u0027: True,"},{"line_number":463,"context_line":"        }"},{"line_number":464,"context_line":"        user \u003d self.identity_api.create_user(user)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a430d35_8ba8e478","line":461,"range":{"start_line":461,"start_character":25,"end_line":461,"end_character":56},"updated":"2017-02-07 22:04:11.000000000","message":"i thought we were backing out the domain changes? undo this?","commit_id":"d1ab8d0456dbc82cc51b15734fa2929f8c9fbe0c"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7e73664bd41b958d30e947b53b5391c4dc5cc7af","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    def _get_user_dict(self):"},{"line_number":198,"context_line":"        user \u003d {"},{"line_number":199,"context_line":"            \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":200,"context_line":"            \u0027domain_id\u0027: \u0027default\u0027,"},{"line_number":201,"context_line":"            \u0027enabled\u0027: True,"},{"line_number":202,"context_line":"            \u0027password\u0027: uuid.uuid4().hex"},{"line_number":203,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_fdc9f326","line":200,"updated":"2017-02-08 22:57:19.000000000","message":"I\u0027m not sure how this change fits into this patch? Wasn\u0027t this related to Steve\u0027s comment on patch set 11?","commit_id":"3476c0d19c6ff12e6548024e8a3839a714f48bcc"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"78d973931c9e073cd5b0da06567fbbe68b4e9dcf","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    def _get_user_dict(self):"},{"line_number":198,"context_line":"        user \u003d {"},{"line_number":199,"context_line":"            \u0027name\u0027: uuid.uuid4().hex,"},{"line_number":200,"context_line":"            \u0027domain_id\u0027: \u0027default\u0027,"},{"line_number":201,"context_line":"            \u0027enabled\u0027: True,"},{"line_number":202,"context_line":"            \u0027password\u0027: uuid.uuid4().hex"},{"line_number":203,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a430d35_803de32c","line":200,"in_reply_to":"1a430d35_fdc9f326","updated":"2017-02-09 02:32:15.000000000","message":"Oh I replaced too much here, I\u0027ll revert this. Thanks for the catch!","commit_id":"3476c0d19c6ff12e6548024e8a3839a714f48bcc"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"cf11991c128683507ffb6a9f6978bc3115ee506b","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"ADMIN_ROLE_ID \u003d default_fixtures.ADMIN_ROLE_ID"},{"line_number":50,"context_line":"MEMBER_ROLE_ID \u003d default_fixtures.MEMBER_ROLE_ID"},{"line_number":51,"context_line":"OTHER_ROLE_ID \u003d default_fixtures.OTHER_ROLE_ID"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def _assert_backends(testcase, **kwargs):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a430d35_e6f47f88","line":51,"updated":"2017-02-06 17:05:50.000000000","message":"Same comment here.","commit_id":"0df96ab296aba1233d6839fa5ad3c24365e7af8e"}],"keystone/tests/unit/test_catalog.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b0e8eede2152fe29bff085ec38a663a9d9b0c554","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"        if region is not None:"},{"line_number":72,"context_line":"            body[\u0027endpoint\u0027][\u0027region\u0027] \u003d region"},{"line_number":73,"context_line":"        print(body[\u0027endpoint\u0027][\u0027service_id\u0027])"},{"line_number":74,"context_line":"        r \u003d self.admin_request(method\u003d\u0027POST\u0027, token\u003dself.get_scoped_token(),"},{"line_number":75,"context_line":"                               path\u003dpath, expected_status\u003dexpected_status,"},{"line_number":76,"context_line":"                               body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_8a506a60","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":45},"updated":"2017-02-02 04:47:38.000000000","message":"delete","commit_id":"59db112060f3efce011bc962d506a78ce1364506"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"86fc24e51a83ca65fb11f149f2f80dd7ee22df86","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        }"},{"line_number":71,"context_line":"        if region is not None:"},{"line_number":72,"context_line":"            body[\u0027endpoint\u0027][\u0027region\u0027] \u003d region"},{"line_number":73,"context_line":"        print(body[\u0027endpoint\u0027][\u0027service_id\u0027])"},{"line_number":74,"context_line":"        r \u003d self.admin_request(method\u003d\u0027POST\u0027, token\u003dself.get_scoped_token(),"},{"line_number":75,"context_line":"                               path\u003dpath, expected_status\u003dexpected_status,"},{"line_number":76,"context_line":"                               body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_2c069a20","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":45},"in_reply_to":"3a461143_8a506a60","updated":"2017-02-02 17:23:42.000000000","message":"Done","commit_id":"59db112060f3efce011bc962d506a78ce1364506"}],"keystone/tests/unit/test_cli.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"709068fad9026517d50949e29f0d570f2fd5eb46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1a430d35_ebade884","updated":"2017-02-07 22:04:11.000000000","message":"i thought we were backing out the domain changes? undo these?","commit_id":"d1ab8d0456dbc82cc51b15734fa2929f8c9fbe0c"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"e8c45a8f26707d41e6aacf2759962c2267dbe73a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.load_backends()"},{"line_number":63,"context_line":"        cli.TokenFlush.main()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    # NOTE(ravelar): the following method tests that the token_flush command,"},{"line_number":66,"context_line":"    # when used in conjunction with an unsupported token driver like kvs,"},{"line_number":67,"context_line":"    # will yield a LOG.warning message informing the user that the"},{"line_number":68,"context_line":"    # command had no effect."},{"line_number":69,"context_line":"    def test_token_flush_excepts_not_implemented_and_logs_warning(self):"},{"line_number":70,"context_line":"        self.useFixture(database.Database())"},{"line_number":71,"context_line":"        self.load_backends()"},{"line_number":72,"context_line":"        self.config_fixture.config(group\u003d\u0027token\u0027, driver\u003d\u0027kvs\u0027)"},{"line_number":73,"context_line":"        log_info \u003d self.useFixture(fixtures.FakeLogger(level\u003dlog.WARN))"},{"line_number":74,"context_line":"        cli.TokenFlush.main()"},{"line_number":75,"context_line":"        self.assertIn(\"token_flush command had no effect\", log_info.output)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class CliNoConfigTestCase(unit.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a430d35_92fe51ac","side":"PARENT","line":75,"range":{"start_line":65,"start_character":0,"end_line":75,"end_character":75},"updated":"2017-02-08 01:44:26.000000000","message":"hmm this may have been removed accidentally when rebasing?","commit_id":"9bb57c1eb7f295d1c7d37f880f5ed99bbee766a4"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f46d9b0fd4c387ec90dff3bddb2e17c006e0afcb","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.load_backends()"},{"line_number":63,"context_line":"        cli.TokenFlush.main()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    # NOTE(ravelar): the following method tests that the token_flush command,"},{"line_number":66,"context_line":"    # when used in conjunction with an unsupported token driver like kvs,"},{"line_number":67,"context_line":"    # will yield a LOG.warning message informing the user that the"},{"line_number":68,"context_line":"    # command had no effect."},{"line_number":69,"context_line":"    def test_token_flush_excepts_not_implemented_and_logs_warning(self):"},{"line_number":70,"context_line":"        self.useFixture(database.Database())"},{"line_number":71,"context_line":"        self.load_backends()"},{"line_number":72,"context_line":"        self.config_fixture.config(group\u003d\u0027token\u0027, driver\u003d\u0027kvs\u0027)"},{"line_number":73,"context_line":"        log_info \u003d self.useFixture(fixtures.FakeLogger(level\u003dlog.WARN))"},{"line_number":74,"context_line":"        cli.TokenFlush.main()"},{"line_number":75,"context_line":"        self.assertIn(\"token_flush command had no effect\", log_info.output)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class CliNoConfigTestCase(unit.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a430d35_72d9e521","side":"PARENT","line":75,"range":{"start_line":65,"start_character":0,"end_line":75,"end_character":75},"in_reply_to":"1a430d35_527b0928","updated":"2017-02-08 01:55:02.000000000","message":"the rebase button did all the work","commit_id":"9bb57c1eb7f295d1c7d37f880f5ed99bbee766a4"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"3f747e1974630f6705614597ae295a2a8b22f0c4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self.load_backends()"},{"line_number":63,"context_line":"        cli.TokenFlush.main()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    # NOTE(ravelar): the following method tests that the token_flush command,"},{"line_number":66,"context_line":"    # when used in conjunction with an unsupported token driver like kvs,"},{"line_number":67,"context_line":"    # will yield a LOG.warning message informing the user that the"},{"line_number":68,"context_line":"    # command had no effect."},{"line_number":69,"context_line":"    def test_token_flush_excepts_not_implemented_and_logs_warning(self):"},{"line_number":70,"context_line":"        self.useFixture(database.Database())"},{"line_number":71,"context_line":"        self.load_backends()"},{"line_number":72,"context_line":"        self.config_fixture.config(group\u003d\u0027token\u0027, driver\u003d\u0027kvs\u0027)"},{"line_number":73,"context_line":"        log_info \u003d self.useFixture(fixtures.FakeLogger(level\u003dlog.WARN))"},{"line_number":74,"context_line":"        cli.TokenFlush.main()"},{"line_number":75,"context_line":"        self.assertIn(\"token_flush command had no effect\", log_info.output)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class CliNoConfigTestCase(unit.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a430d35_527b0928","side":"PARENT","line":75,"range":{"start_line":65,"start_character":0,"end_line":75,"end_character":75},"in_reply_to":"1a430d35_92fe51ac","updated":"2017-02-08 01:52:25.000000000","message":"no idea what happened here, thanks for fixing this!","commit_id":"9bb57c1eb7f295d1c7d37f880f5ed99bbee766a4"}],"keystone/tests/unit/test_v2.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"b0e8eede2152fe29bff085ec38a663a9d9b0c554","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from keystone.tests.unit.schema import v2"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d keystone.conf.CONF"},{"line_number":29,"context_line":"DEFAULT_DOMAIN_ID \u003d default_fixtures.DEFAULT_DOMAIN_ID"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class CoreApiTests(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_4ad5a2b7","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":54},"updated":"2017-02-02 04:47:38.000000000","message":"why not use: CONF.identity.default_domain_id instead ?\n\nsame question applies for many instances of importing the fixture","commit_id":"59db112060f3efce011bc962d506a78ce1364506"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"86fc24e51a83ca65fb11f149f2f80dd7ee22df86","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from keystone.tests.unit.schema import v2"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d keystone.conf.CONF"},{"line_number":29,"context_line":"DEFAULT_DOMAIN_ID \u003d default_fixtures.DEFAULT_DOMAIN_ID"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class CoreApiTests(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a461143_9f088e2a","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":54},"in_reply_to":"3a461143_4ad5a2b7","updated":"2017-02-02 17:23:42.000000000","message":"yeah, I thought I would be needing to know the specific uuid but I think I can just call that from the CONF and it should be fine.","commit_id":"59db112060f3efce011bc962d506a78ce1364506"}],"keystone/tests/unit/test_v3.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"709068fad9026517d50949e29f0d570f2fd5eb46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1a430d35_4bc99c58","updated":"2017-02-07 22:04:11.000000000","message":"i thought we were backing out the domain changes? undo these?","commit_id":"d1ab8d0456dbc82cc51b15734fa2929f8c9fbe0c"}],"keystone/version/__init__.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"709068fad9026517d50949e29f0d570f2fd5eb46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1a430d35_0b85d405","updated":"2017-02-07 22:04:11.000000000","message":"historically we\u0027ve only changed this for major versions, whats the reasoning behind this change?","commit_id":"d1ab8d0456dbc82cc51b15734fa2929f8c9fbe0c"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"7100f77a06e8210d1d2b4b91f24f16df36e7042d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1a430d35_3c41f4a9","in_reply_to":"1a430d35_0b85d405","updated":"2017-02-08 00:13:44.000000000","message":"I think it was discussed about bumping the version for pycadf, but we should be able to just bump the pycadf version I would assume? This does not need to be changed here though, I will revert this.","commit_id":"d1ab8d0456dbc82cc51b15734fa2929f8c9fbe0c"}],"releasenotes/notes/use-uuids-with-pycadf-19892295e870103e.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"cf11991c128683507ffb6a9f6978bc3115ee506b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    for their \u0027id\u0027 values. Also changed load_fixtures to build the fixtures"},{"line_number":6,"context_line":"    based on the default_fixtures\u0027 \u0027name\u0027 value, rather than \u0027id\u0027. Replaced"},{"line_number":7,"context_line":"    many instances of invalid hard-coded ids to use random uuids or"},{"line_number":8,"context_line":"    default_fixture ids."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a430d35_c6dce3e6","line":8,"updated":"2017-02-06 17:05:50.000000000","message":"We could link to the bug report here, since we have one. Also, just double checking but does this require anything from operators?","commit_id":"0df96ab296aba1233d6839fa5ad3c24365e7af8e"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"7cdc7ef828f0e8a377766eea8086adbb800e31e4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    for their \u0027id\u0027 values. Also changed load_fixtures to build the fixtures"},{"line_number":6,"context_line":"    based on the default_fixtures\u0027 \u0027name\u0027 value, rather than \u0027id\u0027. Replaced"},{"line_number":7,"context_line":"    many instances of invalid hard-coded ids to use random uuids or"},{"line_number":8,"context_line":"    default_fixture ids."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1a430d35_89d2ecd0","line":8,"in_reply_to":"1a430d35_c6dce3e6","updated":"2017-02-06 17:19:37.000000000","message":"I don\u0027t think this directly impacts operators (other than maybe seeing much less warnings in the logs due to the pycadf change), the changes are all within keystone\u0027s tests.","commit_id":"0df96ab296aba1233d6839fa5ad3c24365e7af8e"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"709068fad9026517d50949e29f0d570f2fd5eb46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1a430d35_cba74cbb","updated":"2017-02-07 22:04:11.000000000","message":"theres no end-user impact here, no need to create a release note","commit_id":"d1ab8d0456dbc82cc51b15734fa2929f8c9fbe0c"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"7100f77a06e8210d1d2b4b91f24f16df36e7042d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1a430d35_1c0fd888","in_reply_to":"1a430d35_cba74cbb","updated":"2017-02-08 00:13:44.000000000","message":"ah ok, thanks Steve","commit_id":"d1ab8d0456dbc82cc51b15734fa2929f8c9fbe0c"}]}