)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"7737948d2603aea5dbf6e190067147e3b70cd1a5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zcjmath \u003c453528434@qq.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-10 10:29:15 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Keystone ldap tree_dn does not support Chinese,"},{"line_number":8,"context_line":"encoding comment adding it to the top of the file"},{"line_number":9,"context_line":"Change-Id: I9e5d59dcc71c0561b1d68ea358abab20a047b577"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa31d9ce_a749fd90","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":49},"updated":"2017-02-10 02:47:28.000000000","message":"your topic is too long, try to limit this to 50 characters.\nsee: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"aa9407334313a063cfb64785820e4095f496aa73"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"969749b09fc4ffe833bf3c604d05fd823ee616dd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zcjmath \u003c453528434@qq.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-10 15:58:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Keystone ldap tree_dn does not support Chinese"},{"line_number":8,"context_line":"Change-Id: I9e5d59dcc71c0561b1d68ea358abab20a047b577"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffe62b97_c300fd04","line":7,"updated":"2017-03-29 18:51:29.000000000","message":"What kind of translations is this going to support? OpenStack has recently made the decision that we are no longer going to support translations for log messages [0]. This isn\u0027t for the translation of log messages, is it? \n\n[0] http://lists.openstack.org/pipermail/openstack-dev/2017-March/113365.html","commit_id":"67b0205727b89930f9aa2711dd6c8ab26ced5473"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"2afb310b4162d65d1d86db1c257df4b4f2d83b6d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zcjmath \u003c453528434@qq.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-10 15:58:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Keystone ldap tree_dn does not support Chinese"},{"line_number":8,"context_line":"Change-Id: I9e5d59dcc71c0561b1d68ea358abab20a047b577"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ffe62b97_7cf1d200","line":7,"in_reply_to":"ffe62b97_c300fd04","updated":"2017-03-29 19:42:42.000000000","message":"No. This is basically a potential mishandling of unicode data.","commit_id":"67b0205727b89930f9aa2711dd6c8ab26ced5473"}],"keystone/identity/backends/ldap/common.py":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"8a40eb1babf1c2bdf60146de28736cb93d101ce9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":15,"context_line":"import abc"},{"line_number":16,"context_line":"import codecs"},{"line_number":17,"context_line":"import functools"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_f1015207","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":23},"updated":"2017-02-08 04:00:38.000000000","message":"I presume this patch set is WIP.  The only change seems to be just adding a line of comment","commit_id":"ae1ecd8ed9b2fe47e0178aae42048347daf07035"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"222621e83966563e8a9e913cd45cd55954957966","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":"# -*- coding: utf-8 -*-"},{"line_number":15,"context_line":"import abc"},{"line_number":16,"context_line":"import codecs"},{"line_number":17,"context_line":"import functools"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a430d35_fd6013a7","line":14,"in_reply_to":"1a430d35_f1015207","updated":"2017-02-08 22:40:35.000000000","message":"The convention we seem to take for these types of changes is adding it to the top of the file: \n\nhttps://github.com/openstack/keystone/blob/029476272fb869c6413aa4e70f4cae6f890e598f/keystone/tests/unit/test_validation.py#L1\nhttps://github.com/openstack/keystone/blob/029476272fb869c6413aa4e70f4cae6f890e598f/keystone/tests/unit/test_wsgi.py#L1\nhttps://github.com/openstack/keystone/blob/029476272fb869c6413aa4e70f4cae6f890e598f/keystone/tests/unit/mapping_fixtures.py#L1\nhttps://github.com/openstack/keystone/blob/029476272fb869c6413aa4e70f4cae6f890e598f/keystone/tests/unit/test_backend_id_mapping_sql.py#L1\nhttps://github.com/openstack/keystone/blob/029476272fb869c6413aa4e70f4cae6f890e598f/keystone/tests/unit/identity/backends/test_ldap_common.py#L1\nhttps://github.com/openstack/keystone/blob/029476272fb869c6413aa4e70f4cae6f890e598f/keystone/tests/unit/test_backend_ldap.py#L1\nhttps://github.com/openstack/keystone/blob/029476272fb869c6413aa4e70f4cae6f890e598f/keystone/tests/unit/common/test_utils.py#L1\n\nAlso - we try to add some sort of test to ensure the encoding works as expected: \n\nhttps://github.com/openstack/keystone/commit/944bd0a2dca60a5b144378587a13220d33298051","commit_id":"ae1ecd8ed9b2fe47e0178aae42048347daf07035"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"7737948d2603aea5dbf6e190067147e3b70cd1a5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import abc"},{"line_number":16,"context_line":"import codecs"},{"line_number":17,"context_line":"import functools"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_0749e98b","side":"PARENT","line":14,"updated":"2017-02-10 02:47:28.000000000","message":"you can revert this change, not irrelevant.","commit_id":"aeb51c84bb92d02715208aa8435aa3fd36564c72"},{"author":{"_account_id":13063,"name":"WEI CHEN","email":"dave.jungler@gmail.com","username":"wei.d.chen"},"change_message_id":"5b328d7643079f6feb4e2e65e11f80f30ea4b55f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import abc"},{"line_number":16,"context_line":"import codecs"},{"line_number":17,"context_line":"import functools"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_ca03580c","side":"PARENT","line":14,"in_reply_to":"fa31d9ce_0749e98b","updated":"2017-02-10 02:49:08.000000000","message":"s/not irrelevant/not relevant. :)","commit_id":"aeb51c84bb92d02715208aa8435aa3fd36564c72"}]}