)]}'
{"keystone/common/wsgi.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9902ce547b5a41d60f309cc4de1e0d55a84f5a33","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        if result is None:"},{"line_number":185,"context_line":"            return render_response(result, status\u003d(204, \u0027No Content\u0027))"},{"line_number":186,"context_line":"        elif type(result) is str or type(result) is unicode:"},{"line_number":187,"context_line":"            return result"},{"line_number":188,"context_line":"        elif isinstance(result, webob.Response):"},{"line_number":189,"context_line":"            return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F3t0%3D","line":186,"updated":"2012-02-22 16:05:30.000000000","message":"might be better as:\n\n elif isinstance(result, basestring):","commit_id":"82eb85f440ab2d103275cb42a9d3836e9db37cad"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"caac8490e7c24903e85a663638ff0806eb87747c","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        if result is None:"},{"line_number":185,"context_line":"            return render_response(result, status\u003d(204, \u0027No Content\u0027))"},{"line_number":186,"context_line":"        elif type(result) is str or type(result) is unicode:"},{"line_number":187,"context_line":"            return result"},{"line_number":188,"context_line":"        elif isinstance(result, webob.Response):"},{"line_number":189,"context_line":"            return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F3dg%3D","line":186,"in_reply_to":"AAAAEn%2F%2F3t0%3D","updated":"2012-02-22 19:55:18.000000000","message":"Done","commit_id":"82eb85f440ab2d103275cb42a9d3836e9db37cad"}],"keystone/service.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"caac8490e7c24903e85a663638ff0806eb87747c","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                                             token_id\u003dtoken_id)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"        if belongs_to:"},{"line_number":336,"context_line":"            assert token_ref[\u0027tenant\u0027][\u0027id\u0027] \u003d\u003d belongs_to"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        return token_ref"},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F3d0%3D","line":336,"updated":"2012-02-22 19:55:18.000000000","message":"This particular assert could be returned, but is being tracked by a different bug.","commit_id":"82eb85f440ab2d103275cb42a9d3836e9db37cad"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"9902ce547b5a41d60f309cc4de1e0d55a84f5a33","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        Identical to ``validate_token``, except does not return a response."},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        \"\"\""},{"line_number":349,"context_line":"        assert self._get_token_ref(context, token_id, belongs_to)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    # admin only"},{"line_number":352,"context_line":"    def validate_token(self, context, token_id, belongs_to\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F3tw%3D","line":349,"updated":"2012-02-22 16:05:30.000000000","message":"Why are we asserting here?","commit_id":"82eb85f440ab2d103275cb42a9d3836e9db37cad"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"caac8490e7c24903e85a663638ff0806eb87747c","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        Identical to ``validate_token``, except does not return a response."},{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        \"\"\""},{"line_number":349,"context_line":"        assert self._get_token_ref(context, token_id, belongs_to)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    # admin only"},{"line_number":352,"context_line":"    def validate_token(self, context, token_id, belongs_to\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEn%2F%2F3eA%3D","line":349,"in_reply_to":"AAAAEn%2F%2F3tw%3D","updated":"2012-02-22 19:55:18.000000000","message":"This *should* never assert false, if no token is found by the backend, a 404 is raised and bubbled up. If a token is found, it asserts true.\n\nThe assert is actually unnecessary, but I figured \"get_token\" without doing something with it wasn\u0027t very clear.","commit_id":"82eb85f440ab2d103275cb42a9d3836e9db37cad"}]}
