)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3384bef769f57bb087467cf54ad9e73d21fb86b6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Morgan Fainberg \u003cmorgan.fainberg@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-27 21:46:12 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use pdkfd_sha512 instead of sha512_crypt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"sha512_crypt is considered insufficient (even with significant rounds)"},{"line_number":10,"context_line":"in comparison to pdkfd_sha512, bcrypt, or scrypt for password hashing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_6ebb6b0f","line":7,"updated":"2017-02-28 14:11:38.000000000","message":"pbkdf2_sha512","commit_id":"2009a85bc063f299c2389434008be81a017cea13"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"576379f0c225a4f459c6717ea0e94f7f32eace81","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Morgan Fainberg \u003cmorgan.fainberg@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-27 21:46:12 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use pdkfd_sha512 instead of sha512_crypt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"sha512_crypt is considered insufficient (even with significant rounds)"},{"line_number":10,"context_line":"in comparison to pdkfd_sha512, bcrypt, or scrypt for password hashing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_25f989c9","line":7,"in_reply_to":"ba2be162_6ebb6b0f","updated":"2017-02-28 18:05:08.000000000","message":"I really need to be less tired when typing, noticed I made the same typo even in the bug. Anyway. Fixed in next.","commit_id":"2009a85bc063f299c2389434008be81a017cea13"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3384bef769f57bb087467cf54ad9e73d21fb86b6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use pdkfd_sha512 instead of sha512_crypt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"sha512_crypt is considered insufficient (even with significant rounds)"},{"line_number":10,"context_line":"in comparison to pdkfd_sha512, bcrypt, or scrypt for password hashing."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch makes all future password hashing use pdkfd_sha512 instead"},{"line_number":13,"context_line":"of sha512_crypt while still supporting decrypting any/all passwords"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_ae3ba39b","line":10,"updated":"2017-02-28 14:11:38.000000000","message":"pbkdf2_sha512","commit_id":"2009a85bc063f299c2389434008be81a017cea13"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3384bef769f57bb087467cf54ad9e73d21fb86b6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"sha512_crypt is considered insufficient (even with significant rounds)"},{"line_number":10,"context_line":"in comparison to pdkfd_sha512, bcrypt, or scrypt for password hashing."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch makes all future password hashing use pdkfd_sha512 instead"},{"line_number":13,"context_line":"of sha512_crypt while still supporting decrypting any/all passwords"},{"line_number":14,"context_line":"originally hashed with sha512_crypt. It is recommended users change"},{"line_number":15,"context_line":"passwords to ensure a more secure hashing algorithm (based on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_ee459b17","line":12,"updated":"2017-02-28 14:11:38.000000000","message":"pbkdf2_sha512","commit_id":"2009a85bc063f299c2389434008be81a017cea13"}],"keystone/tests/unit/common/test_utils.py":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3384bef769f57bb087467cf54ad9e73d21fb86b6","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_password_verify_unknown_ident(self):"},{"line_number":89,"context_line":"        password \u003d uuid.uuid4().hex"},{"line_number":90,"context_line":"        hashed \u003d passlib.hash.pbkdf2_sha1.hash(password)"},{"line_number":91,"context_line":"        self.assertRaises(ValueError, common_utils.check_password,"},{"line_number":92,"context_line":"                          password, hashed)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_8ea09fa7","line":90,"updated":"2017-02-28 14:11:38.000000000","message":"A comment explaining that this is an intentional algorithm mismatch (SHA1 instead of SHA2/512) would help, or maybe just use a fixed string here.","commit_id":"2009a85bc063f299c2389434008be81a017cea13"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"576379f0c225a4f459c6717ea0e94f7f32eace81","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_password_verify_unknown_ident(self):"},{"line_number":89,"context_line":"        password \u003d uuid.uuid4().hex"},{"line_number":90,"context_line":"        hashed \u003d passlib.hash.pbkdf2_sha1.hash(password)"},{"line_number":91,"context_line":"        self.assertRaises(ValueError, common_utils.check_password,"},{"line_number":92,"context_line":"                          password, hashed)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_2572697d","line":90,"in_reply_to":"ba2be162_8ea09fa7","updated":"2017-02-28 18:05:08.000000000","message":"Done in next.","commit_id":"2009a85bc063f299c2389434008be81a017cea13"}]}