)]}'
{"keystone/tests/unit/common/test_database_conflicts.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"5a0ced09f20072ec86098e47cf38e85a06ea52ed","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # context manager. If that ever changes, or if we move away from"},{"line_number":37,"context_line":"        # testtools, we should fix this to be more test-like and not rely on"},{"line_number":38,"context_line":"        # try/except/else patterns in tests."},{"line_number":39,"context_line":"        # (i.e. http://cdn.pasteraw.com/h38srugqxbw69dw7flw63pqfwxjl3g6)"},{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            self.resource_api.create_domain(domain[\u0027id\u0027], domain)"},{"line_number":42,"context_line":"        except exception.Conflict as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_2d6c64cf","line":39,"range":{"start_line":39,"start_character":10,"end_line":39,"end_character":72},"updated":"2017-03-03 16:45:55.000000000","message":"I would remove the link and put the example in the comment.","commit_id":"f308b10a018d86262981f8a814af6b85ef3ee573"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"7809137552b64673ff93b81f14a440d87bf2a1b1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # context manager. If that ever changes, or if we move away from"},{"line_number":37,"context_line":"        # testtools, we should fix this to be more test-like and not rely on"},{"line_number":38,"context_line":"        # try/except/else patterns in tests."},{"line_number":39,"context_line":"        # (i.e. http://cdn.pasteraw.com/h38srugqxbw69dw7flw63pqfwxjl3g6)"},{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            self.resource_api.create_domain(domain[\u0027id\u0027], domain)"},{"line_number":42,"context_line":"        except exception.Conflict as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_ed896c27","line":39,"range":{"start_line":39,"start_character":10,"end_line":39,"end_character":72},"in_reply_to":"ba2be162_2d6c64cf","updated":"2017-03-03 17:00:38.000000000","message":"+1. It\u0027s a short example and helps a lot to have it inline without a net connection (during flights).","commit_id":"f308b10a018d86262981f8a814af6b85ef3ee573"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1a7666fa1e344ea27967842955406d7517b36366","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # context manager. If that ever changes, or if we move away from"},{"line_number":37,"context_line":"        # testtools, we should fix this to be more test-like and not rely on"},{"line_number":38,"context_line":"        # try/except/else patterns in tests."},{"line_number":39,"context_line":"        # (i.e. http://cdn.pasteraw.com/h38srugqxbw69dw7flw63pqfwxjl3g6)"},{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            self.resource_api.create_domain(domain[\u0027id\u0027], domain)"},{"line_number":42,"context_line":"        except exception.Conflict as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_8994e737","line":39,"in_reply_to":"ba2be162_a3985c6b","updated":"2017-03-07 19:10:22.000000000","message":"I went back and forth on this. It is trivia, I can remove. New patch on the way!","commit_id":"f308b10a018d86262981f8a814af6b85ef3ee573"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"e92c3f389b8f9c1d86cb2fa56102d4afa52a4547","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        # context manager. If that ever changes, or if we move away from"},{"line_number":37,"context_line":"        # testtools, we should fix this to be more test-like and not rely on"},{"line_number":38,"context_line":"        # try/except/else patterns in tests."},{"line_number":39,"context_line":"        # (i.e. http://cdn.pasteraw.com/h38srugqxbw69dw7flw63pqfwxjl3g6)"},{"line_number":40,"context_line":"        try:"},{"line_number":41,"context_line":"            self.resource_api.create_domain(domain[\u0027id\u0027], domain)"},{"line_number":42,"context_line":"        except exception.Conflict as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_a3985c6b","line":39,"in_reply_to":"ba2be162_ed896c27","updated":"2017-03-03 19:28:39.000000000","message":"i\u0027m not sure the example is even worth having.","commit_id":"f308b10a018d86262981f8a814af6b85ef3ee573"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4948edac26d3029858034ef1cd97f2e5401e5c63","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        domain \u003d unit.new_domain_ref()"},{"line_number":28,"context_line":"        self.resource_api.create_domain(domain[\u0027id\u0027], domain)"},{"line_number":29,"context_line":"        domain[\u0027id\u0027] \u003d uuid.uuid4().hex"},{"line_number":30,"context_line":"        # FIXME(lbragstad): This module relies heavily on the usage of"},{"line_number":31,"context_line":"        # try/excepts within the tests. We could achieve the same functionality"},{"line_number":32,"context_line":"        # with better readability using a context manager from"},{"line_number":33,"context_line":"        # `assertRaises()`. The reason why we aren\u0027t is because we are using"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_a586fe62","line":30,"updated":"2017-03-08 19:23:07.000000000","message":"FIXME\u0027s indicate the code is broken and should not be trusted to perform it\u0027s intended function. This is just a TODO.","commit_id":"8f5953e09e2340047e3295bf95f5bda2d52a32fb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5c2b4de4e4cb215be84bb282e57a1c93f026002e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        domain \u003d unit.new_domain_ref()"},{"line_number":28,"context_line":"        self.resource_api.create_domain(domain[\u0027id\u0027], domain)"},{"line_number":29,"context_line":"        domain[\u0027id\u0027] \u003d uuid.uuid4().hex"},{"line_number":30,"context_line":"        # FIXME(lbragstad): This module relies heavily on the usage of"},{"line_number":31,"context_line":"        # try/excepts within the tests. We could achieve the same functionality"},{"line_number":32,"context_line":"        # with better readability using a context manager from"},{"line_number":33,"context_line":"        # `assertRaises()`. The reason why we aren\u0027t is because we are using"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_b402ad6d","line":30,"in_reply_to":"9a30ddce_a586fe62","updated":"2017-03-08 20:56:57.000000000","message":"Done","commit_id":"8f5953e09e2340047e3295bf95f5bda2d52a32fb"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"4948edac26d3029858034ef1cd97f2e5401e5c63","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # `assertRaises` but didn\u0027t include support for using it to generate a"},{"line_number":36,"context_line":"        # context manager. If that ever changes, or if we move away from"},{"line_number":37,"context_line":"        # testtools, we should fix this to be more test-like and not rely on"},{"line_number":38,"context_line":"        # try/except/else patterns in tests."},{"line_number":39,"context_line":"        try:"},{"line_number":40,"context_line":"            self.resource_api.create_domain(domain[\u0027id\u0027], domain)"},{"line_number":41,"context_line":"        except exception.Conflict as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_054d0a3e","line":38,"updated":"2017-03-08 19:23:07.000000000","message":"You used the term \"module\" in L30, which indicates to me that this should be a module-level doctstring, but the inline comment is included in just one arbitrary test case. How about making it a class-level docstring, because it appears to apply to every test case in the class?","commit_id":"8f5953e09e2340047e3295bf95f5bda2d52a32fb"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5c2b4de4e4cb215be84bb282e57a1c93f026002e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # `assertRaises` but didn\u0027t include support for using it to generate a"},{"line_number":36,"context_line":"        # context manager. If that ever changes, or if we move away from"},{"line_number":37,"context_line":"        # testtools, we should fix this to be more test-like and not rely on"},{"line_number":38,"context_line":"        # try/except/else patterns in tests."},{"line_number":39,"context_line":"        try:"},{"line_number":40,"context_line":"            self.resource_api.create_domain(domain[\u0027id\u0027], domain)"},{"line_number":41,"context_line":"        except exception.Conflict as e:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_94ff6966","line":38,"in_reply_to":"9a30ddce_054d0a3e","updated":"2017-03-08 20:56:57.000000000","message":"Good point. Done.","commit_id":"8f5953e09e2340047e3295bf95f5bda2d52a32fb"}]}