)]}'
{"keystone/resource/core.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"04649bd9fa94cd8156d66913e93d7f9312d5d4a1","unresolved":false,"context_lines":[{"line_number":906,"context_line":"            \u0027user_enabled_emulation_use_group_config\u0027,"},{"line_number":907,"context_line":"            \u0027user_additional_attribute_mapping\u0027, \u0027group_tree_dn\u0027,"},{"line_number":908,"context_line":"            \u0027group_filter\u0027, \u0027group_objectclass\u0027, \u0027group_id_attribute\u0027,"},{"line_number":909,"context_line":"            \u0027group_name_attribute\u0027, \u0027group_members_are_ids\u0027,"},{"line_number":910,"context_line":"            \u0027group_member_attribute\u0027, \u0027group_desc_attribute\u0027,"},{"line_number":911,"context_line":"            \u0027group_attribute_ignore\u0027, \u0027group_additional_attribute_mapping\u0027,"},{"line_number":912,"context_line":"            \u0027tls_cacertfile\u0027, \u0027tls_cacertdir\u0027, \u0027use_tls\u0027, \u0027tls_req_cert\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_92f8b94b","line":909,"updated":"2017-03-06 19:09:36.000000000","message":"Instead of listing all of these options manually, can we just get the list of ldap options from conf/ldap.py (and remove options marked secret such as password)?","commit_id":"adee9277aaf5a9e58b8070718b8f5399b1573bad"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"9eff542d72a13605b9b8663a467fffa7f6287ed8","unresolved":false,"context_lines":[{"line_number":906,"context_line":"            \u0027user_enabled_emulation_use_group_config\u0027,"},{"line_number":907,"context_line":"            \u0027user_additional_attribute_mapping\u0027, \u0027group_tree_dn\u0027,"},{"line_number":908,"context_line":"            \u0027group_filter\u0027, \u0027group_objectclass\u0027, \u0027group_id_attribute\u0027,"},{"line_number":909,"context_line":"            \u0027group_name_attribute\u0027, \u0027group_members_are_ids\u0027,"},{"line_number":910,"context_line":"            \u0027group_member_attribute\u0027, \u0027group_desc_attribute\u0027,"},{"line_number":911,"context_line":"            \u0027group_attribute_ignore\u0027, \u0027group_additional_attribute_mapping\u0027,"},{"line_number":912,"context_line":"            \u0027tls_cacertfile\u0027, \u0027tls_cacertdir\u0027, \u0027use_tls\u0027, \u0027tls_req_cert\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_2d493e60","line":909,"in_reply_to":"9a30ddce_0ad9c5f3","updated":"2017-03-07 22:35:30.000000000","message":"Ok, makes sense","commit_id":"adee9277aaf5a9e58b8070718b8f5399b1573bad"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"73397382fd2f3e2b22c320b65120bee3ab1e002d","unresolved":false,"context_lines":[{"line_number":906,"context_line":"            \u0027user_enabled_emulation_use_group_config\u0027,"},{"line_number":907,"context_line":"            \u0027user_additional_attribute_mapping\u0027, \u0027group_tree_dn\u0027,"},{"line_number":908,"context_line":"            \u0027group_filter\u0027, \u0027group_objectclass\u0027, \u0027group_id_attribute\u0027,"},{"line_number":909,"context_line":"            \u0027group_name_attribute\u0027, \u0027group_members_are_ids\u0027,"},{"line_number":910,"context_line":"            \u0027group_member_attribute\u0027, \u0027group_desc_attribute\u0027,"},{"line_number":911,"context_line":"            \u0027group_attribute_ignore\u0027, \u0027group_additional_attribute_mapping\u0027,"},{"line_number":912,"context_line":"            \u0027tls_cacertfile\u0027, \u0027tls_cacertdir\u0027, \u0027use_tls\u0027, \u0027tls_req_cert\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_c5585235","line":909,"in_reply_to":"9a30ddce_2d493e60","updated":"2017-03-08 19:18:54.000000000","message":"Richard: perhaps in a separate patch, you should document that reasoning in an inline comment to prevent a similar refactor attempt in the future.","commit_id":"adee9277aaf5a9e58b8070718b8f5399b1573bad"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"01f32a0abda71c19193dbb975f8e2ccbe47f2198","unresolved":false,"context_lines":[{"line_number":906,"context_line":"            \u0027user_enabled_emulation_use_group_config\u0027,"},{"line_number":907,"context_line":"            \u0027user_additional_attribute_mapping\u0027, \u0027group_tree_dn\u0027,"},{"line_number":908,"context_line":"            \u0027group_filter\u0027, \u0027group_objectclass\u0027, \u0027group_id_attribute\u0027,"},{"line_number":909,"context_line":"            \u0027group_name_attribute\u0027, \u0027group_members_are_ids\u0027,"},{"line_number":910,"context_line":"            \u0027group_member_attribute\u0027, \u0027group_desc_attribute\u0027,"},{"line_number":911,"context_line":"            \u0027group_attribute_ignore\u0027, \u0027group_additional_attribute_mapping\u0027,"},{"line_number":912,"context_line":"            \u0027tls_cacertfile\u0027, \u0027tls_cacertdir\u0027, \u0027use_tls\u0027, \u0027tls_req_cert\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_f7f507cb","line":909,"in_reply_to":"9a30ddce_c5585235","updated":"2017-03-08 21:42:58.000000000","message":"I completely agree that this would be good to document somewhere.","commit_id":"adee9277aaf5a9e58b8070718b8f5399b1573bad"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"c3314dc06bd15cba50618317f1bcd034655abb5c","unresolved":false,"context_lines":[{"line_number":906,"context_line":"            \u0027user_enabled_emulation_use_group_config\u0027,"},{"line_number":907,"context_line":"            \u0027user_additional_attribute_mapping\u0027, \u0027group_tree_dn\u0027,"},{"line_number":908,"context_line":"            \u0027group_filter\u0027, \u0027group_objectclass\u0027, \u0027group_id_attribute\u0027,"},{"line_number":909,"context_line":"            \u0027group_name_attribute\u0027, \u0027group_members_are_ids\u0027,"},{"line_number":910,"context_line":"            \u0027group_member_attribute\u0027, \u0027group_desc_attribute\u0027,"},{"line_number":911,"context_line":"            \u0027group_attribute_ignore\u0027, \u0027group_additional_attribute_mapping\u0027,"},{"line_number":912,"context_line":"            \u0027tls_cacertfile\u0027, \u0027tls_cacertdir\u0027, \u0027use_tls\u0027, \u0027tls_req_cert\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_ec73be4b","line":909,"in_reply_to":"ba2be162_92f8b94b","updated":"2017-03-07 15:55:22.000000000","message":"I like your thinking. I need to look more into this. It appears that if you were to grab CONF.ldap.keys() you would end up whitelisting more items than we want even if you remove options marked secret.","commit_id":"adee9277aaf5a9e58b8070718b8f5399b1573bad"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"274fe0b7fa0710c385140aba283f4460b97b3f7b","unresolved":false,"context_lines":[{"line_number":906,"context_line":"            \u0027user_enabled_emulation_use_group_config\u0027,"},{"line_number":907,"context_line":"            \u0027user_additional_attribute_mapping\u0027, \u0027group_tree_dn\u0027,"},{"line_number":908,"context_line":"            \u0027group_filter\u0027, \u0027group_objectclass\u0027, \u0027group_id_attribute\u0027,"},{"line_number":909,"context_line":"            \u0027group_name_attribute\u0027, \u0027group_members_are_ids\u0027,"},{"line_number":910,"context_line":"            \u0027group_member_attribute\u0027, \u0027group_desc_attribute\u0027,"},{"line_number":911,"context_line":"            \u0027group_attribute_ignore\u0027, \u0027group_additional_attribute_mapping\u0027,"},{"line_number":912,"context_line":"            \u0027tls_cacertfile\u0027, \u0027tls_cacertdir\u0027, \u0027use_tls\u0027, \u0027tls_req_cert\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_0ad9c5f3","line":909,"in_reply_to":"ba2be162_92f8b94b","updated":"2017-03-07 20:28:02.000000000","message":"So after talking this over with lance, the reason we don\u0027t/haven\u0027t done this yet is because of security issues. The argument is that it is better to manually and explicitly state the whitelist fields we do allow to be modified than pull everything from CONF and then have to prune out the things we don\u0027t allow. It\u0027s a \u0027deny all and note the acceptions\u0027 vs \u0027accept all and note the exceptions\u0027 case. For example, if we were to pull all ldap keys from CONF into whitelist and remove the elements we don\u0027t want, that might cause a security gap if we later add anything under ldap gropu in CONF file that shouldn\u0027t be whitelisted, and forget to remove the element from the whitelist in the code.","commit_id":"adee9277aaf5a9e58b8070718b8f5399b1573bad"},{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"73397382fd2f3e2b22c320b65120bee3ab1e002d","unresolved":false,"context_lines":[{"line_number":910,"context_line":"            \u0027group_member_attribute\u0027, \u0027group_desc_attribute\u0027,"},{"line_number":911,"context_line":"            \u0027group_attribute_ignore\u0027, \u0027group_additional_attribute_mapping\u0027,"},{"line_number":912,"context_line":"            \u0027tls_cacertfile\u0027, \u0027tls_cacertdir\u0027, \u0027use_tls\u0027, \u0027tls_req_cert\u0027,"},{"line_number":913,"context_line":"            \u0027use_pool\u0027, \u0027pool_size\u0027, \u0027pool_retry_max\u0027, \u0027pool_retry_delay\u0027,"},{"line_number":914,"context_line":"            \u0027pool_connection_timeout\u0027, \u0027pool_connection_lifetime\u0027,"},{"line_number":915,"context_line":"            \u0027use_auth_pool\u0027, \u0027auth_pool_size\u0027, \u0027auth_pool_connection_lifetime\u0027"},{"line_number":916,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_85757a99","line":913,"updated":"2017-03-08 19:18:54.000000000","message":"Because there are multiple items per line here, combining the re-sorting of the list with an addition makes this patch unnecessarily difficult to review. Next time, propose the refactor first, then you\u0027re actual change in a separate review.","commit_id":"adee9277aaf5a9e58b8070718b8f5399b1573bad"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"04649bd9fa94cd8156d66913e93d7f9312d5d4a1","unresolved":false,"context_lines":[{"line_number":917,"context_line":"    }"},{"line_number":918,"context_line":"    sensitive_options \u003d {"},{"line_number":919,"context_line":"        \u0027identity\u0027: [],"},{"line_number":920,"context_line":"        \u0027ldap\u0027: [\u0027password\u0027]"},{"line_number":921,"context_line":"    }"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_928fd9cb","line":920,"updated":"2017-03-06 19:09:36.000000000","message":"Similar could be done here to gather all ldap options marked secret.","commit_id":"adee9277aaf5a9e58b8070718b8f5399b1573bad"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"da7e8b1014c7cf6d2c93884afa7222ba7ecf212f","unresolved":false,"context_lines":[{"line_number":891,"context_line":""},{"line_number":892,"context_line":"    driver_namespace \u003d \u0027keystone.resource.domain_config\u0027"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    # We explicitly state each whitelisted option instead of pull all ldap"},{"line_number":895,"context_line":"    # options from CONF and selectively prune options to prevent a security"},{"line_number":896,"context_line":"    # lapse. That way if a new ldap CONF key/value were to be added it won\u0027t"},{"line_number":897,"context_line":"    # automatically be added to the whitelisted options unless that is what is"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_1298bb77","line":894,"range":{"start_line":894,"start_character":61,"end_line":894,"end_character":65},"updated":"2017-03-09 20:42:48.000000000","message":"pulling","commit_id":"444f558b297428851ac1bb64cbe8856b71c9b560"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"da7e8b1014c7cf6d2c93884afa7222ba7ecf212f","unresolved":false,"context_lines":[{"line_number":892,"context_line":"    driver_namespace \u003d \u0027keystone.resource.domain_config\u0027"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    # We explicitly state each whitelisted option instead of pull all ldap"},{"line_number":895,"context_line":"    # options from CONF and selectively prune options to prevent a security"},{"line_number":896,"context_line":"    # lapse. That way if a new ldap CONF key/value were to be added it won\u0027t"},{"line_number":897,"context_line":"    # automatically be added to the whitelisted options unless that is what is"},{"line_number":898,"context_line":"    # intended, in which case, we explicitly add it to the list ourselves."}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_928aeb19","line":895,"range":{"start_line":895,"start_character":40,"end_line":895,"end_character":45},"updated":"2017-03-09 20:42:48.000000000","message":"pruning","commit_id":"444f558b297428851ac1bb64cbe8856b71c9b560"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"da7e8b1014c7cf6d2c93884afa7222ba7ecf212f","unresolved":false,"context_lines":[{"line_number":892,"context_line":"    driver_namespace \u003d \u0027keystone.resource.domain_config\u0027"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    # We explicitly state each whitelisted option instead of pull all ldap"},{"line_number":895,"context_line":"    # options from CONF and selectively prune options to prevent a security"},{"line_number":896,"context_line":"    # lapse. That way if a new ldap CONF key/value were to be added it won\u0027t"},{"line_number":897,"context_line":"    # automatically be added to the whitelisted options unless that is what is"},{"line_number":898,"context_line":"    # intended, in which case, we explicitly add it to the list ourselves."}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_127fdb15","line":895,"range":{"start_line":895,"start_character":46,"end_line":895,"end_character":53},"updated":"2017-03-09 20:42:48.000000000","message":"them","commit_id":"444f558b297428851ac1bb64cbe8856b71c9b560"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"da7e8b1014c7cf6d2c93884afa7222ba7ecf212f","unresolved":false,"context_lines":[{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    # We explicitly state each whitelisted option instead of pull all ldap"},{"line_number":895,"context_line":"    # options from CONF and selectively prune options to prevent a security"},{"line_number":896,"context_line":"    # lapse. That way if a new ldap CONF key/value were to be added it won\u0027t"},{"line_number":897,"context_line":"    # automatically be added to the whitelisted options unless that is what is"},{"line_number":898,"context_line":"    # intended, in which case, we explicitly add it to the list ourselves."},{"line_number":899,"context_line":"    whitelisted_options \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_5275d32f","line":896,"range":{"start_line":896,"start_character":71,"end_line":896,"end_character":74},"updated":"2017-03-09 20:42:48.000000000","message":"wouldn\u0027t","commit_id":"444f558b297428851ac1bb64cbe8856b71c9b560"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"da7e8b1014c7cf6d2c93884afa7222ba7ecf212f","unresolved":false,"context_lines":[{"line_number":894,"context_line":"    # We explicitly state each whitelisted option instead of pull all ldap"},{"line_number":895,"context_line":"    # options from CONF and selectively prune options to prevent a security"},{"line_number":896,"context_line":"    # lapse. That way if a new ldap CONF key/value were to be added it won\u0027t"},{"line_number":897,"context_line":"    # automatically be added to the whitelisted options unless that is what is"},{"line_number":898,"context_line":"    # intended, in which case, we explicitly add it to the list ourselves."},{"line_number":899,"context_line":"    whitelisted_options \u003d {"},{"line_number":900,"context_line":"        \u0027identity\u0027: [\u0027driver\u0027, \u0027list_limit\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_f29c075f","line":897,"range":{"start_line":897,"start_character":76,"end_line":897,"end_character":78},"updated":"2017-03-09 20:42:48.000000000","message":"was","commit_id":"444f558b297428851ac1bb64cbe8856b71c9b560"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"da7e8b1014c7cf6d2c93884afa7222ba7ecf212f","unresolved":false,"context_lines":[{"line_number":895,"context_line":"    # options from CONF and selectively prune options to prevent a security"},{"line_number":896,"context_line":"    # lapse. That way if a new ldap CONF key/value were to be added it won\u0027t"},{"line_number":897,"context_line":"    # automatically be added to the whitelisted options unless that is what is"},{"line_number":898,"context_line":"    # intended, in which case, we explicitly add it to the list ourselves."},{"line_number":899,"context_line":"    whitelisted_options \u003d {"},{"line_number":900,"context_line":"        \u0027identity\u0027: [\u0027driver\u0027, \u0027list_limit\u0027],"},{"line_number":901,"context_line":"        \u0027ldap\u0027: ["}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_52acf38b","line":898,"range":{"start_line":898,"start_character":14,"end_line":898,"end_character":15},"updated":"2017-03-09 20:42:48.000000000","message":".","commit_id":"444f558b297428851ac1bb64cbe8856b71c9b560"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"da7e8b1014c7cf6d2c93884afa7222ba7ecf212f","unresolved":false,"context_lines":[{"line_number":895,"context_line":"    # options from CONF and selectively prune options to prevent a security"},{"line_number":896,"context_line":"    # lapse. That way if a new ldap CONF key/value were to be added it won\u0027t"},{"line_number":897,"context_line":"    # automatically be added to the whitelisted options unless that is what is"},{"line_number":898,"context_line":"    # intended, in which case, we explicitly add it to the list ourselves."},{"line_number":899,"context_line":"    whitelisted_options \u003d {"},{"line_number":900,"context_line":"        \u0027identity\u0027: [\u0027driver\u0027, \u0027list_limit\u0027],"},{"line_number":901,"context_line":"        \u0027ldap\u0027: ["}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_b2bd2fb9","line":898,"range":{"start_line":898,"start_character":16,"end_line":898,"end_character":18},"updated":"2017-03-09 20:42:48.000000000","message":"In","commit_id":"444f558b297428851ac1bb64cbe8856b71c9b560"}],"releasenotes/notes/add-group-members-are-ids-whitelist-687833a3edd6657a.yaml":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"da7e8b1014c7cf6d2c93884afa7222ba7ecf212f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ldap config group_members_are_ids has been added to the whitelisted"},{"line_number":5,"context_line":"    options allowing it to now be used in `keystone-manage"},{"line_number":6,"context_line":"    domain_config_upload`"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a30ddce_521f93b6","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":5},"updated":"2017-03-09 20:42:48.000000000","message":"[`bug 1527759 \u003chttps://bugs.launchpad.net/keystone/+bug/1670382\u003e`_]","commit_id":"444f558b297428851ac1bb64cbe8856b71c9b560"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"da7e8b1014c7cf6d2c93884afa7222ba7ecf212f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ldap config group_members_are_ids has been added to the whitelisted"},{"line_number":5,"context_line":"    options allowing it to now be used in `keystone-manage"},{"line_number":6,"context_line":"    domain_config_upload`"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a30ddce_12d43bea","line":4,"range":{"start_line":4,"start_character":42,"end_line":4,"end_character":45},"updated":"2017-03-09 20:42:48.000000000","message":"have","commit_id":"444f558b297428851ac1bb64cbe8856b71c9b560"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"da7e8b1014c7cf6d2c93884afa7222ba7ecf212f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ldap config group_members_are_ids has been added to the whitelisted"},{"line_number":5,"context_line":"    options allowing it to now be used in `keystone-manage"},{"line_number":6,"context_line":"    domain_config_upload`"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a30ddce_b280cfc1","line":6,"range":{"start_line":5,"start_character":42,"end_line":6,"end_character":25},"updated":"2017-03-09 20:42:48.000000000","message":"Not just this CLI but also the domain config API.","commit_id":"444f558b297428851ac1bb64cbe8856b71c9b560"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0f6b7ab4ffb217caa82f35e9ef14b455a8318b8f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - [`bug 1527759 \u003chttps://bugs.launchpad.net/keystone/+bug/1670382\u003e`_]"},{"line_number":4,"context_line":"    The ldap config group_members_are_ids have been added to the whitelisted"},{"line_number":5,"context_line":"    options allowing it to now be used in the domain config API and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_7cb99814","line":2,"updated":"2017-03-10 20:38:11.000000000","message":"The undocumented convention for these is to use the bug number in the name of the release note, like the following\n\nhttps://github.com/openstack/keystone/blob/master/releasenotes/notes/bug-1638603-354ee4167e6e.yaml","commit_id":"182da78c5567fefa2f78646f9ab0bc0e412fa264"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"996de505f13bbae766ed7db011bbdb813864f29f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - [`bug 1527759 \u003chttps://bugs.launchpad.net/keystone/+bug/1670382\u003e`_]"},{"line_number":4,"context_line":"    The ldap config group_members_are_ids have been added to the whitelisted"},{"line_number":5,"context_line":"    options allowing it to now be used in the domain config API and"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_adcd9c32","line":2,"in_reply_to":"9a30ddce_7cb99814","updated":"2017-03-10 23:05:17.000000000","message":"Ahh thanks lance","commit_id":"182da78c5567fefa2f78646f9ab0bc0e412fa264"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"0fec96165d5d0b8f0220da25ea487a646ca69a10","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1527759 \u003chttps://bugs.launchpad.net/keystone/+bug/1670382\u003e`_]"},{"line_number":5,"context_line":"    The ldap config group_members_are_ids have been added to the whitelisted"},{"line_number":6,"context_line":"    options allowing it to now be used in the domain config API and"},{"line_number":7,"context_line":"    `keystone-manage domain_config_upload`"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a30ddce_9ab80777","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":17},"updated":"2017-03-11 06:01:45.000000000","message":"Oops, should be 1670382","commit_id":"16d97b23a88957814771a05ff2a66e1bf76c735d"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"ef8bb8864fe866f55c03d133f005c4bdab854c24","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1527759 \u003chttps://bugs.launchpad.net/keystone/+bug/1670382\u003e`_]"},{"line_number":5,"context_line":"    The ldap config group_members_are_ids have been added to the whitelisted"},{"line_number":6,"context_line":"    options allowing it to now be used in the domain config API and"},{"line_number":7,"context_line":"    `keystone-manage domain_config_upload`"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a1ced50_69694a25","line":4,"in_reply_to":"9a30ddce_67755cc9","updated":"2017-03-20 12:09:34.000000000","message":"Done","commit_id":"16d97b23a88957814771a05ff2a66e1bf76c735d"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"ef8bb8864fe866f55c03d133f005c4bdab854c24","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1527759 \u003chttps://bugs.launchpad.net/keystone/+bug/1670382\u003e`_]"},{"line_number":5,"context_line":"    The ldap config group_members_are_ids have been added to the whitelisted"},{"line_number":6,"context_line":"    options allowing it to now be used in the domain config API and"},{"line_number":7,"context_line":"    `keystone-manage domain_config_upload`"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a1ced50_496e4e30","line":4,"range":{"start_line":4,"start_character":10,"end_line":4,"end_character":17},"in_reply_to":"9a30ddce_9ab80777","updated":"2017-03-20 12:09:34.000000000","message":"Done","commit_id":"16d97b23a88957814771a05ff2a66e1bf76c735d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"dbc571ff153a174d289a661fa0e2fa5f67c1f0a3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1527759 \u003chttps://bugs.launchpad.net/keystone/+bug/1670382\u003e`_]"},{"line_number":5,"context_line":"    The ldap config group_members_are_ids have been added to the whitelisted"},{"line_number":6,"context_line":"    options allowing it to now be used in the domain config API and"},{"line_number":7,"context_line":"    `keystone-manage domain_config_upload`"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a30ddce_67755cc9","line":4,"in_reply_to":"9a30ddce_9ab80777","updated":"2017-03-13 14:59:05.000000000","message":"We should also rename this file to be consistent with some of the release note conventions Steve did.\n\n  bug-1670382-687833a3edd6657a.yaml\n\nLike how this one is named: \n\nhttps://github.com/openstack/keystone/blob/master/releasenotes/notes/bug-1017606-98313bb4c1edf250.yaml","commit_id":"16d97b23a88957814771a05ff2a66e1bf76c735d"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"0fec96165d5d0b8f0220da25ea487a646ca69a10","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1527759 \u003chttps://bugs.launchpad.net/keystone/+bug/1670382\u003e`_]"},{"line_number":5,"context_line":"    The ldap config group_members_are_ids have been added to the whitelisted"},{"line_number":6,"context_line":"    options allowing it to now be used in the domain config API and"},{"line_number":7,"context_line":"    `keystone-manage domain_config_upload`"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a30ddce_daaeff2c","line":5,"range":{"start_line":5,"start_character":42,"end_line":5,"end_character":46},"updated":"2017-03-11 06:01:45.000000000","message":"actually has (which you originally had was correct single it\u0027s a singular option being added. It ending with an \u0027s\u0027 threw me off.","commit_id":"16d97b23a88957814771a05ff2a66e1bf76c735d"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"ef8bb8864fe866f55c03d133f005c4bdab854c24","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1527759 \u003chttps://bugs.launchpad.net/keystone/+bug/1670382\u003e`_]"},{"line_number":5,"context_line":"    The ldap config group_members_are_ids have been added to the whitelisted"},{"line_number":6,"context_line":"    options allowing it to now be used in the domain config API and"},{"line_number":7,"context_line":"    `keystone-manage domain_config_upload`"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a1ced50_897846f4","line":5,"range":{"start_line":5,"start_character":42,"end_line":5,"end_character":46},"in_reply_to":"9a30ddce_daaeff2c","updated":"2017-03-20 12:09:34.000000000","message":"Done","commit_id":"16d97b23a88957814771a05ff2a66e1bf76c735d"}],"releasenotes/notes/bug-1670382-ee851ba4f364d608.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f0634a52cd1a9418dea0eecb32db8ea97668610a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    [`bug 1670382 \u003chttps://bugs.launchpad.net/keystone/+bug/1670382\u003e`_]"},{"line_number":5,"context_line":"    The ldap config group_members_are_ids has been added to the whitelisted"},{"line_number":6,"context_line":"    options allowing it to now be used in the domain config API and"},{"line_number":7,"context_line":"    `keystone-manage domain_config_upload`"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffe62b97_052494c5","line":5,"updated":"2017-03-23 20:30:57.000000000","message":"nit: `group_members_are_ids`","commit_id":"53a47b779e19d4140f059666ee19483da9ca5ea6"}]}