)]}'
{"keystone/assignment/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7de7f1ac0554002b86b559bd7d331da7dd9c7abc","unresolved":false,"context_lines":[{"line_number":1118,"context_line":"        self.assignment_api.delete_tokens_for_role_assignments(role_id)"},{"line_number":1119,"context_line":"        self.assignment_api.delete_role_assignments(role_id)"},{"line_number":1120,"context_line":"        self.driver.delete_role(role_id)"},{"line_number":1121,"context_line":"        notifications.Audit.deleted(self._ROLE, role_id, initiator)"},{"line_number":1122,"context_line":"        self.get_role.invalidate(self, role_id)"},{"line_number":1123,"context_line":"        COMPUTED_ASSIGNMENTS_REGION.invalidate()"},{"line_number":1124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_47646021","side":"PARENT","line":1121,"updated":"2017-03-20 21:19:58.000000000","message":"Actually - this should probably stay around. Notifications weren\u0027t implemented solely for the use of revocation events. We started using them  as a mechanism to trigger revocation events afterwords.\n\nThere could be applications outside of OpenStack consuming these.","commit_id":"2da47afd8bc8eb65667a07733c9225d1d78b56e2"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"deafa5cc9c94fa25687f77def058a575e0322e96","unresolved":false,"context_lines":[{"line_number":1118,"context_line":"        self.assignment_api.delete_tokens_for_role_assignments(role_id)"},{"line_number":1119,"context_line":"        self.assignment_api.delete_role_assignments(role_id)"},{"line_number":1120,"context_line":"        self.driver.delete_role(role_id)"},{"line_number":1121,"context_line":"        notifications.Audit.deleted(self._ROLE, role_id, initiator)"},{"line_number":1122,"context_line":"        self.get_role.invalidate(self, role_id)"},{"line_number":1123,"context_line":"        COMPUTED_ASSIGNMENTS_REGION.invalidate()"},{"line_number":1124,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_2472d97b","side":"PARENT","line":1121,"in_reply_to":"1a1ced50_47646021","updated":"2017-03-21 15:53:37.000000000","message":"Ahh, okay. Cause when looking within keystone there is nothing that that line in assignments is being used for other than revocation. For example, I know that this \nhttps://github.com/openstack/keystone/blob/master/keystone/assignment/core.py#L70-L74\nis an example of using notification for something other than revocation. Did not consider anything using notifications outside of openstack. Better safe than sorry, and all the original tests are happy with the minimal cleanup.","commit_id":"2da47afd8bc8eb65667a07733c9225d1d78b56e2"}]}