)]}'
{"keystone/identity/backends/ldap/core.py":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"1e5d06b9cd42c612bb3754bd8f04cca85aef94fb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        return self.group.get_all_filtered(hints)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def list_users_in_group(self, group_id, hints):"},{"line_number":120,"context_line":"        all_users \u003d {user[\u0027id\u0027]:user for user in self.user.get_all()}"},{"line_number":121,"context_line":"        users \u003d []"},{"line_number":122,"context_line":"        for user_key in self.group.list_group_users(group_id):"},{"line_number":123,"context_line":"            if self.conf.ldap.group_members_are_ids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_ff124861","line":120,"range":{"start_line":120,"start_character":49,"end_line":120,"end_character":66},"updated":"2017-03-20 12:56:48.000000000","message":"If the operator has set a limit on the number of entries that can be returned by ldap, might this fail to retrieve them all - and hence result in an error below?","commit_id":"efad6e92ff5502eafb87d600c033434248766903"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"30cb49778d5f8c332467638cb7077d697f3e0bf7","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        return self.group.get_all_filtered(hints)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def list_users_in_group(self, group_id, hints):"},{"line_number":120,"context_line":"        all_users \u003d {user[\u0027id\u0027]:user for user in self.user.get_all()}"},{"line_number":121,"context_line":"        users \u003d []"},{"line_number":122,"context_line":"        for user_key in self.group.list_group_users(group_id):"},{"line_number":123,"context_line":"            if self.conf.ldap.group_members_are_ids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_23ada631","line":120,"range":{"start_line":120,"start_character":49,"end_line":120,"end_character":66},"in_reply_to":"1a1ced50_ff124861","updated":"2017-03-20 16:04:09.000000000","message":"Well, I made a mistake here - I should have written self.user.get_all(hints\u003dhints). Then yes, it would end up unnecessarily triggering the error.\n\nI suppose disregarding the list limit could potentially have a worse performance impact than querying each user one at a time, I\u0027ll have to think about whether there is a good way to do this.","commit_id":"efad6e92ff5502eafb87d600c033434248766903"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"6ac52fd591ba1245f2f96272a8d95d9e9efd2f26","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        group_members \u003d self.group.list_group_users(group_id)"},{"line_number":129,"context_line":"        for user_id in self._transform_group_member_ids(group_members):"},{"line_number":130,"context_line":"            try:"},{"line_number":131,"context_line":"                users.append(self.user.get_filtered(user_id))"},{"line_number":132,"context_line":"            except exception.UserNotFound:"},{"line_number":133,"context_line":"                msg \u003d (\u0027Group member `%(user_id)s` for group `%(group_id)s`\u0027"},{"line_number":134,"context_line":"                       \u0027 not found in the directory. The user should be\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_4a67cae8","line":131,"updated":"2017-03-22 01:39:53.000000000","message":"If I\u0027m understanding this correctly - this is still doing the round trip, right? It\u0027s building the original list on line 128 and then double checking that each user exists in the directory on line 131?","commit_id":"6d1c88ce88f88015d88ed84d95867a00067a0aeb"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"f23d288a7e6dfeb446a38c025883baac5b8f2735","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        group_members \u003d self.group.list_group_users(group_id)"},{"line_number":129,"context_line":"        for user_id in self._transform_group_member_ids(group_members):"},{"line_number":130,"context_line":"            try:"},{"line_number":131,"context_line":"                users.append(self.user.get_filtered(user_id))"},{"line_number":132,"context_line":"            except exception.UserNotFound:"},{"line_number":133,"context_line":"                msg \u003d (\u0027Group member `%(user_id)s` for group `%(group_id)s`\u0027"},{"line_number":134,"context_line":"                       \u0027 not found in the directory. The user should be\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_3ee567db","line":131,"in_reply_to":"1a1ced50_4a67cae8","updated":"2017-03-22 08:00:02.000000000","message":"That\u0027s correct. This patch does nothing to speed up listing all users in a group, it only enhances looking up one user.","commit_id":"6d1c88ce88f88015d88ed84d95867a00067a0aeb"}]}