)]}'
{"keystone/oauth1/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b373f197c7afbe96e0450fc50089ff625948a752","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    def delete_access_token(self, user_id, access_token_id, initiator\u003dNone):"},{"line_number":169,"context_line":"        ret \u003d self.driver.delete_access_token(user_id, access_token_id)"},{"line_number":170,"context_line":"        notifications.Audit.deleted(self._ACCESS_TOKEN, access_token_id,"},{"line_number":171,"context_line":"                                    initiator)"},{"line_number":172,"context_line":"        return ret"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def create_request_token(self, consumer_id, requested_project,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_ca3bf5cf","side":"PARENT","line":171,"updated":"2017-03-20 21:24:03.000000000","message":"In looking through the notification implementation - we have a dedicated interface for internal notifications. This isn\u0027t using that so I don\u0027t think we should be removing it. I\u0027ve updated my patch with the same comment.\n\nWe should be able to remove the callback function that consumes the notification and get the same result.","commit_id":"2da47afd8bc8eb65667a07733c9225d1d78b56e2"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"3425fa0d8b4b199f8c415595d39263ba417a1c9c","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    def delete_access_token(self, user_id, access_token_id, initiator\u003dNone):"},{"line_number":169,"context_line":"        ret \u003d self.driver.delete_access_token(user_id, access_token_id)"},{"line_number":170,"context_line":"        notifications.Audit.deleted(self._ACCESS_TOKEN, access_token_id,"},{"line_number":171,"context_line":"                                    initiator)"},{"line_number":172,"context_line":"        return ret"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def create_request_token(self, consumer_id, requested_project,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_641691f2","side":"PARENT","line":171,"in_reply_to":"1a1ced50_ca3bf5cf","updated":"2017-03-21 15:55:28.000000000","message":"Done","commit_id":"2da47afd8bc8eb65667a07733c9225d1d78b56e2"}],"keystone/revoke/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"8fd355d85dcf7f369469cc4f4fa23d47542924c9","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            notifications.ACTIONS.deleted: ["},{"line_number":125,"context_line":"                [\u0027OS-TRUST:trust\u0027, self._trust_callback],"},{"line_number":126,"context_line":"                [\u0027OS-OAUTH1:consumer\u0027, self._consumer_callback],"},{"line_number":127,"context_line":"                [\u0027OS-OAUTH1:access_token\u0027, self._access_token_callback],"},{"line_number":128,"context_line":"                [\u0027role\u0027, self._role_callback],"},{"line_number":129,"context_line":"                [\u0027user\u0027, self._user_callback],"},{"line_number":130,"context_line":"                [\u0027project\u0027, self._project_callback],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_c7dcd0e6","side":"PARENT","line":127,"updated":"2017-03-20 21:20:53.000000000","message":"I think we can get by with just removing this bit. I think we should still publish the notification for deleting access tokens since other applications could be consuming those notifications.\n\nI\u0027ve updated https://review.openstack.org/#/c/444424/ with the same comment.","commit_id":"2da47afd8bc8eb65667a07733c9225d1d78b56e2"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"3425fa0d8b4b199f8c415595d39263ba417a1c9c","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            notifications.ACTIONS.deleted: ["},{"line_number":125,"context_line":"                [\u0027OS-TRUST:trust\u0027, self._trust_callback],"},{"line_number":126,"context_line":"                [\u0027OS-OAUTH1:consumer\u0027, self._consumer_callback],"},{"line_number":127,"context_line":"                [\u0027OS-OAUTH1:access_token\u0027, self._access_token_callback],"},{"line_number":128,"context_line":"                [\u0027role\u0027, self._role_callback],"},{"line_number":129,"context_line":"                [\u0027user\u0027, self._user_callback],"},{"line_number":130,"context_line":"                [\u0027project\u0027, self._project_callback],"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_440275b5","side":"PARENT","line":127,"in_reply_to":"1a1ced50_c7dcd0e6","updated":"2017-03-21 15:55:28.000000000","message":"I see, replied to your comment on that review.","commit_id":"2da47afd8bc8eb65667a07733c9225d1d78b56e2"}]}