)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ba6e8905fb999175e9772b538d1a778fea592dea","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch removes a method that wasn\u0027t being used anymore anywhere"},{"line_number":10,"context_line":"except for a single unit test. In addition, we no longer need to store"},{"line_number":11,"context_line":"the revocation event when the token provider API will rebuild the"},{"line_number":12,"context_line":"token context at validation time."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie92b238b0968a23bca3f0f57879369ea74298b8d"},{"line_number":15,"context_line":"partial-bug: 1671887"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_877ef467","line":12,"updated":"2017-03-22 19:01:53.000000000","message":"Per my other comment, we should try and include a link to test coverage ensuring the removal of this method isn\u0027t going to result in regression as a result of gaps in testing.\n\nWe should also clarify in the commit message that this isn\u0027t something that is exposed to an external API, so it\u0027s obvious that we aren\u0027t going to remove something end-users depend on.","commit_id":"dac2f84d5b6aab62f7a6d4e2f8dc31cab05608aa"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"6b63ff9c912382db7b558fc37867825c004d9a92","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch removes a method that wasn\u0027t being used anymore anywhere"},{"line_number":10,"context_line":"except for a single unit test. In addition, we no longer need to store"},{"line_number":11,"context_line":"the revocation event when the token provider API will rebuild the"},{"line_number":12,"context_line":"token context at validation time."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie92b238b0968a23bca3f0f57879369ea74298b8d"},{"line_number":15,"context_line":"partial-bug: 1671887"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_12405235","line":12,"in_reply_to":"1a1ced50_877ef467","updated":"2017-03-23 16:41:41.000000000","message":"Done","commit_id":"dac2f84d5b6aab62f7a6d4e2f8dc31cab05608aa"}],"keystone/revoke/core.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ba6e8905fb999175e9772b538d1a778fea592dea","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        self.revoke("},{"line_number":167,"context_line":"            revoke_model.RevokeEvent(project_id\u003dproject_id, user_id\u003duser_id))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def revoke_by_project_role_assignment(self, project_id, role_id):"},{"line_number":170,"context_line":"        self.revoke(revoke_model.RevokeEvent(project_id\u003dproject_id,"},{"line_number":171,"context_line":"                                             role_id\u003drole_id))"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_870b5423","side":"PARENT","line":169,"updated":"2017-03-22 19:01:53.000000000","message":"To the best of my knowledge - it doesn\u0027t look like this is called anywhere. It would be nice to double check to make sure we have a test somewhere the ensure we do the following:\n\n  - give a user a role on a project\n  - validate we can get a token\n  - removes role assignment from user on project\n  - checks that the token is invalid\n\nOnly because that\u0027s what this would have been used for. If we have pre-existing test coverage then we know we\u0027re not going to regress. A link to the test would be a good thing to put into the commit message, too (that goes for the patches I have up to, if applicable).","commit_id":"91f7299e88c677e9980f7d99e73f3676f7c50545"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"6b63ff9c912382db7b558fc37867825c004d9a92","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        self.revoke("},{"line_number":167,"context_line":"            revoke_model.RevokeEvent(project_id\u003dproject_id, user_id\u003duser_id))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def revoke_by_project_role_assignment(self, project_id, role_id):"},{"line_number":170,"context_line":"        self.revoke(revoke_model.RevokeEvent(project_id\u003dproject_id,"},{"line_number":171,"context_line":"                                             role_id\u003drole_id))"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_b2293e8c","side":"PARENT","line":169,"in_reply_to":"1a1ced50_870b5423","updated":"2017-03-23 16:41:41.000000000","message":"Done","commit_id":"91f7299e88c677e9980f7d99e73f3676f7c50545"}],"keystone/tests/unit/test_revoke.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"ba6e8905fb999175e9772b538d1a778fea592dea","unresolved":false,"context_lines":[{"line_number":586,"context_line":"        self.events.append(event)"},{"line_number":587,"context_line":"        return event"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    def _revoke_by_project_role_assignment(self, project_id, role_id):"},{"line_number":590,"context_line":"        event \u003d add_event(self.revoke_events,"},{"line_number":591,"context_line":"                          revoke_model.RevokeEvent(project_id\u003dproject_id,"},{"line_number":592,"context_line":"                                                   role_id\u003drole_id))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_bc2303bc","side":"PARENT","line":589,"updated":"2017-03-22 19:01:53.000000000","message":"the `test_cleanup` method looks like the only thing that calls this. This could be removed, too.","commit_id":"91f7299e88c677e9980f7d99e73f3676f7c50545"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"6b63ff9c912382db7b558fc37867825c004d9a92","unresolved":false,"context_lines":[{"line_number":586,"context_line":"        self.events.append(event)"},{"line_number":587,"context_line":"        return event"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    def _revoke_by_project_role_assignment(self, project_id, role_id):"},{"line_number":590,"context_line":"        event \u003d add_event(self.revoke_events,"},{"line_number":591,"context_line":"                          revoke_model.RevokeEvent(project_id\u003dproject_id,"},{"line_number":592,"context_line":"                                                   role_id\u003drole_id))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_924b625f","side":"PARENT","line":589,"in_reply_to":"1a1ced50_bc2303bc","updated":"2017-03-23 16:41:41.000000000","message":"Done","commit_id":"91f7299e88c677e9980f7d99e73f3676f7c50545"}]}