)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cf402af7c0c20708039e84aa05d9b77308e20ced","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Richard Avelar \u003ccsravelar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-22 23:32:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address comments from Steve Mar Policy in Code 5"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This just cleans up a few comments from this review [1]."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_a5667eea","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":31},"updated":"2017-03-23 01:45:21.000000000","message":"Martinelli*","commit_id":"3c35f5bd23c9f7af80271da1d75e362d4cc5c077"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"1036bb50a6e19bcb6a63dfb722abe85fb6a85f90","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Richard Avelar \u003ccsravelar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-22 23:32:00 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address comments from Steve Mar Policy in Code 5"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This just cleans up a few comments from this review [1]."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffe62b97_a582614e","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":31},"in_reply_to":"1a1ced50_a5667eea","updated":"2017-03-24 15:13:58.000000000","message":"Too long for title character limit","commit_id":"3c35f5bd23c9f7af80271da1d75e362d4cc5c077"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"24870baea3cb16f5cd1965b532978de6da9b41f0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address comments from Steve Mar Policy in Code 5"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This just cleans up a few comments from this review [1]."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1]: https://review.openstack.org/#/c/435757/"},{"line_number":12,"context_line":"Partially-Implements: blueprint policy-in-code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_4f64e0e4","line":9,"updated":"2017-03-23 18:14:41.000000000","message":"I think we could reword this to say this commit is removing the default policy file *and* addressing a couple minor comments from a previous patch.\n\nThen we could close out the blueprint, too:\n\n  implements blueprint policy-in-code","commit_id":"3c35f5bd23c9f7af80271da1d75e362d4cc5c077"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"1036bb50a6e19bcb6a63dfb722abe85fb6a85f90","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address comments from Steve Mar Policy in Code 5"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This just cleans up a few comments from this review [1]."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1]: https://review.openstack.org/#/c/435757/"},{"line_number":12,"context_line":"Partially-Implements: blueprint policy-in-code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffe62b97_65ab39d6","line":9,"in_reply_to":"1a1ced50_4f64e0e4","updated":"2017-03-24 15:13:58.000000000","message":"Done","commit_id":"3c35f5bd23c9f7af80271da1d75e362d4cc5c077"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"8a4de6b4959cdd1fcab3deacb789eac949212872","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ubuntu \u003ccsravelar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-24 15:10:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address comments from Policy in Code 5"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch addresses a few minor comments from review [1]."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ffe62b97_cfc029e4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":38},"updated":"2017-03-29 16:20:00.000000000","message":"nit: Moving forward. I\u0027d rather have you title explicitly with what you addressed rather than ambiguously mention \"comments in a prior review\". And also include the description of the changes in the commit message. Reduces the jumping around between reviews and hunting for old comments from reviewers.","commit_id":"678a10b4aff4698b38e980de3dc510908d341ad5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bd68bd363e940c40ffa721e5ef874d9ed063211c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address comments from Policy in Code 5"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch addresses a few minor comments from review [1]."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1]: https://review.openstack.org/#/c/435757/"},{"line_number":12,"context_line":"Implements blueprint policy-in-code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ffe62b97_a98bda65","line":9,"updated":"2017-03-28 15:43:11.000000000","message":"Tip: you can always link things automatically in gerrit using the Change-Id of the patch you want to reference:\n\n  Id6e3c0ac54b21d85e68625a5b52fe2559fb70f24\n\nSometimes this makes wording/formatting of commit messages cleaner. Not that it needs to change for this patch, just documenting it here in case it\u0027s useful.","commit_id":"678a10b4aff4698b38e980de3dc510908d341ad5"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"e2a90d1ac9ea0d9e36adeef5cc9b869df8bcc8ed","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address comments from Policy in Code 5"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch addresses a few minor comments from review [1]."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1]: https://review.openstack.org/#/c/435757/"},{"line_number":12,"context_line":"Implements blueprint policy-in-code"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ffe62b97_ffdbd4e9","line":9,"in_reply_to":"ffe62b97_a98bda65","updated":"2017-03-28 16:21:44.000000000","message":"Thanks lance, useful tip","commit_id":"678a10b4aff4698b38e980de3dc510908d341ad5"}],"etc/policy.json":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"cf402af7c0c20708039e84aa05d9b77308e20ced","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a1ced50_c5b8da2c","side":"PARENT","updated":"2017-03-23 01:45:21.000000000","message":"i didn\u0027t realize this was being done here: https://review.openstack.org/#/c/437388/1\n\nyou can undo this change and the tests/ changes to make this easier","commit_id":"bfc9282da7df70af1219151da173cdc323be6bfd"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"1036bb50a6e19bcb6a63dfb722abe85fb6a85f90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ffe62b97_c540c50a","side":"PARENT","in_reply_to":"1a1ced50_2f408435","updated":"2017-03-24 15:13:58.000000000","message":"With it being proposed a while back before the moving of all the folders and files around theres a nasty merge conflict that I can\u0027t simply just rebase and fix. I\u0027d have to cherry pick/squash stuff and since I am lazy, its easier/faster to just propose a new one off what is now merged.","commit_id":"bfc9282da7df70af1219151da173cdc323be6bfd"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"1036bb50a6e19bcb6a63dfb722abe85fb6a85f90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ffe62b97_258e5178","side":"PARENT","in_reply_to":"1a1ced50_c5b8da2c","updated":"2017-03-24 15:13:58.000000000","message":"Done","commit_id":"bfc9282da7df70af1219151da173cdc323be6bfd"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"24870baea3cb16f5cd1965b532978de6da9b41f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a1ced50_2f408435","side":"PARENT","in_reply_to":"1a1ced50_c5b8da2c","updated":"2017-03-23 18:14:41.000000000","message":"Yeah - that way we would have two patches:\n\n - one patch to address comments from part 5\n - one patch to remove the policy file from source and refactor the tests\n\nI threw that up some time ago once all the patches to move policies into code were proposed. My thinking behind it was that we should have a patch the removes the policy file from source and we should use that to close the blueprint, since that should prove we moved all policy into code by default.","commit_id":"bfc9282da7df70af1219151da173cdc323be6bfd"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"c229f5f3e2c05475cf78c4d22f380c0860e25dc0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ffe62b97_697cb282","side":"PARENT","in_reply_to":"ffe62b97_258e5178","updated":"2017-03-28 15:40:33.000000000","message":"Update: I\u0027ve abandon https://review.openstack.org/#/c/437388/1 in favor of this approach.","commit_id":"bfc9282da7df70af1219151da173cdc323be6bfd"}],"keystone/tests/unit/test_policy.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"24870baea3cb16f5cd1965b532978de6da9b41f0","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        return rules"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    def test_json_examples_have_matching_entries(self):"},{"line_number":191,"context_line":"        policy_keys \u003d self._get_default_policy_rules() "},{"line_number":192,"context_line":"        cloud_policy_keys \u003d self._load_entries("},{"line_number":193,"context_line":"            unit.dirs.etc(\u0027policy.v3cloudsample.json\u0027))"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_8f8c1881","line":191,"updated":"2017-03-23 18:14:41.000000000","message":"Trailing whitespace","commit_id":"3c35f5bd23c9f7af80271da1d75e362d4cc5c077"}],"releasenotes/notes/bp-policy-in-code-722372a27291b9cd.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4c8b3d3861413dc618e216fbab1e24f21195c025","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    Default policy is now being implemented in code. You may overwrite these"},{"line_number":5,"context_line":"    values using the policy.json file. If you currently make modifications to"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"dfeb2761_841308b9","line":2,"updated":"2017-03-30 17:49:44.000000000","message":"This could be highlighted in the features section, too.","commit_id":"6b1e1e4ed962272579c569c6570d2c1fd5132db4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4c8b3d3861413dc618e216fbab1e24f21195c025","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    Default policy is now being implemented in code. You may overwrite these"},{"line_number":5,"context_line":"    values using the policy.json file. If you currently make modifications to"},{"line_number":6,"context_line":"    the default policy file, you will have to continue maintaining those"},{"line_number":7,"context_line":"    changes. If you modify a subset or none of the policy entries, you can"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"dfeb2761_a4728c10","line":4,"updated":"2017-03-30 17:49:44.000000000","message":"nit: following the convention:\n\n  `[`blueprint policy-in-code \u003chttps://blueprints.launchpad.net/keystone/+spec/policy-in-code\u003e`_]\n  Keystone now supports the ability to register default policies in code.\n  This makes policy file maintenance easier by allowing duplicated default\n  policies to be removed from the policy file. The only policies that should\n  exist within a deployments policy file after Pike should be policy\n  overrides. To generate sample policy files from default values, prune\n  default policies from existing policy files, or familiarize yourself with\n  general policy usage, please see the `usage documentation\n  \u003chttps://docs.openstack.org/developer/oslo.policy/usage.html\u003e`_ \n  provided in oslo.policy.\n\nYou don\u0027t have to follow this directly, but this is just an example of how I try to write release notes from the perspective of the operator that has to read them. The other big thing I try to include right away is a link to the blueprint, which contains a link to the spec as well as all the patches in the implementation (which are helpful for the operators who are curious enough to see exactly how we did it).","commit_id":"6b1e1e4ed962272579c569c6570d2c1fd5132db4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4c8b3d3861413dc618e216fbab1e24f21195c025","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    changes. If you modify a subset or none of the policy entries, you can"},{"line_number":8,"context_line":"    essentially remove the policies that are default or the policy file."},{"line_number":9,"context_line":"    For information on oslo policy usage, please see:"},{"line_number":10,"context_line":"    https://docs.openstack.org/developer/oslo.policy/usage.html#list-of-redundant-configuration"},{"line_number":11,"context_line":"    For more information on the change, please refer to the spec:"},{"line_number":12,"context_line":"    https://docs.openstack.org/developer/keystone/devref/development_best_practices.html#release-notes"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"dfeb2761_24043c7b","line":10,"updated":"2017-03-30 17:49:44.000000000","message":"This can be a link in rst:\n\n  For more information on policy usage, see the oslo.policy\n  `usage documentation \u003chttps://docs.openstack.org/developer/oslo.policy/usage.html\u003e`_.","commit_id":"6b1e1e4ed962272579c569c6570d2c1fd5132db4"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"4c8b3d3861413dc618e216fbab1e24f21195c025","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    For information on oslo policy usage, please see:"},{"line_number":10,"context_line":"    https://docs.openstack.org/developer/oslo.policy/usage.html#list-of-redundant-configuration"},{"line_number":11,"context_line":"    For more information on the change, please refer to the spec:"},{"line_number":12,"context_line":"    https://docs.openstack.org/developer/keystone/devref/development_best_practices.html#release-notes"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"dfeb2761_a4ef2caf","line":12,"updated":"2017-03-30 17:49:44.000000000","message":"This is pointing to keystone release note documentation :)","commit_id":"6b1e1e4ed962272579c569c6570d2c1fd5132db4"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"dd3a90b726e0b893af74ed37bb0506e28b92db8f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \u003chttps://docs.openstack.org/developer/oslo.policy/usage.html\u003e`_"},{"line_number":13,"context_line":"    provided in oslo.policy."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"upgrade:"},{"line_number":16,"context_line":"  - \u003e"},{"line_number":17,"context_line":"    `[`blueprint policy-in-code \u003chttps://blueprints.launchpad.net/keystone/+spec/policy-in-code\u003e`_]"},{"line_number":18,"context_line":"    Keystone now supports the ability to register default policies in code."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"bff0334d_80c23258","line":15,"updated":"2017-04-10 18:23:31.000000000","message":"Why should we duplicate the same thing in features and upgrade ? Does the feature description describes the upgrade impact ? We could possibly split the feature description from the upgrade actions between there topics.","commit_id":"08feb508a8cb5c8ddcaaf6708f525c962592cde4"}],"releasenotes/notes/policy-in-code-4af1507df6dd1016.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5b14835ac777661e2b9cb58d5c284c87335f2ae3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    Default policy is now being implemented in code. You may overwrite these"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ffe62b97_d02f7ea5","line":1,"updated":"2017-03-30 14:27:03.000000000","message":"According to convention, we use `bp` in the note name:\n\nhttps://docs.openstack.org/developer/keystone/devref/development_best_practices.html#release-notes","commit_id":"4617ef66b22d7ca97120257a59a100f5b7fcf551"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5b14835ac777661e2b9cb58d5c284c87335f2ae3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - \u003e"},{"line_number":4,"context_line":"    Default policy is now being implemented in code. You may overwrite these"},{"line_number":5,"context_line":"    values using the policy.json file. If you currently make modifications to"},{"line_number":6,"context_line":"    the default policy file, you will have to continue maintaining those"},{"line_number":7,"context_line":"    changes. If you modify a subset or non of the policy entries, you can"},{"line_number":8,"context_line":"    essentially remove the policies that are default or the policy file."},{"line_number":9,"context_line":"    For more information, please refer to the spec:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ffe62b97_b39e44b6","line":6,"updated":"2017-03-30 14:27:03.000000000","message":"We also need to link to some documentation. Right now deployers more than likely have a policy file. It can be filled with defaults, contain overrides, or a mix of the two. We should point them to some usage documentation that allows them to prune default policies from their policy files so they don\u0027t have to maintain them anymore.","commit_id":"4617ef66b22d7ca97120257a59a100f5b7fcf551"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5b14835ac777661e2b9cb58d5c284c87335f2ae3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Default policy is now being implemented in code. You may overwrite these"},{"line_number":5,"context_line":"    values using the policy.json file. If you currently make modifications to"},{"line_number":6,"context_line":"    the default policy file, you will have to continue maintaining those"},{"line_number":7,"context_line":"    changes. If you modify a subset or non of the policy entries, you can"},{"line_number":8,"context_line":"    essentially remove the policies that are default or the policy file."},{"line_number":9,"context_line":"    For more information, please refer to the spec:"},{"line_number":10,"context_line":"    https://specs.openstack.org/openstack/keystone-specs/specs/keystone/pike/policy-in-code.html"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ffe62b97_13e5f038","line":7,"updated":"2017-03-30 14:27:03.000000000","message":"none*","commit_id":"4617ef66b22d7ca97120257a59a100f5b7fcf551"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5b14835ac777661e2b9cb58d5c284c87335f2ae3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    changes. If you modify a subset or non of the policy entries, you can"},{"line_number":8,"context_line":"    essentially remove the policies that are default or the policy file."},{"line_number":9,"context_line":"    For more information, please refer to the spec:"},{"line_number":10,"context_line":"    https://specs.openstack.org/openstack/keystone-specs/specs/keystone/pike/policy-in-code.html"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ffe62b97_b01d1a75","line":10,"updated":"2017-03-30 14:27:03.000000000","message":"We should make this a link like how we do in the example: \n\nhttps://docs.openstack.org/developer/keystone/devref/development_best_practices.html#release-notes","commit_id":"4617ef66b22d7ca97120257a59a100f5b7fcf551"}]}