)]}'
{"keystone/common/policies/domain_config.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9fd89a87bb24e8d5e9de7f1da0f22ec2831fcef7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":26,"context_line":"        name\u003dbase.IDENTITY % \u0027get_domain_config\u0027,"},{"line_number":27,"context_line":"        check_str\u003dbase.RULE_ADMIN_REQUIRED,"},{"line_number":28,"context_line":"        description\u003d\u0027Get domain configuration\u0027,"},{"line_number":29,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v3/domains/{domain_id}/config\u0027,"},{"line_number":30,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"},{"line_number":31,"context_line":"                    {\u0027path\u0027: \u0027/v3/domains/{domain_id}/config/{group}\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_c6f68090","line":28,"updated":"2017-03-25 01:15:55.000000000","message":"I think that maybe this needs to go into a little more detail about each type of path that\u0027s possible here. For example, it\u0027s possible to get a domain config for an entire domain, a specific group, or a specific option in the group. That level of detail might help operators understand why there are three different paths that allow getting a domain configuration.\n\nThis would apply to the rest of the changes in this module, too.","commit_id":"6b2063eb26039b0b93036a7dd3e9e8f4f69bce59"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"9fd89a87bb24e8d5e9de7f1da0f22ec2831fcef7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        check_str\u003dbase.RULE_ADMIN_REQUIRED,"},{"line_number":28,"context_line":"        description\u003d\u0027Get domain configuration\u0027,"},{"line_number":29,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v3/domains/{domain_id}/config\u0027,"},{"line_number":30,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"},{"line_number":31,"context_line":"                    {\u0027path\u0027: \u0027/v3/domains/{domain_id}/config/{group}\u0027,"},{"line_number":32,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"},{"line_number":33,"context_line":"                    {\u0027path\u0027: \u0027/v3/domains/{domain_id}/config/{group}/{option}\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_c63b2036","line":30,"updated":"2017-03-25 01:15:55.000000000","message":"Can\u0027t this also be done with HEAD, too? For reference I\u0027m comparing this to https://github.com/openstack/keystone/blob/62a0d2f295793928527530ae6540fe7e210dcd43/keystone/resource/routers.py#L51","commit_id":"6b2063eb26039b0b93036a7dd3e9e8f4f69bce59"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"12b2b88f8729d870ed12aae2481c846f807b349d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"},{"line_number":32,"context_line":"                    {\u0027path\u0027: \u0027/v3/domains/{domain_id}/config\u0027,"},{"line_number":33,"context_line":"                     \u0027method\u0027: \u0027HEAD\u0027},"},{"line_number":34,"context_line":"                    {\u0027path\u0027: \u0027/v3/domains/{domain_id}/config/{group}\u0027,"},{"line_number":35,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"},{"line_number":36,"context_line":"                    {\u0027path\u0027: \u0027/v3/domains/{domain_id}/config/{group}/{option}\u0027,"},{"line_number":37,"context_line":"                     \u0027method\u0027: \u0027GET\u0027}]),"},{"line_number":38,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":39,"context_line":"        name\u003dbase.IDENTITY % \u0027get_security_compliance_domain_config\u0027,"},{"line_number":40,"context_line":"        check_str\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfeb2761_849428ea","line":37,"range":{"start_line":34,"start_character":0,"end_line":37,"end_character":40},"updated":"2017-03-30 17:46:44.000000000","message":"isn\u0027t there a HEAD for these too ? IIRC we have HEAD for every GET request available","commit_id":"0f3c4c4dd3e7d26d5dfea11c7f742452ee3c17d7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"daab8724bddf0761aaf38c902e6deffa0ffc5beb","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                     \u0027group or a specific option in a group.\u0027),"},{"line_number":30,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v3/domains/{domain_id}/config\u0027,"},{"line_number":31,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"},{"line_number":32,"context_line":"                    {\u0027path\u0027: \u0027/v3/domains/{domain_id}/config\u0027,"},{"line_number":33,"context_line":"                     \u0027method\u0027: \u0027HEAD\u0027},"},{"line_number":34,"context_line":"                    {\u0027path\u0027: \u0027/v3/domains/{domain_id}/config/{group}\u0027,"},{"line_number":35,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_a490df4f","line":32,"updated":"2017-04-18 22:42:26.000000000","message":"I wouldn\u0027t be opposed to breaking this block into three separate sections. The first would document the ability to return the entire configuration for a specific domain. The second would document the ability to return a specific configuration group for a domain. The third would document the ability to return a specific option within a group for a given domain. I think that will help show the relationship between each variation, while clearly documenting each.","commit_id":"bd6cd44dfaded1f89b394238ff14803274f04f94"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fbe51a979c58d6b7e9c616db2202e3066036ee31","unresolved":false,"context_lines":[{"line_number":29,"context_line":"                     \u0027group or a specific option in a group.\u0027),"},{"line_number":30,"context_line":"        operations\u003d[{\u0027path\u0027: \u0027/v3/domains/{domain_id}/config\u0027,"},{"line_number":31,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"},{"line_number":32,"context_line":"                    {\u0027path\u0027: \u0027/v3/domains/{domain_id}/config\u0027,"},{"line_number":33,"context_line":"                     \u0027method\u0027: \u0027HEAD\u0027},"},{"line_number":34,"context_line":"                    {\u0027path\u0027: \u0027/v3/domains/{domain_id}/config/{group}\u0027,"},{"line_number":35,"context_line":"                     \u0027method\u0027: \u0027GET\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"df140735_a85ee30f","line":32,"in_reply_to":"7ffa3b31_a490df4f","updated":"2017-06-06 19:18:30.000000000","message":"Done","commit_id":"bd6cd44dfaded1f89b394238ff14803274f04f94"}]}