)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"change_message_id":"c76fc27adcc4eace3dc9c8081ea08019484c1645","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2017-03-26 23:49:06 +0530"},{"line_number":4,"context_line":"Commit:     SamriddhiJain \u003cj.samriddhi13@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-26 23:49:06 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixed bug Bug #1637682"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I10d38e4cc59934c421443322b14f4f971acf3a29"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_595c6e7d","line":6,"updated":"2017-03-27 13:22:30.000000000","message":"Please include a brief description of what the problem scenario is, along with the intent/result of the fix. Please read the Git commit message structure[1] to get a clear idea, it will help you in all your future contributions. \n\n[1] https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"75948664b4412394d4bb0cca667ed93f55e7dc21"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"a85a0a6e3be0cfcf38c5128082b314969de4b1ce","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2017-03-26 23:49:06 +0530"},{"line_number":4,"context_line":"Commit:     SamriddhiJain \u003cj.samriddhi13@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-26 23:49:06 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixed bug Bug #1637682"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I10d38e4cc59934c421443322b14f4f971acf3a29"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_ca03e972","line":6,"in_reply_to":"ffe62b97_595c6e7d","updated":"2017-03-27 15:30:57.000000000","message":"++","commit_id":"75948664b4412394d4bb0cca667ed93f55e7dc21"},{"author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"change_message_id":"c76fc27adcc4eace3dc9c8081ea08019484c1645","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     SamriddhiJain \u003cj.samriddhi13@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-26 23:49:06 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixed bug Bug #1637682"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I10d38e4cc59934c421443322b14f4f971acf3a29"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_79797291","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":13},"updated":"2017-03-27 13:22:30.000000000","message":"A good practice is to use the Closes-Bug notation instead. Please replace it by, Closes-bug:","commit_id":"75948664b4412394d4bb0cca667ed93f55e7dc21"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"a85a0a6e3be0cfcf38c5128082b314969de4b1ce","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     SamriddhiJain \u003cj.samriddhi13@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-26 23:49:06 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fixed bug Bug #1637682"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I10d38e4cc59934c421443322b14f4f971acf3a29"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ffe62b97_6af4dd86","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":13},"in_reply_to":"ffe62b97_79797291","updated":"2017-03-27 15:30:57.000000000","message":"++","commit_id":"75948664b4412394d4bb0cca667ed93f55e7dc21"},{"author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"change_message_id":"190e282ef2584b26b2e50f0853f71ae875b3f7b6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     SamriddhiJain \u003cj.samriddhi13@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-30 03:24:43 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated description of scope parameter."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The description of scope parameter in the apidocs was inconsistent for"},{"line_number":10,"context_line":"scoped and explicit unscoped authorization. It didn\u0027t explain clearly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffe62b97_82fd3a0a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":39},"updated":"2017-03-30 08:49:55.000000000","message":"Update scope parameter\u0027s description in v3 API-ref\n\nPlease see the link mentioned in the 1st patch set, it says \u0027The first line should not end with a period\u0027.","commit_id":"afd42f801b7669e4305d471b33b82548b6be25ee"},{"author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"change_message_id":"190e282ef2584b26b2e50f0853f71ae875b3f7b6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Updated description of scope parameter."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The description of scope parameter in the apidocs was inconsistent for"},{"line_number":10,"context_line":"scoped and explicit unscoped authorization. It didn\u0027t explain clearly"},{"line_number":11,"context_line":"when the parameter should be set to keyword \u0027unscoped\u0027 (explicit"},{"line_number":12,"context_line":"unscoped authorization) and when to include id/name of the project/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffe62b97_62ec7629","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":53},"updated":"2017-03-30 08:49:55.000000000","message":"the scope parameter in API docs is","commit_id":"afd42f801b7669e4305d471b33b82548b6be25ee"},{"author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"change_message_id":"190e282ef2584b26b2e50f0853f71ae875b3f7b6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Updated description of scope parameter."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The description of scope parameter in the apidocs was inconsistent for"},{"line_number":10,"context_line":"scoped and explicit unscoped authorization. It didn\u0027t explain clearly"},{"line_number":11,"context_line":"when the parameter should be set to keyword \u0027unscoped\u0027 (explicit"},{"line_number":12,"context_line":"unscoped authorization) and when to include id/name of the project/"},{"line_number":13,"context_line":"domain (scoped authorization). This patch covers the required update"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffe62b97_c2e4623f","line":10,"range":{"start_line":10,"start_character":47,"end_line":10,"end_character":53},"updated":"2017-03-30 08:49:55.000000000","message":"doesn\u0027t","commit_id":"afd42f801b7669e4305d471b33b82548b6be25ee"},{"author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"change_message_id":"190e282ef2584b26b2e50f0853f71ae875b3f7b6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The description of scope parameter in the apidocs was inconsistent for"},{"line_number":10,"context_line":"scoped and explicit unscoped authorization. It didn\u0027t explain clearly"},{"line_number":11,"context_line":"when the parameter should be set to keyword \u0027unscoped\u0027 (explicit"},{"line_number":12,"context_line":"unscoped authorization) and when to include id/name of the project/"},{"line_number":13,"context_line":"domain (scoped authorization). This patch covers the required update"},{"line_number":14,"context_line":"for the scope parameter by introducing separate descriptions for the"},{"line_number":15,"context_line":"above mentioned cases."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffe62b97_82d09a55","line":12,"range":{"start_line":12,"start_character":44,"end_line":12,"end_character":46},"updated":"2017-03-30 08:49:55.000000000","message":"ID","commit_id":"afd42f801b7669e4305d471b33b82548b6be25ee"}],"api-ref/source/v3/authenticate-v3.inc":[{"author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"change_message_id":"c76fc27adcc4eace3dc9c8081ea08019484c1645","unresolved":false,"context_lines":[{"line_number":320,"context_line":"   - X-Auth-Token: X-Auth-Token"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"Token authentication with scoped authorization"},{"line_number":324,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":".. rest_method::  POST /v3/auth/tokens"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"ffe62b97_7dfef437","line":323,"range":{"start_line":323,"start_character":26,"end_line":323,"end_character":46},"updated":"2017-03-27 13:22:30.000000000","message":"I guess there should be another case after this one, namely, Token authentication with explicit unscoped authorization just like we had 3 cases for Password Authentication. Please see this link [1], it talks about the 3 cases for Token Authentication.\n\n[1] https://github.com/openstack/keystone-specs/blob/master/attic/v3/identity-api-v3.rst#unscoped","commit_id":"75948664b4412394d4bb0cca667ed93f55e7dc21"},{"author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"change_message_id":"0053125afe7fb6176c5b81d3c7b7f99c955f0a6a","unresolved":false,"context_lines":[{"line_number":320,"context_line":"   - X-Auth-Token: X-Auth-Token"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"Token authentication with scoped authorization"},{"line_number":324,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":".. rest_method::  POST /v3/auth/tokens"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"ffe62b97_a5f84849","line":323,"in_reply_to":"ffe62b97_6206dd22","updated":"2017-03-30 09:03:06.000000000","message":"Yeah, that would work. But seeing the comments on the bug[1] and requirement of a separate case as mentioned above, I am wondering if we should use the tag \u0027Partial-Bug\u0027 instead of \u0027Closes-bug\u0027, as more work is required to completely fix the issue. What do you think?\n\n[1] https://bugs.launchpad.net/keystone/+bug/1637682\nPartial-Bug","commit_id":"75948664b4412394d4bb0cca667ed93f55e7dc21"},{"author":{"_account_id":25559,"name":"Samriddhi","email":"j.samriddhi13@gmail.com","username":"sjain"},"change_message_id":"4bf229848068177f889e794e358007dd72a934c6","unresolved":false,"context_lines":[{"line_number":320,"context_line":"   - X-Auth-Token: X-Auth-Token"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"Token authentication with scoped authorization"},{"line_number":324,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":".. rest_method::  POST /v3/auth/tokens"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"ffe62b97_f9ef981b","line":323,"range":{"start_line":323,"start_character":26,"end_line":323,"end_character":46},"in_reply_to":"ffe62b97_7dfef437","updated":"2017-03-28 18:24:05.000000000","message":"I agree with you, there needs to be a new case added \"Token authentication with explicit unscoped authorization\", but I\u0027m not sure whether it should be part of this PR. It will require creating new example and adding specific parameters, so I can send a separate review for that which is not directly related to this bug. Whats say?","commit_id":"75948664b4412394d4bb0cca667ed93f55e7dc21"},{"author":{"_account_id":7725,"name":"David Stanek","email":"dstanek@dstanek.com","username":"dstanek"},"change_message_id":"06610bfa7ded29827380d7b0d4c0c80a4177d542","unresolved":false,"context_lines":[{"line_number":320,"context_line":"   - X-Auth-Token: X-Auth-Token"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"Token authentication with scoped authorization"},{"line_number":324,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":".. rest_method::  POST /v3/auth/tokens"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"ffe62b97_6206dd22","line":323,"in_reply_to":"ffe62b97_f9ef981b","updated":"2017-03-29 13:15:11.000000000","message":"Separate review would be fine with me.","commit_id":"75948664b4412394d4bb0cca667ed93f55e7dc21"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"0e079aa44b5d6e04af3c3ea937ea3367f5dfeef6","unresolved":false,"context_lines":[{"line_number":366,"context_line":""},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"Token authentication with explicit unscoped authorization"},{"line_number":369,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":".. rest_method::  POST /v3/auth/tokens"},{"line_number":372,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"dfeb2761_2b8da5d2","line":369,"range":{"start_line":369,"start_character":57,"end_line":369,"end_character":60},"updated":"2017-04-04 14:33:32.000000000","message":"can trim these extra header indicators off","commit_id":"2ea5083c07b49ac73dcafd45c19b50688dd63087"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"0e079aa44b5d6e04af3c3ea937ea3367f5dfeef6","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"Relationship: ``https://docs.openstack.org/api/openstack-identity/3/rel/auth_tokens``"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"Authenticates an identity and generates a token. Uses the token authentication method with explicit unscoped authorization."},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"In the request body, provide the token ID and the"},{"line_number":378,"context_line":"``unscoped`` authorization scope."}],"source_content_type":"text/x-c++src","patch_set":6,"id":"dfeb2761_4ba90922","line":375,"range":{"start_line":375,"start_character":99,"end_line":375,"end_character":123},"updated":"2017-04-04 14:33:32.000000000","message":"Over 80 chars here, this will likely fail pep8 (or sphinx for api-ref)","commit_id":"2ea5083c07b49ac73dcafd45c19b50688dd63087"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1ecc06600b88a799e0e5aae44d4044573d4c0469","unresolved":false,"context_lines":[{"line_number":408,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"   - X-Subject-Token: X-Subject-Token"},{"line_number":411,"context_line":"   - X-Auth-Token: X-Auth-Token"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"Validate and show information for token"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bff0334d_5947121f","line":411,"updated":"2017-04-05 22:11:16.000000000","message":"X-Auth-Token shouldn\u0027t come back here.","commit_id":"2ea5083c07b49ac73dcafd45c19b50688dd63087"},{"author":{"_account_id":25559,"name":"Samriddhi","email":"j.samriddhi13@gmail.com","username":"sjain"},"change_message_id":"d5fa470e52e57c37a6a0d9d0f5b3375ca12dde96","unresolved":false,"context_lines":[{"line_number":408,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"   - X-Subject-Token: X-Subject-Token"},{"line_number":411,"context_line":"   - X-Auth-Token: X-Auth-Token"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"Validate and show information for token"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bff0334d_05b9c978","line":411,"in_reply_to":"bff0334d_5947121f","updated":"2017-04-07 17:12:32.000000000","message":"okay, in which other cases this token comes in parameter, as the other 5 cases mention this parameter in Response.","commit_id":"2ea5083c07b49ac73dcafd45c19b50688dd63087"}],"api-ref/source/v3/parameters.yaml":[{"author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"change_message_id":"c76fc27adcc4eace3dc9c8081ea08019484c1645","unresolved":false,"context_lines":[{"line_number":824,"context_line":"  in: body"},{"line_number":825,"context_line":"  required: true"},{"line_number":826,"context_line":"  type: string"},{"line_number":827,"context_line":"explicit_unscoped_string:"},{"line_number":828,"context_line":"  description: |"},{"line_number":829,"context_line":"    The authorization scope.  (Since v3.4) Specify"},{"line_number":830,"context_line":"    ``unscoped`` to make an explicit unscoped token request, which"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffe62b97_36bf6962","line":827,"range":{"start_line":827,"start_character":0,"end_line":827,"end_character":25},"updated":"2017-03-27 13:22:30.000000000","message":"Is there any reason for which you preferred describing the explicit_unscoped_string here? I think it would be better to include it immediately after the scope_string, just to keep the two together. \n\nLet\u0027s see what others think on this one, I don\u0027t know if it really matters.","commit_id":"75948664b4412394d4bb0cca667ed93f55e7dc21"},{"author":{"_account_id":25559,"name":"Samriddhi","email":"j.samriddhi13@gmail.com","username":"sjain"},"change_message_id":"4bf229848068177f889e794e358007dd72a934c6","unresolved":false,"context_lines":[{"line_number":824,"context_line":"  in: body"},{"line_number":825,"context_line":"  required: true"},{"line_number":826,"context_line":"  type: string"},{"line_number":827,"context_line":"explicit_unscoped_string:"},{"line_number":828,"context_line":"  description: |"},{"line_number":829,"context_line":"    The authorization scope.  (Since v3.4) Specify"},{"line_number":830,"context_line":"    ``unscoped`` to make an explicit unscoped token request, which"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffe62b97_645ad44f","line":827,"range":{"start_line":827,"start_character":0,"end_line":827,"end_character":25},"in_reply_to":"ffe62b97_36bf6962","updated":"2017-03-28 18:24:05.000000000","message":"I initially did the same, but then tox -e api-ref gave an error, I guess these parameters need to be defined in an alphabetic order (which I tried and eventually that succeeded)","commit_id":"75948664b4412394d4bb0cca667ed93f55e7dc21"},{"author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"change_message_id":"c76fc27adcc4eace3dc9c8081ea08019484c1645","unresolved":false,"context_lines":[{"line_number":830,"context_line":"    ``unscoped`` to make an explicit unscoped token request, which"},{"line_number":831,"context_line":"    returns an unscoped response without any authorization. This"},{"line_number":832,"context_line":"    request behaves the same as a token request with no scope where"},{"line_number":833,"context_line":"    the user has no default project defined.  If you do not make an"},{"line_number":834,"context_line":"    explicit ``unscoped`` token request and your role has a default"},{"line_number":835,"context_line":"    project, the response might return a project- scoped token. If a"},{"line_number":836,"context_line":"    default project is not defined, a token is issued without an"},{"line_number":837,"context_line":"    explicit scope of authorization, which is the same as asking for"},{"line_number":838,"context_line":"    an explicit unscoped token."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffe62b97_36d3e962","line":835,"range":{"start_line":833,"start_character":46,"end_line":835,"end_character":63},"updated":"2017-03-27 13:22:30.000000000","message":"Maybe replace with \"If an explicit, ``unscoped`` token request is not made and the role has a default project, then the response might return a project-scoped token\"","commit_id":"75948664b4412394d4bb0cca667ed93f55e7dc21"},{"author":{"_account_id":18176,"name":"Nisha Yadav","email":"ynisha11@gmail.com","username":"ynisha11"},"change_message_id":"c76fc27adcc4eace3dc9c8081ea08019484c1645","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"  type: array"},{"line_number":1342,"context_line":"scope_string:"},{"line_number":1343,"context_line":"  description: |"},{"line_number":1344,"context_line":"    The authorization scope. Specify the id or "},{"line_number":1345,"context_line":"    the name of project/domain."},{"line_number":1346,"context_line":"  in: body"},{"line_number":1347,"context_line":"  required: false"},{"line_number":1348,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ffe62b97_93e2c700","line":1345,"range":{"start_line":1344,"start_character":4,"end_line":1345,"end_character":31},"updated":"2017-03-27 13:22:30.000000000","message":"Maybe the following would be a better, more complete description.\n\nThe authorization scope, including either a project or a domain (Since v3.4). If both a domain and a project are specified, an HTTP 400 Bad Request will be returned, as a token cannot be simultaneously scoped to both a project and a domain. An id is sufficient to uniquely identify a project but if a project is specified by name, then the domain of the project must also be specified in order to uniquely identify the project. A domain scope may be specified by either the domain\u0027s id or name with equivalent results.","commit_id":"75948664b4412394d4bb0cca667ed93f55e7dc21"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"12e1480d8d4f25e3c5d9a8f76725e25193eabc6d","unresolved":false,"context_lines":[{"line_number":1345,"context_line":"    a domain (Since v3.4). If both a domain and a project are"},{"line_number":1346,"context_line":"    specified, an HTTP 400 Bad Request will be returned, as a"},{"line_number":1347,"context_line":"    token cannot be simultaneously scoped to both a project"},{"line_number":1348,"context_line":"    and a domain. An id is sufficient to uniquely identify"},{"line_number":1349,"context_line":"    a project but if a project is specified by name, then"},{"line_number":1350,"context_line":"    the domain of the project must also be specified in order"},{"line_number":1351,"context_line":"    to uniquely identify the project. A domain scope may be"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ffe62b97_7aee6f22","line":1348,"range":{"start_line":1348,"start_character":21,"end_line":1348,"end_character":23},"updated":"2017-03-29 22:26:00.000000000","message":"ID","commit_id":"afd42f801b7669e4305d471b33b82548b6be25ee"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"12e1480d8d4f25e3c5d9a8f76725e25193eabc6d","unresolved":false,"context_lines":[{"line_number":1349,"context_line":"    a project but if a project is specified by name, then"},{"line_number":1350,"context_line":"    the domain of the project must also be specified in order"},{"line_number":1351,"context_line":"    to uniquely identify the project. A domain scope may be"},{"line_number":1352,"context_line":"    specified by either the domain\u0027s id or name with"},{"line_number":1353,"context_line":"    equivalent results."},{"line_number":1354,"context_line":"  in: body"},{"line_number":1355,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ffe62b97_9aeb7311","line":1352,"range":{"start_line":1352,"start_character":24,"end_line":1352,"end_character":39},"updated":"2017-03-29 22:26:00.000000000","message":"I\u0027d replace this by just \"ID\"","commit_id":"afd42f801b7669e4305d471b33b82548b6be25ee"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"0e079aa44b5d6e04af3c3ea937ea3367f5dfeef6","unresolved":false,"context_lines":[{"line_number":826,"context_line":"  type: string"},{"line_number":827,"context_line":"explicit_unscoped_string:"},{"line_number":828,"context_line":"  description: |"},{"line_number":829,"context_line":"    The authorization scope.  (Since v3.4) Specify"},{"line_number":830,"context_line":"    ``unscoped`` to make an explicit unscoped token request, which"},{"line_number":831,"context_line":"    returns an unscoped response without any authorization. This"},{"line_number":832,"context_line":"    request behaves the same as a token request with no scope where"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dfeb2761_ab165554","line":829,"range":{"start_line":829,"start_character":27,"end_line":829,"end_character":28},"updated":"2017-04-04 14:33:32.000000000","message":"I would say move the period to the end of \"(Since v3.4)\" to match below.","commit_id":"2ea5083c07b49ac73dcafd45c19b50688dd63087"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"0e079aa44b5d6e04af3c3ea937ea3367f5dfeef6","unresolved":false,"context_lines":[{"line_number":826,"context_line":"  type: string"},{"line_number":827,"context_line":"explicit_unscoped_string:"},{"line_number":828,"context_line":"  description: |"},{"line_number":829,"context_line":"    The authorization scope.  (Since v3.4) Specify"},{"line_number":830,"context_line":"    ``unscoped`` to make an explicit unscoped token request, which"},{"line_number":831,"context_line":"    returns an unscoped response without any authorization. This"},{"line_number":832,"context_line":"    request behaves the same as a token request with no scope where"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dfeb2761_4b7ea9af","line":829,"range":{"start_line":829,"start_character":29,"end_line":829,"end_character":30},"updated":"2017-04-04 14:33:32.000000000","message":"nit: extra whitespace here","commit_id":"2ea5083c07b49ac73dcafd45c19b50688dd63087"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"0e079aa44b5d6e04af3c3ea937ea3367f5dfeef6","unresolved":false,"context_lines":[{"line_number":832,"context_line":"    request behaves the same as a token request with no scope where"},{"line_number":833,"context_line":"    the user has no default project defined. If an explicit,"},{"line_number":834,"context_line":"    ``unscoped`` token request is not made and the role has a default"},{"line_number":835,"context_line":"    project, then the response might return a project-scoped token."},{"line_number":836,"context_line":"    If a default project is not defined, a token is issued without an"},{"line_number":837,"context_line":"    explicit scope of authorization, which is the same as asking for"},{"line_number":838,"context_line":"    an explicit unscoped token."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"dfeb2761_cb3879ef","line":835,"range":{"start_line":835,"start_character":31,"end_line":835,"end_character":36},"updated":"2017-04-04 14:33:32.000000000","message":"Not sure if \"might\" is appropriate here, it should either return a project-scoped token or not (unless we truly do not know for sure)","commit_id":"2ea5083c07b49ac73dcafd45c19b50688dd63087"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1ecc06600b88a799e0e5aae44d4044573d4c0469","unresolved":false,"context_lines":[{"line_number":832,"context_line":"    request behaves the same as a token request with no scope where"},{"line_number":833,"context_line":"    the user has no default project defined. If an explicit,"},{"line_number":834,"context_line":"    ``unscoped`` token request is not made and the role has a default"},{"line_number":835,"context_line":"    project, then the response might return a project-scoped token."},{"line_number":836,"context_line":"    If a default project is not defined, a token is issued without an"},{"line_number":837,"context_line":"    explicit scope of authorization, which is the same as asking for"},{"line_number":838,"context_line":"    an explicit unscoped token."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bff0334d_99afda93","line":835,"in_reply_to":"dfeb2761_cb3879ef","updated":"2017-04-05 22:11:16.000000000","message":"I agree. If the user has a default project and a role assignment on that project they will get a project-scoped token even if they authenticate without scope in the request. If that is the case, they must provide a \"unscoped\" in the scope request in order to get an unscoped token.\n\nWe need to omit the ambiguity in this statement. Doing so will be helpful since this behavior has caused confusion before.","commit_id":"2ea5083c07b49ac73dcafd45c19b50688dd63087"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1ecc06600b88a799e0e5aae44d4044573d4c0469","unresolved":false,"context_lines":[{"line_number":1348,"context_line":"    and a domain. An ID is sufficient to uniquely identify"},{"line_number":1349,"context_line":"    a project but if a project is specified by name, then"},{"line_number":1350,"context_line":"    the domain of the project must also be specified in order"},{"line_number":1351,"context_line":"    to uniquely identify the project. A domain scope may be"},{"line_number":1352,"context_line":"    specified by either the domain\u0027s ID or name with"},{"line_number":1353,"context_line":"    equivalent results."},{"line_number":1354,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bff0334d_999d9a5b","line":1351,"updated":"2017-04-05 22:11:16.000000000","message":"nit: identify the project by name.","commit_id":"2ea5083c07b49ac73dcafd45c19b50688dd63087"}],"keystone/auth/schema.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"1ecc06600b88a799e0e5aae44d4044573d4c0469","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            # For explicit unscoped authentication the type should not be"},{"line_number":57,"context_line":"            # strictly string. Although keystone server specifies the value"},{"line_number":58,"context_line":"            # to be \u0027unscoped\u0027, old versions of keystoneauth might still be"},{"line_number":59,"context_line":"            # using \"scope\": {\u0027unscoped\u0027: {}}"},{"line_number":60,"context_line":"            # https://bugs.launchpad.net/keystoneauth/+bug/1637682/"},{"line_number":61,"context_line":"            \u0027type\u0027: [\u0027object\u0027, \u0027string\u0027],"},{"line_number":62,"context_line":"            \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_39c56e3d","line":59,"updated":"2017-04-05 22:11:16.000000000","message":"nit: \n\n  using `\"scope\": {\u0027unscoped\u0027: {}}` instead of `\"scope\": \"unscoped\"`","commit_id":"2ea5083c07b49ac73dcafd45c19b50688dd63087"}]}