)]}'
{"keystone/tests/unit/test_revoke.py":[{"author":{"_account_id":4,"name":"Dolph Mathews","email":"dolph.mathews@gmail.com","username":"dolph"},"change_message_id":"da4524dcf1bb6f0f0ce86e6941ee808571aa27ac","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def _assertTokenNotRevoked(self, token_data):"},{"line_number":94,"context_line":"        self.assertIsNone(self.revoke_api.check_token(token_data))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _assertRevocationEventLength(self, expected_length, token):"},{"line_number":97,"context_line":"        self.assertEqual(expected_length,"},{"line_number":98,"context_line":"                         len(self.revocation_backend.list_events(token\u003dtoken)))"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_87a4160a","line":96,"updated":"2017-04-05 21:27:21.000000000","message":"The way I understand this name, you\u0027re testing something about the length of a single event, and then passing in a length and a token. Based on the name alone, I have no idea what you\u0027re testing until I read the implementation. So, I\u0027d request a better name.\n\nDespite it\u0027s name, list_events is really returning the list of events that match a token, thus indicating that it\u0027s been revoked, right?\n\nSo, why not add another (perhaps required?) argument to _assertTokenRevoked so that you can call:\n\n  self._assertTokenRevoked(token, matching_events\u003d2)\n\nSimilarly, matching zero events is implied by _assertTokenNotRevoked()","commit_id":"9e95793f924a5bffa2f1c905e830dad974ed7810"},{"author":{"_account_id":18464,"name":"Richard Avelar","email":"csravelar@gmail.com","username":"razone"},"change_message_id":"b7f11c75f20ecbadfb291d969337af9532081f97","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    def _assertTokenNotRevoked(self, token_data):"},{"line_number":94,"context_line":"        self.assertIsNone(self.revoke_api.check_token(token_data))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _assertRevocationEventLength(self, expected_length, token):"},{"line_number":97,"context_line":"        self.assertEqual(expected_length,"},{"line_number":98,"context_line":"                         len(self.revocation_backend.list_events(token\u003dtoken)))"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_fd391541","line":96,"in_reply_to":"bff0334d_87a4160a","updated":"2017-04-06 13:50:14.000000000","message":"I like your thinking, Done","commit_id":"9e95793f924a5bffa2f1c905e830dad974ed7810"}]}