)]}'
{"keystone/token/persistence/backends/sql.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f83bab555d184a844a7e520b6b5f8223d5251e6f","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                delete_query \u003d query.filter(TokenModel.expires \u003c\u003d"},{"line_number":286,"context_line":"                                            expiry_time)"},{"line_number":287,"context_line":"                row_count \u003d delete_query.delete(synchronize_session\u003dFalse)"},{"line_number":288,"context_line":"                session.commit()"},{"line_number":289,"context_line":"                total_removed +\u003d row_count"},{"line_number":290,"context_line":"                LOG.debug(\u0027Removed %d total expired tokens\u0027, total_removed)"},{"line_number":291,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_0d9fd95f","line":288,"updated":"2017-04-06 21:40:35.000000000","message":"Aha - so this step would have otherwise been done when `flush()` is called on line 292, right? Which commits all the changes at once, instead of truly doing it in batches.","commit_id":"d7b6af55d3810df1912c3545fdd40d0da4862445"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"326a5c6afeb31f5aaacfd10e15493ee706c4bcf1","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                delete_query \u003d query.filter(TokenModel.expires \u003c\u003d"},{"line_number":286,"context_line":"                                            expiry_time)"},{"line_number":287,"context_line":"                row_count \u003d delete_query.delete(synchronize_session\u003dFalse)"},{"line_number":288,"context_line":"                session.commit()"},{"line_number":289,"context_line":"                total_removed +\u003d row_count"},{"line_number":290,"context_line":"                LOG.debug(\u0027Removed %d total expired tokens\u0027, total_removed)"},{"line_number":291,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_3f7bf18c","line":288,"in_reply_to":"7ffa3b31_0865afb5","updated":"2017-04-17 12:55:16.000000000","message":"As per https://review.openstack.org/#/c/454894 this should contain:\n\n   if not session.autocommit:\n\nCorrect ?","commit_id":"d7b6af55d3810df1912c3545fdd40d0da4862445"},{"author":{"_account_id":15382,"name":"Peter Sabaini","email":"peter.sabaini@canonical.com","username":"peter-sabaini"},"change_message_id":"5917cbd5cd6ade57ac19261a3d9ee5bbf3a06b4f","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                delete_query \u003d query.filter(TokenModel.expires \u003c\u003d"},{"line_number":286,"context_line":"                                            expiry_time)"},{"line_number":287,"context_line":"                row_count \u003d delete_query.delete(synchronize_session\u003dFalse)"},{"line_number":288,"context_line":"                session.commit()"},{"line_number":289,"context_line":"                total_removed +\u003d row_count"},{"line_number":290,"context_line":"                LOG.debug(\u0027Removed %d total expired tokens\u0027, total_removed)"},{"line_number":291,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_0865afb5","line":288,"in_reply_to":"bff0334d_0d9fd95f","updated":"2017-04-15 20:17:16.000000000","message":"In this case yes as it\u0027s at the end of the job, although flush() doesn\u0027t necessarily imply a commit","commit_id":"d7b6af55d3810df1912c3545fdd40d0da4862445"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7e4f8d8b327d62a2b233e5493157177da9e6397f","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                delete_query \u003d query.filter(TokenModel.expires \u003c\u003d"},{"line_number":286,"context_line":"                                            expiry_time)"},{"line_number":287,"context_line":"                row_count \u003d delete_query.delete(synchronize_session\u003dFalse)"},{"line_number":288,"context_line":"                session.commit()"},{"line_number":289,"context_line":"                total_removed +\u003d row_count"},{"line_number":290,"context_line":"                LOG.debug(\u0027Removed %d total expired tokens\u0027, total_removed)"},{"line_number":291,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_09f65cfa","line":288,"in_reply_to":"bff0334d_0d9fd95f","updated":"2017-04-10 13:08:37.000000000","message":"maybe add a comment here, but lgtm","commit_id":"d7b6af55d3810df1912c3545fdd40d0da4862445"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"69683c388bfedccca9184ec9e94ac8339c4976e7","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                                            expiry_time)"},{"line_number":287,"context_line":"                row_count \u003d delete_query.delete(synchronize_session\u003dFalse)"},{"line_number":288,"context_line":"                if not session.autocommit:"},{"line_number":289,"context_line":"                    session.commit()"},{"line_number":290,"context_line":"                total_removed +\u003d row_count"},{"line_number":291,"context_line":"                LOG.debug(\u0027Removed %d total expired tokens\u0027, total_removed)"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_6b46387f","line":289,"updated":"2017-04-18 13:41:24.000000000","message":"A comment explaining this would be nice","commit_id":"2d5a65919082f88247cbbe8c1cbd3361aa08c568"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7fdd7930907eb6d19315c7ce48cec27c8522dffe","unresolved":false,"context_lines":[{"line_number":286,"context_line":"                                            expiry_time)"},{"line_number":287,"context_line":"                row_count \u003d delete_query.delete(synchronize_session\u003dFalse)"},{"line_number":288,"context_line":"                if not session.autocommit:"},{"line_number":289,"context_line":"                    session.commit()"},{"line_number":290,"context_line":"                total_removed +\u003d row_count"},{"line_number":291,"context_line":"                LOG.debug(\u0027Removed %d total expired tokens\u0027, total_removed)"},{"line_number":292,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_2edef33e","line":289,"in_reply_to":"7ffa3b31_6b46387f","updated":"2017-04-18 18:53:23.000000000","message":"++","commit_id":"2d5a65919082f88247cbbe8c1cbd3361aa08c568"}]}