)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6b81d39d56eca6ad4a5bb1eaedd06e6230ef4c75","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The [ldap] user_enabled_default option is StrOpt, that means"},{"line_number":10,"context_line":"CONF.ldap.user_enabled_default always returns string, oslo.config"},{"line_number":11,"context_line":"will ensure that. According to [1], there are 3 kinds of value:"},{"line_number":12,"context_line":"integer string, string \u0027True\u0027, string \u0027non-True\u0027. So we just test"},{"line_number":13,"context_line":"string in unit tests."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/openstack/keystone/blob/af4e98c770d771144463e6dd49cb4b559d48c403/keystone/identity/backends/ldap/core.py#L295-L311"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_047a3c87","line":12,"range":{"start_line":12,"start_character":38,"end_line":12,"end_character":48},"updated":"2017-05-03 09:03:08.000000000","message":"is there a reason to set this to \u0027non-True\u0027 as opposed to \u0027False\u0027. I would think the later is what a customer would set it to.","commit_id":"c12550e076bcbf6572f59e756c821180e4419fc5"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"ba211b9026bc6b452d6720d11510a3fc5507f69e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The [ldap] user_enabled_default option is StrOpt, that means"},{"line_number":10,"context_line":"CONF.ldap.user_enabled_default always returns string, oslo.config"},{"line_number":11,"context_line":"will ensure that. According to [1], there are 3 kinds of value:"},{"line_number":12,"context_line":"integer string, string \u0027True\u0027, string \u0027non-True\u0027. So we just test"},{"line_number":13,"context_line":"string in unit tests."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/openstack/keystone/blob/af4e98c770d771144463e6dd49cb4b559d48c403/keystone/identity/backends/ldap/core.py#L295-L311"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_c4e0d4fd","line":12,"range":{"start_line":12,"start_character":38,"end_line":12,"end_character":48},"in_reply_to":"5ff73747_047a3c87","updated":"2017-05-03 09:17:15.000000000","message":"yeah, customer can set with any string except \u0027True\u0027, \"False\u0027 can be used frequently. \n\nTo be clear:  string s s.lower()\u003d\u0027true\u0027 or any string b  b.lower()!\u003d\u0027true\u0027","commit_id":"c12550e076bcbf6572f59e756c821180e4419fc5"},{"author":{"_account_id":5707,"name":"Henry Nash","email":"henryn@linux.vnet.ibm.com","username":"henry-nash"},"change_message_id":"6b81d39d56eca6ad4a5bb1eaedd06e6230ef4c75","unresolved":false,"context_lines":[{"line_number":12,"context_line":"integer string, string \u0027True\u0027, string \u0027non-True\u0027. So we just test"},{"line_number":13,"context_line":"string in unit tests."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/openstack/keystone/blob/af4e98c770d771144463e6dd49cb4b559d48c403/keystone/identity/backends/ldap/core.py#L295-L311"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partial-Bug: #1686921"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_840e4c30","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":137},"updated":"2017-05-03 09:03:08.000000000","message":"I\u0027m not quite sure of the relevancy of this line....that section of code highlighted is only responsible for special handling of the final \u0027enabled\u0027 attribute, I think, as opposed to the processing of the \u0027user_enabled_default\u0027 attribute.","commit_id":"c12550e076bcbf6572f59e756c821180e4419fc5"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"ba211b9026bc6b452d6720d11510a3fc5507f69e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"integer string, string \u0027True\u0027, string \u0027non-True\u0027. So we just test"},{"line_number":13,"context_line":"string in unit tests."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] https://github.com/openstack/keystone/blob/af4e98c770d771144463e6dd49cb4b559d48c403/keystone/identity/backends/ldap/core.py#L295-L311"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partial-Bug: #1686921"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_84cc0c62","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":137},"in_reply_to":"5ff73747_840e4c30","updated":"2017-05-03 09:17:15.000000000","message":"We got value self.enabled_default in \nin https://github.com/openstack/keystone/blob/af4e98c770d771144463e6dd49cb4b559d48c403/keystone/identity/backends/ldap/core.py#L291\n\nthen to handle with the logic in above code section.  Maybe we can just remove the link.","commit_id":"c12550e076bcbf6572f59e756c821180e4419fc5"}],"keystone/tests/unit/test_backend_ldap.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7a30dd78372a9cfeaae56c79397a93fecfbdbf71","unresolved":false,"context_lines":[{"line_number":1168,"context_line":"    @mock.patch.object(common_ldap.BaseLdap, \u0027_ldap_get\u0027)"},{"line_number":1169,"context_line":"    def test_user_enabled_invert_no_enabled_value(self, mock_ldap_get):"},{"line_number":1170,"context_line":"        self.config_fixture.config(group\u003d\u0027ldap\u0027, user_enabled_invert\u003dTrue,"},{"line_number":1171,"context_line":"                                   user_enabled_default\u003dFalse)"},{"line_number":1172,"context_line":"        # Mock the search results to return an entry with"},{"line_number":1173,"context_line":"        # no enabled value."},{"line_number":1174,"context_line":"        mock_ldap_get.return_value \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_43ef11e9","side":"PARENT","line":1171,"updated":"2017-05-03 13:42:21.000000000","message":"This test is still adding some value because it\u0027s testing something other than just config. Is there any reason to not keep this test?","commit_id":"e18923daa1e3bdf4ee444ebe44e6dd11e65676ec"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"bb6b1b43eb8eb68f8574ee73330cdbaf40d11d9b","unresolved":false,"context_lines":[{"line_number":1168,"context_line":"    @mock.patch.object(common_ldap.BaseLdap, \u0027_ldap_get\u0027)"},{"line_number":1169,"context_line":"    def test_user_enabled_invert_no_enabled_value(self, mock_ldap_get):"},{"line_number":1170,"context_line":"        self.config_fixture.config(group\u003d\u0027ldap\u0027, user_enabled_invert\u003dTrue,"},{"line_number":1171,"context_line":"                                   user_enabled_default\u003dFalse)"},{"line_number":1172,"context_line":"        # Mock the search results to return an entry with"},{"line_number":1173,"context_line":"        # no enabled value."},{"line_number":1174,"context_line":"        mock_ldap_get.return_value \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_e365fd46","side":"PARENT","line":1171,"in_reply_to":"5ff73747_43ef11e9","updated":"2017-05-03 13:48:29.000000000","message":"This method is duplicated with method in 1190 if we test with string \u0027False\u0027","commit_id":"e18923daa1e3bdf4ee444ebe44e6dd11e65676ec"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"fdee3d56d92b49120121c698f6f1d9dc52348c78","unresolved":false,"context_lines":[{"line_number":1168,"context_line":"    @mock.patch.object(common_ldap.BaseLdap, \u0027_ldap_get\u0027)"},{"line_number":1169,"context_line":"    def test_user_enabled_invert_no_enabled_value(self, mock_ldap_get):"},{"line_number":1170,"context_line":"        self.config_fixture.config(group\u003d\u0027ldap\u0027, user_enabled_invert\u003dTrue,"},{"line_number":1171,"context_line":"                                   user_enabled_default\u003dFalse)"},{"line_number":1172,"context_line":"        # Mock the search results to return an entry with"},{"line_number":1173,"context_line":"        # no enabled value."},{"line_number":1174,"context_line":"        mock_ldap_get.return_value \u003d ("}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_9edb307c","side":"PARENT","line":1171,"in_reply_to":"5ff73747_e365fd46","updated":"2017-05-03 14:01:02.000000000","message":"Aha - sure. Makes sense!","commit_id":"e18923daa1e3bdf4ee444ebe44e6dd11e65676ec"}]}