)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"255c7e48529b46a62c066984518297d07c916b16","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change info and baseclass of LDAPServerConnectionError"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The base class of LDAPServerConnectionError is changed from Error to"},{"line_number":10,"context_line":"UnexpectedError. Then its code and title are deleted and its info is"},{"line_number":11,"context_line":"changed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic9ac3443bb2117e33b1ec66d570ae2a7a2f62df2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ff0f0b1f_16d70df0","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":15},"updated":"2017-05-18 13:00:57.000000000","message":"what is the advantage of this change ? what does the buy us?","commit_id":"cd16b7885c69c2b7f6d80be00c3a1c341fef9681"}],"keystone/exception.py":[{"author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"change_message_id":"0686fcdf337a82f2745d61c96b04549be944711e","unresolved":false,"context_lines":[{"line_number":597,"context_line":"class LDAPServerConnectionError(Error):"},{"line_number":598,"context_line":"    message_format \u003d _(\u0027Timed out waiting to establish a \u0027"},{"line_number":599,"context_line":"                       \u0027connection to the LDAP Server (%(url)s).\u0027)"},{"line_number":600,"context_line":"    code \u003d 504"},{"line_number":601,"context_line":"    title \u003d \u0027Gateway Timeout\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_9f3c01c9","side":"PARENT","line":600,"range":{"start_line":600,"start_character":11,"end_line":600,"end_character":14},"updated":"2017-05-09 13:10:50.000000000","message":"Removing this would change the HTTP return code from 504 to 500, going from a \"Gateway Timeout\" to \"Internal Server Error\". The meaning of the error changes from a timeout to perhaps a server exception.","commit_id":"db8f6644b7816bcbaa08b9d06fcd9cf1be418af0"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"7bfa656ceed01795fb439a4fdb487c2e90bbfd2b","unresolved":false,"context_lines":[{"line_number":597,"context_line":"class LDAPServerConnectionError(Error):"},{"line_number":598,"context_line":"    message_format \u003d _(\u0027Timed out waiting to establish a \u0027"},{"line_number":599,"context_line":"                       \u0027connection to the LDAP Server (%(url)s).\u0027)"},{"line_number":600,"context_line":"    code \u003d 504"},{"line_number":601,"context_line":"    title \u003d \u0027Gateway Timeout\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_01e20130","side":"PARENT","line":600,"range":{"start_line":600,"start_character":11,"end_line":600,"end_character":14},"in_reply_to":"3f044301_9f3c01c9","updated":"2017-05-16 20:31:15.000000000","message":"either 500 or 504 are probably ok here. Changing the code makes this more generic, which seems like a good idea... the API caller doesn\u0027t need to know there was a timeout. And there\u0027s no backward compatibility concern with this change because it\u0027s generally agreed that you don\u0027t have to worry about that for 5xx errors... Folks may code to specific 2xx errors, but shouldn\u0027t be coding for 5xx errors (they should be fixing them). So changing from 504 to 500 should be fine.","commit_id":"db8f6644b7816bcbaa08b9d06fcd9cf1be418af0"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"5c9da054a151e40f9def727ae470b7a291befc4c","unresolved":false,"context_lines":[{"line_number":596,"context_line":""},{"line_number":597,"context_line":"class LDAPServerConnectionError(UnexpectedError):"},{"line_number":598,"context_line":"    debug_message_format \u003d _(\u0027Unable to establish a connection to \u0027"},{"line_number":599,"context_line":"                             \u0027the LDAP Server (%(url)s).\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_6141c539","line":599,"range":{"start_line":599,"start_character":34,"end_line":599,"end_character":55},"updated":"2017-05-16 20:26:22.000000000","message":"This message gets presented back to the end user who called the keystone API. We shouldn\u0027t be telling that user that keystone is using LDAP, much less what the URL of the LDAP server is. This needs to be more generic. Maybe just \"identity backend\"?","commit_id":"52cf38698dc10266f4888af41376d03774078e95"},{"author":{"_account_id":17860,"name":"Samuel de Medeiros Queiroz","email":"samueldmq@gmail.com","username":"samueldmq"},"change_message_id":"255c7e48529b46a62c066984518297d07c916b16","unresolved":false,"context_lines":[{"line_number":594,"context_line":"                       \"from accessing encrypted credentials.\")"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"class LDAPServerConnectionError(UnexpectedError):"},{"line_number":598,"context_line":"    debug_message_format \u003d _(\u0027Unable to establish a connection to \u0027"},{"line_number":599,"context_line":"                             \u0027identity backend (%(url)s).\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_56f6a591","line":597,"updated":"2017-05-18 13:00:57.000000000","message":"this is now with status code 500 from its parent, is that more appropriate? why?","commit_id":"cd16b7885c69c2b7f6d80be00c3a1c341fef9681"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"c1ed57fdfe1ada3c6cadac0d2d91f71138506b53","unresolved":false,"context_lines":[{"line_number":596,"context_line":""},{"line_number":597,"context_line":"class LDAPServerConnectionError(UnexpectedError):"},{"line_number":598,"context_line":"    debug_message_format \u003d _(\u0027Unable to establish a connection to \u0027"},{"line_number":599,"context_line":"                             \u0027identity backend (%(url)s).\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_f4cb986f","line":599,"range":{"start_line":599,"start_character":30,"end_line":599,"end_character":46},"updated":"2017-05-17 13:59:24.000000000","message":"I just realized that since this switched to using debug_message_format, the message we put here is only going to be returned when insecure_debug is True. In that case, if we leave it that way, it would be ok to say \"LDAP server\" here.","commit_id":"cd16b7885c69c2b7f6d80be00c3a1c341fef9681"},{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"db8083c7d143d3268b4d5b5a76a5f2fb3b3daf0a","unresolved":false,"context_lines":[{"line_number":596,"context_line":""},{"line_number":597,"context_line":"class LDAPServerConnectionError(UnexpectedError):"},{"line_number":598,"context_line":"    debug_message_format \u003d _(\u0027Unable to establish a connection to \u0027"},{"line_number":599,"context_line":"                             \u0027identity backend (%(url)s).\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_c8fead04","line":599,"range":{"start_line":599,"start_character":30,"end_line":599,"end_character":46},"in_reply_to":"ff0f0b1f_cb2a2a8f","updated":"2017-05-17 18:02:57.000000000","message":"Agreed. For debugging purposes, it would be nicer to indicate the backend is LDAP here if the information is only for debugging.","commit_id":"cd16b7885c69c2b7f6d80be00c3a1c341fef9681"},{"author":{"_account_id":16465,"name":"Kristi Nikolla","email":"knikolla@bu.edu","username":"knikolla"},"change_message_id":"811dee9cfc148c6d6f736389c4aa6f2e2f055945","unresolved":false,"context_lines":[{"line_number":596,"context_line":""},{"line_number":597,"context_line":"class LDAPServerConnectionError(UnexpectedError):"},{"line_number":598,"context_line":"    debug_message_format \u003d _(\u0027Unable to establish a connection to \u0027"},{"line_number":599,"context_line":"                             \u0027identity backend (%(url)s).\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_cb2a2a8f","line":599,"range":{"start_line":599,"start_character":30,"end_line":599,"end_character":46},"in_reply_to":"ff0f0b1f_f4cb986f","updated":"2017-05-17 17:36:23.000000000","message":"That was why I +1-ed earlier. I believe that amount of information should be in the debugging logs, since they\u0027re... debugging logs. And it\u0027s not presented back to the user.","commit_id":"cd16b7885c69c2b7f6d80be00c3a1c341fef9681"}]}